Giter VIP home page Giter VIP logo

tripolis-api's People

Contributors

jmslbam avatar peussen avatar

Stargazers

 avatar

tripolis-api's Issues

Just pass an Array as body instead of variables - v2.0 suggestion

I had a bunch of missing arguments ( smartGroupId & scheduleAt) for methodes like
public function publishEmail($eId, $contactGroupId, $mailJobTags = array()) https://github.com/martybel/tripolis-api/blob/bb7c0be039f3ba2bb6f002a739b984cbf5b40519/src/Service/PublishingService.php#L33

So I changed it to just pass a $body array to the method. Less code and more flexibility. Example: level-level@d2d2001

This will break backwards compatibility and this should be consistent throughout the whole project, so no PR for now ๐Ÿ’ƒ

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.