pf2etoolsorg / pf2etools Goto Github PK

Steps to reproduce
As the title, try converting Viking Vindicator (LOKL) if you want to try it for yourself.

Severity
Low, it's pretty visible

• MrVauxs#8622
  Verification: 0

Information
Currently spells can only tell that they belong to a class, subclass or a domain. We should be able to do the opposite and have the class data dictate what spells belong to it.

This can be expanded to a generic "grantsSpell" array or object, that can be applied to feats or heritages for example. With that expansion, it would be wise to add a References tab to spells, much like Traits have.

Who would use it?
Converters/Homebrewers

How would it work?
As explained in Information, we need a function that takes an array or object containing spells from class, subclass, feats, heritages, or other data that may come to mind, and implement it into the spells data that they list (a feat gives the Daze spell, the Daze spell lists the feat as a reference on the spell page).
See the mother site for examples on how they deal with class, subclass and race spells.

Why should this be added?
Sanity and ability to fully dictate to whom and where spells belong to.

• MrVauxs#8622

Upvote - revilowaldow#1

Upvote - spap#9812

Upvote - TopHatG#8946

Upvote - agateophobia.#5149

Upvote - _Costa#1356

Upvote - BiSP#8304

Votes: +6 / -0 / ±0

Steps to reproduce

1. Open Archetypes page
2. Select an Archetype
3. Try pressing J/K keys

Expected Behaviour: Row Navigation Down and Up accordingly
Witnessed Behaviour: Navigation response absent

Severity
Low

Additional information
Continuing from StR
3.1. Open Feats sub-window.
3.2. Try pressing J/K keys

Expected Behaviour: Row Navigation Down and Up accordingly
Witnessed Behaviour: Navigation response absent, sub-window collapses and closes.

• Hong Bo#9103
  Verification: 0

Steps to reproduce
When converting an entry with "Effects" or "Effect" in it's description, the Converter breaks with Unexpected token of type "EFFECT"! Expected "SENTENCE_SEMICOLON_NEWLINE,SENTENCE_SEMICOLON,SENTENCE_TERM_NEWLINE,SENTENCE_TERM,SENTENCE_NEWLINE,SENTENCE". at Converter._consumeToken (http://localhost:8080/js/converter.js:1771:51)

Severity
Medium

Additional information
"A"

• MrVauxs#8622
  Verification: 0

Information
Simply make it possible to search by a specific amount of gold rather than preset amounts. See the other site for how it can be done.

Who would use it?
Everyone on the Items page looking for equipment within their budget.

How would it work?
As usual, just with more options.

Why should this be added?
Actually allows for accurate tracking of what items you can purchase than have to round it up and down. What if I have 75 gp? I must either limit myself down to 50 gp or have a lot of items that are above that budget by picking the 100 gp filter.

• MrVauxs#8622

Indifferent - spap#9812

Upvote - TopHatG#8946

Votes: +1 / -0 / ±1

Steps to reproduce
When printing... anything, you can see on the preview that text more often than not gets cut off if it has to go beyond a single page.

I think it's best if it moved the entire paragraph to the next page if it were to be cut off. Or at least, make it so text itself is not cut in half or otherwise cropped, and have actual margins on the next page.

Severity
Low

Additional information
Would be a neat feature with that fixed.

• MrVauxs#8622
  Verification: 0

Steps to reproduce
Attempt to use the text: search on the items page

Severity
Medium, breaks non-essential a feature

Additional information
Uncaught TypeError: parts.push(...).map is not a function
render:7423

• MrVauxs#8622
  Verification: 0

Information
It would be nice to filter out common or uncommon on the archetypes page

Who would use it?
Anyone looking at archetypes

How would it work?
Same as the other filters... just for common and uncommon

Why should this be added?
It would help whittle down the uncommon choices for players trying to pick an archetype, especially for free archetype games

• lhx#2040

Upvote - spap#9812

Votes: +1 / -0 / ±0

Steps to reproduce
See Shielded Tome and Raise a Tome feats. They should lead to eachother, but they are not.

Severity
Low

Additional information
Not sure why it fails to tag these while others are correct, especially when there are feats with exactly same structure (say, Miniaturize and Shrink Down)

• MrVauxs#8622
  Verification: 0

Information
Have a ||5eTools|| style changelogs channel where major releases of the site ping users with an in-discord changes summary. This would be in addition to #git

Who would use it?
All server users, opt in/out role.

How would it work?
Ask Dusk.

Why should this be added?
Makes people aware of major updates and drives server engagement as people are pulled back in.

• revilowaldow#1

Upvote - revilowaldow#1

Upvote - spap#9812

Votes: +2 / -0 / ±0

Steps to reproduce
As the title implies, homebrew traits do not get categorized into proper trait categories in filters. You can test this with Rabbitfolk and the Rabbitfolk trait, which should be in Ancestries & Heritages, but it instead is in the General category.

Severity
Low

Additional information
The data of the feat is exactly the same as any other Ancestry & Heritage trait, but with a different name and homebrew source.

• MrVauxs#8622
  Verification: 0

Steps to reproduce
A rather annoying quirk of the Text Converter is that everything that isn't the actual description of something has to NOT end with a space or it'll break.

It often happens with beginning [name] [type] [level] , but I remember it happening in other places as well.

You can use any of the sample items and just add a space to the end of their first line.

Severity
Low

Additional information
It would be neat to have the text converter either ignore or highlight such vestigial spaces, as they are always a problem of copying straight from a PDF rather than user error.

Also some checking of what came out of the converter would be good, as often spaces infer that the line hasn't ended. This can cause something like "bulk": "L This item looks like an ordinary glass flask full of water.", because it had Bulk L right before the start of the item description in it's text form.

• MrVauxs#8622
  Verification: 0

Steps to reproduce

1. Open bestiary.
2. Add "Adult Black Dragon" and "Adult Blue Dragon" with the plus button to the list.
3. Press "Printer view" button.
4. Observe as nothing happens.

Severity
High

Additional information
Browser: Google Chrome (v 104.0.5112.81)
Extensions: tested after disabling all extensions and deleting cookie data

The following error is logged into console:

utils-list.js:1 Uncaught (in promise) TypeError: ListUtil.getSublisted is not a function
at Object.genericPinKeyMapper (utils-list.js:1:21577)
at PrintModeView.popTblGetNumShown (bestiary.js:17:5689)
at PrintModeView._renderContent (shared.js:70:29839)
at PrintModeView.pOpen (shared.js:75:104)
at PrintModeView.pHandleSub (shared.js:75:805)
at BestiaryPage.pDoLoadSubHash (bestiary.js:17:590)

• solonkovda#6481
  Verification: 0

Steps to reproduce
Open the Items page
Open the filter
See the price range going from your usual numbers to about 300 NaNs (in console, they're undefined)

Severity
Low, the filter is functional just, incredibly bogged down by the fake entries

Additional information
It doesn't seem to be anything related to the item filters themselves, but the RangeFilter function?
Whatever the options in the Price RangeFilter, the undefined spam stays.

• MrVauxs#8622
  Verification: 0

Steps to reproduce
See Acrobat (GMG) damage (+5 instead of +4)

Severity
Medium

Additional information
why

• MrVauxs#8622
  Verification: 0

Steps to reproduce
https://cdn.discordapp.com/attachments/781583619848273920/1011696610264219719/unknown.png

Severity
High

Additional information
This seems to be a recurring issue...

• MrVauxs#8622
  Verification: 0

Steps to reproduce
Open https://pf2etools.com/companionsfamiliars.html

Severity
High

Additional information
Look at this photograph https://i.ibb.co/g99KqKJ/Screenshot-2022-07-26-at-16-45-56.png

• spap#9812
  Verification: 0

Steps to reproduce
Open the archetypes page (on dev)

Severity
Critical

Additional information
Uncaught TypeError: Cannot convert undefined or null to object at archetypes.js:313
Most likely in relation to our last removal of render-X

• MrVauxs#8622
  Verification: 0

Steps to reproduce
Go to the bestiary, filter by any of the specific alignments (e.g. Chaotic Good). There should be results (the Anadi Sage is chaotic good, but it doesn't show up) but nothing is returned

Severity
Low

Additional information
Filtering by not a specific alignment includes creatures with that disallowed alignment, so I imagine it thinks that creatures don't have an alignment at all. Filtering by 'any' alignment does seem to work though, as it brings up a single result.

• AchillesUltimate#8629
  Verification: 0

Steps to reproduce
When browsing the Summoner page, all "data" entries referencing eidolon statblocks return undefined on the main site.

I cannot replicate this on the bug or dev branch.

Severity
High

Additional information
???

• MrVauxs#8622
  Verification: 0

Steps to reproduce

1. Input the text for the Sample Creature (seen in Help tab, which can be opened with the button in the bottom left)
2. Click Parse
3. Observe that the line corresponding to the creature's attack:

Melee [one-action] hand +24 (finesse, magical), Damage 4d8 negative plus paralyzing touch

is converted into

"attacks": [
	{
		"range": "Melee",
		"activity": {
			"number": 1,
			"unit": "action"
		},
		"traits": [
			"finesse",
			"magical"
		],
		"name": "hand",
		"bonus": 24,
		"damage": "{@damage 4d8} negative plus paralyzing touch"
	}
]

Notably, it has "bonus": 24 instead of "attack": 24, and it is missing types:

"types": [
	"negative"
]

When viewing the added creature in Bestiary, it shows up like this:

Instead of this:

Severity
Low

Steps to reproduce
Open any monster and compare their numerical statistics, such as HP, saves, ability scores and see the discrepancy. Tested on Unseen Servant, Anadi Seeker, Apothecary.

Severity
High

Additional information
https://cdn.discordapp.com/attachments/540591974353469462/969952318080565328/unknown.png

• MrVauxs#8622
  Verification: 0

Steps to reproduce
Switch to Encounter Builder mode in the Bestiary, then attempt to add a creature to the list

Severity
Medium

Additional information
When attempting to add a creature to the list, it says "Please first view something from the list" and doesn't add anything. Attempting to remove a creature from the list does nothing, nor does increasing how many of the creature.

• Ethmaker#5998
  Verification: 0

Steps to reproduce
Rune Builder, Items Page, Spells page, Rituals page, you name it. You can add things, you can subtract things, but you cannot remove things. The only solution to this problem is the nuclear one, which is Delete All.

Severity
High

Additional information
Especially annoying in the Rune Builder, where you cannot remove a rune after adding it in.

• MrVauxs#8622
  Verification: 0

Steps to reproduce
Open up the Spells page

Severity
Medium?

Additional information
No spells are loading, clear cache doesn't seem to fix it

• kierann#6245
  Verification: 0

Steps to reproduce
Hover over a subclass in e.g. "Access Lore", observe console

Severity
Trivial

• revilowaldow#1
  Verification: 0

Steps to reproduce
Go to either Ancestry or Class page and when browsing the entries feats, click on the aforementioned button. It doesn't do anything.

Severity
Medium

Additional information
"A"

• MrVauxs#8622
  Verification: 0

Steps to reproduce
When a spell duration says "until the start of your next turn", the Text Converter doesn't recognize that as a "timed" duration (instead putting "unit": "unknown"), and thus does not get rendered on the sheet.

It should be parsing that as "type": "timed", and with a duration of 1 round.

Severity
Low

• MrVauxs#8622
  Verification: 0

Steps to reproduce
Load archetypes page

Severity
Low

Additional information
https://i.ibb.co/s3t0kp1/Screenshot-2022-10-02-at-20-19-56.png
Also noticed that it redirects from /archetypes.html to just /archetypes 🤔

• spap#9812
  Verification: 0

Steps to reproduce
Open the following (or more) websites:
https://pf2etools.com/items/soaring-loag.html
https://pf2etools.com/items/fake-blood-pack-lotgb.html
https://pf2etools.com/items/looters-lethargy-aoe1.html

Severity
Low

Additional information
Ignoring 404 errors of favicons, it seems to be a lack of an encoder?

• MrVauxs#8622
  Verification: 0

Steps to reproduce
Pin an item with a listed cost of N cp per X, like candles, torches, or sacks. Note that the pinned list's total cost goes up in increments of 1.1cp.

Severity
Low

Additional information
https://cdn.discordapp.com/attachments/991688568823087154/1001324175975256106/unknown.png

• spap#9812
  Verification: 0

Steps to reproduce

• Open spells.html
• Select any one of the above filters
• Observe nothing happening

Severity
Medium

Additional information
:tiredVauxs:

• spap#9812
  Verification: 0

There is an issue with the level for cantrips as it is labeled as level 0 even if the spell is not 0th level.

Spells affected:
Almost all cantrips have this issue.

Example:
Allegro is level 7 but also a cantrip

Steps to reproduce
testbug4

Severity
testbug4

Additional information
testbug4

• LordDusk#0001
  Verification: 0

Steps to reproduce
Advanced Mode checkbox has a massive "hitbox" when it comes to it's width. You can click on the middle lower portion of the menu and enable it by accident.

Severity
Low

Additional information
Just an annoyance, but still one that exists.

• MrVauxs#8622
  Verification: 0

Steps to reproduce
Go to Bestiary
Try to scale a creature
Get Uncaught (in promise) TypeError: Cannot read properties of undefined (reading '2')

Severity
High

Additional information
"A"

• MrVauxs#8622
  Verification: 0

Information
As any other entity, it would be great to have these done so we can convert everything over from books smoothly and efficiently.

Who would use it?
Every converter

How would it work?
As any other entity

Why should this be added?
Efficiency of converting stuff, as well as simply having a feature complete Text Converter with the two other suggestions (Vehicles, Hazards)

• MrVauxs#8622
  Votes: +0 / -0 / ±0

Steps to reproduce
Creatures have an issue where above their attack, a written "undefined" appears.

Severity
Low

Additional information
I found that deleting the getAttacks from creatures renderer also removes the undefined, so it is most likely a bug in there.

• MrVauxs#8622
  Verification: 0

Steps to reproduce
TC's Saving Throws crash the Spells page.
TC converts Range in a way that is not rendered.
Spell Components are an object instead of an array of objects.

Severity
High

Additional information
Not really.

• MrVauxs#8622
  Verification: 0

Steps to reproduce
Add a homebrew file containing a book to the PF2eT homebrew folder and the index.json file
Open the book in the browser
See the error, two identical indexes, on the left

Severity
Low

• MrVauxs#8622
  Verification: 0

Steps to reproduce
Add spells to a list on the Spells Page
Get link to Filters with Shift on
Copy paste it into another tab or browser, preferably incognito
See that the list does not populate and we get Cannot read properties of undefined (reading '_multiSource') errors

Severity
Low

• MrVauxs#8622
  Verification: 0

Steps to reproduce
Filtering almost anything other than sources on the classes page causes class features and subclasses to disappear. This shouldn't really happen.

Severity
Medium

Additional information
This limits the page's filtering ability quite a bit, as you cannot view a class in 100% when filtering.

• MrVauxs#8622
  Verification: 0

Steps to reproduce
go to quick reference page on pf2e

Severity
High

Additional information
Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'forEach')
at Object.getEntryIdLookup (shared.js:160:17908)
at Object.showBookContent (bookutils.js:1:6248)
at doPopulate (bookutils.js:1:19683)
at Object.pLoadBook (bookutils.js:1:19964)
at async pHandleFound (bookutils.js:1:16768)

• Coul#3188
  Verification: 0

Steps to reproduce
Currently the filters depend on Trait Categories. The new Text Converter also assumes that the page depends on those, so it does not add the "creatureType" array to the statblock.

Unfortunately, the Bestiary page's middle column "Type" does require that array. It shouldn't.

Severity
Medium

Additional information
Any new creatures added through the Text Converter suffer from not having their type shown on the list.

• MrVauxs#8622
  Verification: 0

Steps to reproduce
Click on a sidebar heading to copy the URL, e.g. https://pf2oo.ls/book#crb,1,dice,0.
Open URL.
Notice the page doesn't jump to said heading.

Severity
Low

Additional information
pwetty pweeze :3

• spap#9812
  Verification: 0

Steps to reproduce
Open the Items page and select a price filter
See that the filtered item prices don't match up with what the filter says. 11 gp items are shown on ">25 gp" filter, or 30 gp items on ">50 gp".

Severity
Medium

Additional information
Honestly I think this warrants a re-do of the filter but my attempts to make it any better led me to crashing the website with the browser running out of memory.

• MrVauxs#8622
  Verification: 0

Steps to reproduce
The Text Converter erronerously converts pretty much any ability starting with the word "Speed" into a speed entry rather than an ability. See Speed Surge in Drakes, for example.

Severity
Medium

Additional information
Filling this out because the bot otherwise breaks.

• MrVauxs#8622
  Verification: 0

Steps to reproduce
Spell Domains are still converted as Cleric subclasses while they should be in their own separate "domains" array.

Severity
Medium

Additional information
"A"

• MrVauxs#8622
  Verification: 0

Steps to reproduce
E.g. The clockwork traits
If the content has the same name it is not possible to access a version with a separate source.
The url does not include a fragment for the source and so will only return the first version no matter which is clicked on the site.
The same behaviour is seen in the popouts from the omnisearch

Severity
Medium

Additional information
https://pf2etools.com/traits.html#%5bclass%5d,fbsr:clockwork

• revilowaldow#1
  Verification: 0