pharan / spine-unity-playmaker Goto Github PK

Hi,

following our mail of last week, please find some comments on them actions:

On this action specifically: https://github.com/pharan/spine-unity-playmaker/blob/master/Assets/Spine/spine-unity/Modules/PlayMaker/Actions/SpineAnimationStateAction.cs

it's better to make an action for each api, here you have condensed several very distinct api usage into one, which will make a state harder to understand because all actions will be named the same, so I suggest splitting this action into

SpineSetAnimation,
SpineAddAnimation,
SpineSetEmptyAnimation,
SpineAddEmptyAnimation,
SpineClearTrack

some general remarks:

• you don't need to add "action" as the end or each action name, "SpineSetSkinAction" should only be SpineSetSkin, as we know it's an action by definition.
• the action itself should also have a tooltip, not just the public fields
• All public fields should have a tooltip

apart from that, they look very good and complete. Looking forward to test them!

Bye,

Jean