Giter VIP home page Giter VIP logo

Comments (4)

dsrees avatar dsrees commented on May 24, 2024 1

👍🏼 Looking good locally. Thanks for quickly resolving this, I appreciate it.

(I didn't bother getting assets to work locally, but the code examples render correctly)
Screen Shot 2023-10-03 at 11 21 40 AM

from phoenix_storybook.

cblavier avatar cblavier commented on May 24, 2024

Hey Daniel,

theme has indeed a special meaning in the storybook. I recommend you read this guide

But it shouldn't be removed from your code unless you explicitly use the theming assign strategy.

I'll have a look into it

from phoenix_storybook.

dsrees avatar dsrees commented on May 24, 2024

Thanks @cblavier for pointing out those docs and taking a look. We are not making use of any theming as described. Happy to provide more details if helpful.

from phoenix_storybook.

cblavier avatar cblavier commented on May 24, 2024

I just fixed the issue, would you mind testing your code against storybook's main branch to make sure this is ok now?

(if you have any issues with assets while testing an unreleased version of the library, please make sure you have read https://github.com/phenixdigital/phoenix_storybook#contributing)

from phoenix_storybook.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.