Comments (3)
cblavier
commented on May 23, 2024
1
Since all HTML (storybook's and application's) are living in the same document, we needed to figure out a strategy to prevent CSS leaking (both ways).
This documentation explains all of this: https://hexdocs.pm/phoenix_storybook/sandboxing.html (part 3 is explaining the important part)
from phoenix_storybook.
cblavier
commented on May 23, 2024
Sounds like a duplicate of #419 no?
The fix in the generator is not yet released but you can do the change manually on your layout file
from phoenix_storybook.
sgardn
commented on May 23, 2024
It is indeed a duplicate - thanks! I didn't think to check in resolved issues, figured it was a new issue 😵💫
Can you explain a little why it's worth prefixing the tailwind classes for the "normal" app with the .important class to override specificity? It feels a little odd to me that installation / usage of the package ends up being "visible" in the HTML of the actual web app itself.
If it's possible, it might be preferable to avoid that. I realize this might mean some changes for the storybook pages / HTML / classes, but might make page painting slightly quicker for actual apps and avoid confusion down the road.
from phoenix_storybook.
Related Issues (20)
- Stories with large attributes fail to load HOT 3
- Hex release not independently compilable HOT 2
- Make CSRF token optional
- Generated stories have `Elixir.` prefix in aliases and for function components
- Compile failure with earmark 1.4.41 HOT 3
- `theme` Attribute does not render in the example code HOT 4
- Cannot get any of my own components to display properly in the stories view HOT 11
- Strange whitebar on chrome/safari since MacOS Sonoma update
- Inter font makes request to external source
- Add `defer` attribute to `<script>` tag HOT 1
- Global Color Change HOT 1
- Prefix event names in StoryLive
- Elixir warning for slice with negative steps
- allow passing additional options to story HOT 1
- Compatibility with Phoenix HTML 4.0.0
- error: undefined function (there is no such import) nofile:1 HOT 2
- Following phx.gen.storybook Instructions Breaks All CSS on Pages HOT 2
- How can I add components from different module than CoreComponents? HOT 1
- protocol consolidation in storybook files HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from phoenix_storybook.