Giter VIP home page Giter VIP logo

obsidian-emoji-shortcodes's Introduction

obsidian-emoji-shortcodes's People

Contributors

aziham avatar i-dont-remember avatar konhi avatar phibr0 avatar sidrubs avatar tswwe avatar usagizmo avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar

obsidian-emoji-shortcodes's Issues

[Feature]: Please Add Settings Search Functionality to this Plugin

Hello!

A user in a repo I help manage, https://github.com/javalent/settings-search, is having issues with our plugin. During the course of testing, I noticed some inconsistencies with how setting search was retrieving the contents of Emoji Shortcodes' settings. As Settings Search is meant to address a gap in keyboard functionality, and meant to provide more accessibility to users, I am bringing it to your attention.

For example, searching the entire plugin by front-facing name (Emoji Shortcodes versus Obsidian Emoji Shortcodes or even Emoji-Shortcodes) should bring up the option to open most of the settings as well as go to the community settings page. In my testing, it brings up more options when searching emoji, than emoji shortcodes, and it does not offer the community page or settings at all. I use dataview as a counter-example in the gif below. As settings

settings-search

Should you choose to implement this feature request, the API to add Setting Search Functionality is very basic, and found on our Publish Documentation (By the time you get to this, the main readme may have changed). Additionally, if you have any questions about implementation, feel free to reach out to javalent#3452 on The Obsidian Discord or @valentine195 here on Github.

Thank you for your time, and happy coding!

Inconsistency in the behaviors according to how we write the emoji

I tried to use this plugin by writing the name but it didn't gave the same result according to how I wrote it. I don't really know how to explain it so here is a screenshot of some tests. (left edit, write preview)
In the first case, I insert the emoji after writing the whole sentence.
Capture d’écran de 2021-08-23 14-16-53

I'm using Ubuntu 20.04.2 LTS
Obsidian 0.12.12
Emoji Shortcodes 1.4.0

Thanks
Ccile

I have no idea on how it should work but I think I would prefer to have the small picture in both view : edit and preview.
My second choice would be the name in edit and the small picture in preview.

Carriage return doesn't work and other issue

Expected Behavior

  • Carriage return happened normally after :.
  • The plugin unload right after deactivation

Actual Behavior

  • Carriage return doesn't work after :
  • Emoji doesn't appear with a sentence like something like that : emoji doesn't work
  • Plugin doesn't unload properly

Steps to Reproduce the Problem

  1. Write a sentence followed by :
  2. Try to do a carriage return.

Specifications

  • Version : 1.3.3
  • Platform : Windows
  • Obsidian version : 0.12.13
2021-08-21.14-46-08.mp4

Better ordering of Emoji suggestions

First of all, I and very thankful for this plugin ⭐ . I enjoy using emojis in my notes as the small images make some content more easily communicated.

However, during usage of the plugin, I noticed, that the order of the suggesting emojis when starting a shoartcode : is sub-optimal.

Consider these shortcodes: star, heart, x and right
When using the first three, I expect, that after typing it out, the top-most suggestion is the most specific one corresponding to it.
e.g. for star I expect the star ⭐ suggestion to be top-most. However, we see a different list:
image

The same problem also appears with the other shortcodes.

image

image

This is less helpful, as sometimes we need to scroll down a lot to see the right emoji.

For the prefix right, we get these suggestions:
image

However, I think it's better, when shorter completions such as arrow_right, fist_right and copyright are higher prioritised than the other ones. Generally, if the suffix needed to complete the shortcode is short, then the emoji should be higher on the list.

And for the case of x, if the emoji is short alltogether and has a relatively large matching with the prefix shortcode, then it should be also higher on the list.

Most other existing emoji shortcode suggestion lists seem to return, what I would intuitively expect. For instance, when writing an issue comment, the github emojis suggest this:

Screenshot from 2022-05-08 17-06-08

Screenshot from 2022-05-08 17-07-37

Screenshot from 2022-05-08 17-06-52

Could we have the shortcodes prioritised differently?

What do you think? ⭐

If there is need, I could provide some help.

This issue relates to: #31

Some bugs

Hi. I like this handy plugin but I ran into some bugs in using it. Here are the reports (in the given example below, the cursor position is symbolized by ▊):

  1. If the text after the cursor contains :, the Immediate Emoji Replace function will fail in recognizing the emoji shortcodes at the cursor.

    e.g., it fails turning [:link:▊Title](https://aaa.com) into [🔗▊Title](https://aaa.com)

  2. If the text after the cursor contains :, the Emoji Suggester will fail in inserting selected emoji correctly.

    e.g., if we type [:▊Title](https://aaa.com) to trigger the Emoji Suggester board, then click to select an emoji (say 🔗), the text will become [🔗▊//aaa.com), which is not what we expect to be.

  3. If the preceeding charactor right before the cursor is a `, an alphabet or a number, you can't trigger the Emoji Suggester board by inputting a :.

    e.g., given TryToTriggerThat▊, then input a :, the Emoji Suggester board will not pop up.

  4. If the preceeding charactor right before the cursor is an alphabet or a number, and the cursor is not at the end of the line, the Immediate Emoji Replace function will fail in recognizing the emoji shortcodes at the cursor.

    e.g., it fails turning TryToTurn:link:▊That into TryToTurn🔗▊That

  5. If the text before the cursor contains :non-shortcode, you can't feed a new line by just pressing Enter.

    e.g., given ShowCase:PressEnter▊, then press Enter and nothing will happen. There is a workaround: input a space or press Esc before press Enter.

  6. If the whole line is a single :▊ with your cursor at the end of the line, you can't feed a new line by just pressing Enter.
  7. The plugin seems not to check if the cursor is in an inline-code/inline-math/codeblock/mathblock. This may cause the emoji shortcodes in the inline-code/inline-math/codeblock/mathblock be turned into an emoji symbol.

    e.g., `console.log(":link:")` is at a risk of being turned into `console.log("🔗")` (both in edit mode and preview mode)

Hopefully, I have read the source code (.obsidian/plugins/emoji-shortcodesmain.js) and I think I can fork the repo and help fixing these problems. If things go well, I will submit a pull request in next 2-3 days.

Should this work on macOS? It doesn't for me. 😞

In a blank new note I start typing a colon ( : ) and continue typing an s, then an m, then an i, ... nothing pops up like I see it in the animated GIF in the readme ... 😳

What does work is: when I finished typing :smile: the rendered view (the preview/reading pane) shows the smile emoji.

(Would love to add an animated GIF that shows this but don't know how to make one (with reasonable effort)).

Using Obsidian 0.15.3 Insider build on macOS Monterey 12.4 on an intel Mac, btw.

Suggest Frequently Used Emojis First

The emoji suggester is very nice and I often use it to quickly select certain emoji I use that have long names to save time. One of these is ✅ or : white_check_mark : , but by default this is at the bottom of the suggestions list. I'd prefer to get the last used emoji in the search first so I can quickly get this.

Unable To find this Plugin In The Community Plugins

Hi!
Has there been any Obsidian update that is making this plugin defunct?

I couldn't find in the Obsidian Community Plugins.
I manually download the source code and pasted into the plugins folder but when I try activating it says "failed to load the plugin"

Can you guide me if there's something wrong?

Thanks!

Access all the emoji by some reduction

Thank you for the extension, but it would be nice to access all the emoji (if, for example, you do not remember its abbreviation as I do) by some reduction, for example:

:?

well or some other in the same vein

Only trigger if preceded by a space (e.g. not 4:30)

Would love to have at least the option of not triggering this if the colon isn't preceded by a space. When trying to type a time of day (10:00, 4:30) the plugin is triggered, and if one doesn't pay attention, the :00 or :30 will be automatically replaced by an emoji. Another option would be to not trigger if a number comes before the colon.

1.0.0: Seems emojis with underscore don’t work

(EDIT: See below) I like the immediate replace against a Unicode char, even in edit mode. Another useful one, thanks!

For some reason, emojis using an underscore in their name don’t work, try:

:purple_heart:
:broken_heart:

😀
:woman_bowing:

Maybe CM hits in, thinking an italicized word is coming?

I’ll still have to try in a naked vault, results in a moment.

EDIT: It’s the same in a new vault, with no other community plugins installed.
Using Obsidian 0.12.12, installer 0.12.10, on Linux (AppImage).

Emoji Suggester inside [[links]] and in file title?

Hi,

I use a lot of emoji to indicate the type of note, 👀 for human , 📚 for book and so on, and when I try to type ":eyes:" inside [[]], I don't get any suggestion, neither in the title bar.

Thanks for all

Missing modifier characters in YAML frontmatter

Using :heavy_check_mark: in YAML frontmatter should render (U+2714, U+FE0F), but seems to only be rendering the first character. Using it anywhere in the normal editor renders it correctly. If adding the emoji using another method both characters are rendered, and it appears correctly as ✔️.

Not working on iPad

Though this is installable on Obsidian Mobile, but isn’t working on iPad. The text remains as in. Can anyone confirm that it does work on iOS?

Add ability to use custom emojis from file system

When using a messaging client like Slack, you can add custom emojis to use. It would be nice to have that option with this plugin that uses custom emojis from a folder.

Is this plugin is still maintained?

Some emojis aren't available

I've noticed that I can't get some emojis to appear, no matter what emoji code I use.

An example is large green circle.
I've used both shortcodes suggested in the above page, but it doesn't render and/or appear on the suggestion droplist.

image

Unfortunately housamz json with the emojis isn't complete and I would like my circles to be super colorful.
Is it ok if I just add them to the emojiList.ts and add a pull request? :)

search for emojis

I like your plugin. I use the "immediate emoji replace" option. That way I can also use the native emojis on the iphone app.
However, I just realized that I can't use the : tag completion in the search box.
When I copy and paste an emoji in the search it works.
Would it be possible to enable the : tag completion in the search box?

thanks!

[Feature Request] Filter as partial match

Hi, @phibr0 .

Thank you for your great plugin!

I would be glad if it would be great to enable the filter prefix not only to match but also partial match. In my case..

image

I want to insert these emojis.

image

Best regards.

Can't emoji shortcodes in the browse section

Hi,

Thanks for making this plugin! I was trying to install it from the Browse section from setting but it says 'no results found'. Just wondering if you have any idea why that is, I found it quite strange 🤔

image

Don't Show Emoji Suggester when typing "::"

The emoji suggester is nice, but for things like Dataview which use two colons, it's annoying to have the emoji suggester pop up. The instructions say this will only appear when typing letters, so I'm guessing this could be a quick fix to filter out any non-letters for having it appear?

Expand flag emoji names

Hello & thank you for this helpful Obisdian plugin!

I noticed that some country flags are only accessible (examples). Would it make sense to use both the shortcode, and name, such as :uk-united-kingdom:, :de-germany:, :ru-russia:, :tr-turkey:etc.?

As you can see, some shortcodes are less obviously derived from the full name than others, and esp. for the former, a wider search space for fuzzy matching would be neat :-)

Keyboard symbols/ALT codes instead of emojis?

I realized that for a few emojis, the usual emoji is replaced by the keyboard symbol (Windows ALT codes?). I included screenshots below, and the original emojis I was looking for are ❤️ and ☔️:

Screen Shot 2022-11-12 at 9 30 52 PM
Screen Shot 2022-11-12 at 9 31 00 PM

iOS version not working

Hi there
Since last update of the plugin (2.1.0), it seems that the plugin does not work on my iOS setup. Would you know why or if there are conflicts with other plugins?
Thanks in advance

Specify shortcode convention

First of all, great addon!

I was wondering which convention you follow for the codes. I know at least three of them: github, slack, emojipedia. This would be very useful information to be added to the readme.

I am also asking because I wanted to add some missing emojis, such as the shrugging ones #18 and there the codes are all distinct.

Shortcodes do not work inside tasks

I have both Tasks and Emoji shortcodes plugins enabled.
Typically, shortcodes work, but the popup does not appear when I type the : trigger followed by a letter inside a task (- [ ] ). I even have autosuggestion turned off for the Tasks plugin.

Dataview and Tasks performance issues

Hi there, nice plugin.

I'm not sure whether to raise this here or with Dataview, but I've discovered that enabling this plugin can cause some of my dataview tables to render about 3x slower.

I've prepared a test vault.
test.zip

Just open on Dataview.md, wait for it to render. This takes about 3 seconds on my machine.
Then, open another file and enable the plugin.
Finally, open Dataview.md again. This takes about 9 seconds on my machine.

Thanks for your time :)

(I have also raised this with a certain theme which makes this problem even worse - but my times here were tested with the default theme.)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.