philippeweidmann / notificationtoast Goto Github PK

The view attaches to the top view controller which is obviously by design. But this means that if another controller comes into view modally, the view attaches to the top of it and can be pulled down with it. This isn't the behaviour of the native toast.
Sorry have no idea for a PR myself but I thought I'd mention it. Thanks!

could you please release like pod?

https://github.com/omaralbeik/Drops

I think you might want to add a license to this project, such as the popular MIT License.

In my application,
I have the function to sign in with apple.
Firstly, I touch up inside the sign in with apple button, the sign in form will show. Show ToastView after the sign in process is completed but nothing happens (the toast view not show).

private func singinError(message: String) {
        let toast = ToastView(title: message)
        toast.show(haptic: .error)
    }

I try to debug in the init func of ToastViewWindow

let scene = UIApplication.shared.connectedScenes.first(where: { $0.activationState == .foregroundActive }) as? UIWindowScene

At this time, activationState is foregroundInactive.
My opinion, we should add filter condition. It looks like:

let scene = UIApplication.shared.connectedScenes.first(where: { $0.activationState == .foregroundActive || $0.activationState == .foregroundInactive }) as? UIWindowScene

I will be happy if it is fixed.

Thanks!

Thanks for a really useful tool , just a comment, I think it would be cool if the class handled the main thread part of things.
The show and the hide functions are easy to wrap in main async code but not the initializer. Is this possible ? thanks

I have no clear steps for this, but it happened already twice on my side.
Will try to track it down and see if i can find some steps for this one

I just faced a request where I'd need to show subtitle in two lines, is it possible to do it now or we should create a PR for it?

Calls in non-main threads cause crashes sometimes.

I think we should maybe introduce a flag if toast is already displayed to avoid stacking plenty of them in a situation when toast is getting displayed on some button type to avoid stacking of it.

Let me know what you think about the idea, I can maybe push this change if you agree.