README states:

By default, πmenu is installed into the /usr/local prefix.  Enter the
following command to install πmenu (if necessary as root).  This command
installs the binary file ./pmenu into the ${PREFIX}/bin/ directory, and
the manual file ./pmenu.1 into ${MANPREFIX}/man1/ directory.

    make install

But, in config.mk, PREFIX and MANPREFIX are defined as:

# paths
PREFIX = ../..
MANPREFIX = ${PREFIX}/man

This settings will cause make install to install, by default, pmenu in ../../bin and pmenu.1 in ../../man/man1 which is very weird as a default and is not coherent with what is written in README.

Also note that, in xmenu's default config.mk, MANPREFIX is set to ${PREFIX}/share/man, while the default value for pmenu is ${PREFIX}/man.

Here is what I am doing to produce the crash. (compiled with -g for debug info)

mag 21:27:19 | ~/tmp/pmenu $ valgrind ./pmenu -r 3 <<!
IMG:/home/mag/pic/icons/folder.png              pcmanfm
IMG:/home/mag/pic/icons/librewolf.png   librewolf
IMG:/home/mag/pic/icons/power.webp
        IMG:/home/mag/pic/icons/phoenix.png             reboot
        IMG:/home/mag/pic/icons/skull.png               shutdown now
IMG:/home/mag/pic/icons/art.webp
        IMG:/home/mag/pic/icons/krita.png               krita
        IMG:/home/mag/pic/icons/gimp.webp               gimp
IMG:/home/mag/pic/icons/message.webp
        IMG:/home/mag/pic/icons/discord.webp    librewolf discord.com/login
        IMG:/home/mag/pic/icons/nheko.png               nheko
        IMG:/home/mag/pic/icons/hexchat.png             hexchat
!
==24177== Memcheck, a memory error detector
==24177== Copyright (C) 2002-2017, and GNU GPL'd, by Julian Seward et al.
==24177== Using Valgrind-3.17.0 and LibVEX; rerun with -h for copyright info
==24177== Command: ./pmenu -r 3
==24177== 
librewolf discord.com/login
==24177== Invalid read of size 8
==24177==    at 0x1106F7: run (pmenu.c:1460)
==24177==    by 0x1112D7: main (pmenu.c:1666)
==24177==  Address 0x18 is not stack'd, malloc'd or (recently) free'd
==24177== 
==24177== 
==24177== Process terminating with default action of signal 11 (SIGSEGV): dumping core
==24177==  Access not within mapped region at address 0x18
==24177==    at 0x1106F7: run (pmenu.c:1460)
==24177==    by 0x1112D7: main (pmenu.c:1666)
==24177==  If you believe this happened as a result of a stack
==24177==  overflow in your program's main thread (unlikely but
==24177==  possible), you can try to increase the size of the
==24177==  main thread stack using the --main-stacksize= flag.
==24177==  The main thread stack size used in this run was 8388608.
==24177== 
==24177== HEAP SUMMARY:
==24177==     in use at exit: 3,845,712 bytes in 11,938 blocks
==24177==   total heap usage: 21,769 allocs, 9,831 frees, 12,658,781 bytes allocated
==24177== 
==24177== LEAK SUMMARY:
==24177==    definitely lost: 1,024 bytes in 2 blocks
==24177==    indirectly lost: 1,874 bytes in 67 blocks
==24177==      possibly lost: 0 bytes in 0 blocks
==24177==    still reachable: 3,842,814 bytes in 11,869 blocks
==24177==         suppressed: 0 bytes in 0 blocks
==24177== Rerun with --leak-check=full to see details of leaked memory
==24177== 
==24177== For lists of detected and suppressed errors, rerun with: -s
==24177== ERROR SUMMARY: 1 errors from 1 contexts (suppressed: 5 from 1)
Segmentation fault (core dumped)

The following diff fixes it

mag 21:32:58 | ~/hak/dev/pmenu $ git --no-pager diff
diff --git a/pmenu.c b/pmenu.c
index 66b217e..c8a2122 100644
--- a/pmenu.c
+++ b/pmenu.c
@@ -1485,7 +1485,11 @@ run(struct Menu *rootmenu)
 			switch (ev.type) {
 			case Expose:
 				if (ev.xexpose.count == 0) {
-					if (currmenu->selected != NULL && ev.xexpose.window == currmenu->selected->tooltip) {
+					if (
+						currmenu &&
+						currmenu->selected != NULL &&
+						ev.xexpose.window == currmenu->selected->tooltip
+					) {
 						copytooltip(currmenu->selected);
 					} else if (currmenu && ev.xexpose.window == currmenu->win) {
 						copymenu(currmenu);

It's somewhat frustrating to fight the menu when it constantly grabs your cursor and throws it to the center. I mean specifically when your cursor exits the circle, and then you want to go back, but as soon as the cursor touches the circle edge pmenu grabs it and throws it to the center, completely stuns me about where my cursor was and where I will end up in another second.
I think the perfect solution is to jump to the center only once after each circle spawn, but then leave the cursor alone, so that user can exit the second sub menu, return to the first circle and point at whatever he wants without intervention.
But if this kind of thing is difficult to implement, second best option is to make jumping behavior toggable in config.h

https://www.freshports.org/x11/pmenu/

Cheers!

I'm not sure what happened but after a plasma update text just stopped rendering. No idea why

There are apparently a few unused variables and an implicitly defined nanosleep().
Its an easy fix of including <time.h>, removing unsigned x, y from initpie(), and removing struct Slice *prevslice from main()

I don't know if these are intended for future use, but after some cursory pmenu usage it doesn't seem to break anything. I can make a PR with the changes, but its 5 line deletions and one include addition.

*accidentally posted to https://github.com/phillbush/xmenu/issues/13

Hi,
First of all thanks for the nice program! Is it possible that you are missing the time.h header in pmenu.c? I get the following warning when compiling:

cc -Wall -Wextra -I/usr/local/include -I/usr/X11R6/include -I/usr/include/freetype2  -c pmenu.c
pmenu.c: In function ‘grabpointer’:
pmenu.c:1017:17: warning: implicit declaration of function ‘nanosleep’ [-Wimplicit-function-declaration]
 1017 |                 nanosleep(&ts, NULL);
      |                 ^~~~~~~~~

If there was a way to bind keys for going to a specific command that would be really helpful, ex. whenever I add something to my utilities menu the number of times I need to press tab changes, plus it would just make navigation faster in general

Steps to reproduce: install dwm, open a window, run

pmenu -r 3 <<!
a
b
!

right click on the window, pmenu still opens a menu.

Expected behaviour: This only happens when clicking on the root window, like what happens with xsetroot.

My mouse has extra buttons, one of which is currently without use. I would like to be able to open πmenu anywhere just by clicking the mouse button.

Graphic tablets have absolute cursor positioning, so I just tested, when I open second menu cursor jumps to the center, but immediately jumps back to where it was (because of absolute positioning of the tablet). So If you have a tablet you can't open second menus.
Demo:
https://fastupload.co/1085111
I think using radial menus with a tablet is very intuitive, so it would be nice to have pmenu support tablets. Maybe adding jump toggle to the config?

Hi,
I have an issue where pmenu refuses to run (one-shot), when icons are specified, but not found in the filesystem. xmenu just prints a warning and ignores the icon for that option, while pmenu just exits after returning. It would be nice, if pmenu would act the same.

Let me know what you think of it...

Hey man,

I want to use pmenu in a wayland environment (without XWayland) but obviously that won't work. Looking at the code it seems to rely pretty heavily on X's own functionality rather than using another lib like cairo or something. This probably makes a wayland option difficult to implement within this tree, as with a wayland version you'd probably want to use something like cairo (there is no real xrender alternative). I'd probably fork pmenu and make it work in wayland but figured I should bring it up here in case you'd want that to become part of the original codebase alongside the X version. This would have many advantages but would probably require a transition to using something that isn't XRender for rendering.

What do you think? Don't bother changing this one and just fork it, or have one repository that does both X and wayland?

Hello, the build process fails because a file, defs.h, cannot be found.
I see it is not in the project directory, where can I find it?
Thanks.