phillipdawson7 / prototype-datepicker-widget Goto Github PK

What steps will reproduce the problem?
1. Set for example language option to something else than default 

What is the expected output? What do you see instead?

Setting does not have any kind of effect.

What version of the product are you using? On what operating system?

Latest from trunk

Please provide any additional information below.

in initialize method there is a each loop that tries to move settings into 
private fields. Inside that loop there is a reference to "this" that referes 
into "window" object instead of DatePicker object.

Hi.

Take polish translation ;)
Months:
'pl' : [ 'Stycze\u0144', 'Luty', 'Marzec', 'Kwiecie\u0144', 'Maj',
'Czerwiec', 'Lipiec', 'Sierpie\u0144', 'Wrzesie\u0144',       
'Pa\u017adziernik', 'Listopad', 'Grudzie\u0144']

Days:
'pl'    : ['Pon', 'Wt', '\u015ar', 'Czw', 'Pt', 'Sob', 'Nie']

Date format:
'pl': [ ["yyyy", "mm", "dd"], "-"]


====================================
And i found some bugs:
in CSS:

find:
div.datepicker table tfoot {

replace with: 
div.datepicker table tfoot tr td {
====================================
in JS:
find: 
<tfoot><td colspan="7" id="'+this._id_datepicker_ftr+'"></td></tfoot>

replace with:
<tfoot><tr><td colspan="7" id="'+this._id_datepicker_ftr+'"></td></tr></tfoot>

What steps will reproduce the problem?
1. create a div with style="display:hidden" positionned in the middle of
the screen and add it a DatePicker plugin
2. make the div appear (display:block)
3. the datepicker frame will appear on top left corner instead of under the
input itself

What is the expected output? What do you see instead?
i expect the datepicker to appear tight under the input

What version of the product are you using? On what operating system?
last .js found on this webiste (in Source). I'm working on FF 3.5.x

Please provide any additional information below.
I fixed it. Change cumulativeOffset to viewportOffset on line 584 and 623
and also remove !this._isPositionned on line 621 since you can't change it
during initialisation (missing code during constructor)

works fine now for me.

attaching fix for revision 19

When an externalControl is set, then I like to disable the onClick handler
of the relative control.

The patch changes

/* finally declare the event listener on input field */
Event.observe(this._relative,
          'click', this.click.bindAsEventListener(this), false);

to

/* finally declare the event listener on input field */
if ( Object.isUndefined(h_p["externalControl"]) || (
!Object.isUndefined(h_p["externalControl"]) &&
Object.isUndefined(h_p["noActivateOnClick"]) ) )
        Event.observe(this._relative,
          'click', this.click.bindAsEventListener(this), false);

The onClick event listener is only set, when no externalControl is set or
an external control is set and noActivateOnClick is not set.

add russian translation

What steps will reproduce the problem?
1. Attempt to use calendar in Internet Explorer 8
2. Proper use of strict doc type causes calendar to not display correctly. 

1. Make a date picker widget appear.
2. Click outside the date picker widget.

I expect the date picker widget to disappear. Instead it stays open until
one clicks on the close button.

The attached patch fixes this problem.

What steps will reproduce the problem?
1. Setup a test with "enableCloseOnBlur" set to true.
2. Click back or forward on the months navigation.
3. Wait a second and it will close the calander (because the input field
has lost focus)

I'm tested this in FireFox 3.0.8 & IE 7 on Windows XP Pro, using verision
1.0.0 of DatePicker.

What steps will reproduce the problem?
1. using the test.html, select a date in the datepicker (it auto-closes)
2. click in the input field to display the datepicker
3. the current date value in the input field is not selected in the datepicker

What is the expected output? What do you see instead?
The selected day to be highlighted? No highlighting

What version of the product are you using? On what operating system?
Current as of today - not an OS issue

Please provide any additional information below.
Would be a nice additional parameter: 
highlightSelectedDate:true

Hi, 

I noticed that when the current day (today) is on the first week of the painted 
month, it does not get the 'today' class. 

Problem is, when filling the first week inside _buildCalendar, no class is 
specified ever:

        /* The first week */
        for (var j = startIndex; j < 7; j++) {
            a_d[0][j] = {
                d: daysIndex
    , m: currentMonth
    , y: currentYear
    , b: badDates[daysIndex]
            };
            daysIndex++;
        }

I have fixed this, and added another small improvement to highlight both the 
"today" (current day), and the "selected" date (that is, the currently selected 
value. 

The fix and improvement is simple, I am attaching a patch. 

Also, you will need to change the .css as desired to reflect the new 
highlights. I have changed the:

div.datepicker table tbody tr td.today {
   ...
}

style to:

div.datepicker table tbody tr td.today {
 font-weight: bold;
}

div.datepicker table tbody tr td.selected {
 background: #c4d5e3;
}

What steps will reproduce the problem?
1. Open widget.

What is the expected output? What do you see instead?
The close label is named "udaryti", when it should be "uždaryti"

What version of the product are you using? On what operating system?
Doesn't matter.

Please provide any additional information below.

What steps will reproduce the problem?

Open widget.

What is the expected output? What do you see instead?

Finnish date separator is '.' but project uses '/' 

What version of the product are you using? On what operating system?

All

Please provide any additional information below.

-

What steps will reproduce the problem?
1. Add XHTML Strict 1.1 DocType to example datepicker.html
2. View in IE 8
3. Calendar does not render as it does in other browsers.

It would be useful if element could be passed as a relative parameter. For 
example it would allow datepicker to be initialized before relative element 
have been added to dom.

Support for this could be archived by following code changes:


Change line 533 from:
this._id_datepicker     = 'datepicker-'+this._relative;

To:
this._id_datepicker     = 'datepicker-' + $(this._relative).id;


line 833 from:
this._relative,

to:
this._id_datepicker,


and line 859 from:
        ).replace(_self._relative+'-','').replace(/-/g, _self._df.separator);


to:
        ).replace(_self._id_datepicker+'-','').replace(/-/g, _self._df.separator);

Just a patch :)

I really hope it will be useful.

What steps will reproduce the problem?
1. Use firefox 3.5
2. or use firefox 3.6
3.

What is the expected output? What do you see instead?
- datepicker-widget fully doezn't works.

What version of the product are you using? On what operating system?
I am using Firefox 3.6.8 on WindowsXP

Please provide any additional information below.

datepicker-widget fully donezn't works but only on a Firefox starting with 3.5. 
Especially for this situation I started to test all versions of FF: 1.x, 2.0, 
3.0, 3.5 and 3.6, also I checked Google Chome. Problem was only in FF 3.5 & 
3.6. I started to investigate situation and found, that in a FF 3.5 developers 
changed somethng related to this situation. See 
https://developer.mozilla.org/En/Firefox_3.5_for_developers and 
https://developer.mozilla.org/En/New_in_JavaScript_1.8.1 and 
https://developer.mozilla.org/En/Core_JavaScript_1.5_Reference/Global_Objects/Ob
ject/GetPrototypeOf and http://ejohn.org/blog/objectgetprototypeof/#postcomment
I am not a programmer and I cannot understand all exactly, maybe I am wrong. 
But dependence between my problem and firefox versions 3.5 & 3.6 was exactly!

In IE7 on Windows XP Pro, when I mouse over dates in the calendar, there
are no changes to the CSS of the date cell I'm over.  Either the event
handler isn't getting fired, or the CSS properties aren't updating for some
reason.

Since I added the datepicker widget to my page I get the error 'element is 
null' on line 3847 of the prototype library.
That is this line: if (element._prototypeEventID) return 
element._prototypeEventID[0];

Any idea why this happens? This is my code:
var dpck_startdatum = new DatePicker({relative:"startdatum",language:"nl"});
var dpck_einddatum = new DatePicker({relative:"einddatum",language:"nl"});

Hi, I've found configuration bug in current trunk, 
disableFutureDate is always set.

Another mybe-bug is that when I re-open the datepicker, it's not positioned
correctly because the second call use positionedOffset instead of
cumulativeOffset.

Here is my patch.


Regards.


524,525c524
<       this._dateFilter.append(DatePickerUtils.noDatesBefore(0));
<       /* ABP: bug */

---
>       this._dateFilter.append(DatePickerFilter.noDatesBefore(0));
527,528c526,527
<       h_p["disableFutureDate"])
<       this._dateFilter.append(DatePickerUtils.noDatesAfter(0));

---
>       !h_p["disableFutureDate"])
>       this._dateFilter.append(DatePickerFilter.noDatesAfter(0));
621,622c620
<       /* ABP: cumulativeOffset instead of positionedOffset */
<       var a_lt = Element.cumulativeOffset($(this._relative));

---
>       var a_lt = Element.positionedOffset($(this._relative));