philsweb / jquery-codemirror Goto Github PK

• Change attribute name 'codemirror-config' → 'codemirror'

• Create a new one 'jquery-codemirror'

• 'codemirror-config' should be still accepted, 'codemirror' preferred

• 'jquery-codemirror-config' accepted, 'jquery-codemirror' preferred

• Add a new parameter to 'codemirrorInit(codemirrorConfig, pluginConfig)'

• Add a pluginConfig key 'height: auto/inherit'

• Set this value for an element with a '.CodeMirror' CSS class through another CSS class 'codemirror-height-inherit' inside plugin (!important) or jQuery().css()

• Make this config key (height) work in 'codemirrorInit()' and 'jquery-codemirror' attribute

• Set default as 'auto'

• Update README

Release 1.2.0

Hello,

thanks for jQuery'ing this! Highly appreciated!

I am, by no means, well known in HTML5 or jQuery, but as I see it, the use of the private element attributes for configuration are incompatible with Polyglot XHTML5 and even result in invalid HTML5 (plain, that is). See Stackoverflow: Custom attributes - Yea or nay? for more on this. In order to result in valid HTML5, all that would be needed is the use of 'data-' as the start of the private attributes. For Polyglot the empty attributes (first, second, third in 'index.html') would need to become first="first" I think, but I did not investigate much into it.

Is there any special reason, you do it this way? Could this be changed? (I am aware, that configuration can be done differently)