phoe / cafe-latte Goto Github PK

Currently each test makes a new set of instances at each execution; this kills efficiency because ideally you would only instantiate e.g. a Tagbody or a HandlerCase once and then call out to it.

We need tests that verify that each control flow structure can be entered multiple times by the same thread. In the future, also check its reentrancy.

There is no need to check the stack for blocks and tagbodies - we should be able to use a true-initialized boolean variable instead and set it to false when the block/tagbody goes out of scope.

As I understand your flow control exceptions, the stack trace is not needed for debugging or similar purposes:

• cafe-latte/src/main/java/systems/raptor/cafe_latte/control_flow/ControlFlowException.java

  Line 3 in 7b2cd83

  public class ControlFlowException extends RuntimeException {

See: https://www.baeldung.com/java-exceptions-performance

so you can override fillInStackTrace in Throwable (or make it configurable with a global flag?)

 @Override
  public synchronized Throwable fillInStackTrace() { 
      return this;
  }

This should return a pair of a nullable return value and a nullable error to better map to the CL API.

http://www.lispworks.com/documentation/HyperSpec/Body/05_b.htm

This is likely incorrect in the current naïve implementation of control flow operators. Write tests, fix revealed bugs.

No need to allocate them anew each time since that negatively affects performance; just mutate them and let them go on their way.

https://github.com/phoe-trash/cafe-latte/blob/5dae56c3bafcc55686ad62214c57bc5d4d4a109b/src/test/java/systems/raptor/cafe_latte/restarts/RestartCaseTest.java#L45-L50