Missing changelog / suggest creating a specific upgrade guide. about phoenix_view HOT 11 CLOSED

I will add an example to the docs of those functions. :)

from phoenix_view.

We have pushed the CHANGELOG to git yesterday. The upgrade notes are in the docs for Phoenix.View but it should be a clean upgrade except for the fact Phoenix.Template is now a separate package (which shouldn't really break either).

from phoenix_view.

@josevalim Apologies but where? https://github.com/phoenixframework/phoenix_view/blob/master/CHANGELOG.md Is still missing 2.x, as are the hexdocs.

from phoenix_view.

Gah, I could swear I pressed the merge button yesterday for #14 but I didn't. I have done that now. :)

In any case, I want to further clarify that the library should be backwards compatible. You still use it the same. Phoenix v1.7 won't use this library anymore (and that's up to Phoenix) but existing users should be completely fine.

from phoenix_view.

Ah thank you! I mention the guide because the instructions didn't jump out at me from the docs, and it seemed like this would be a quite comprehensive change to Phoenix's "way of working" I guess prehaps I should wait for Phoenix 1.7 to have upgrade instructions.

from phoenix_view.

Right, I don't think there is anything to change until Phoenix v1.7 is out. Even then, I would wait until the final version is out, because we may change things a bit while in release candidate.

So my suggestion would be to generate a new app when the RC is out and play with things to get a feeling (and give us feedback!). Note the changes are only to the generated apps too, not in the APIs, so there is nothing forcing you to migrate either!

from phoenix_view.

This suggestion was triggered by conversations in the elixir slack where some people have upgraded "because its there", get deprecation notices and are naturally driven to upgrade/change the existing code, so it was aimed at "easing" that for people

from phoenix_view.

@JonRowe Oh I see, thanks for sharing more context. I believe the deprecation notices it emits today are accurate though:

• render_layout => use components with slots
• render_existing => use function_exported?

Those should be doable and the tools to address them already exist. So I assume the question is how to do those to?

from phoenix_view.

Maybe just examples and more linking to #module-migrating-to-phoenix-component ?

from phoenix_view.

I shipped v2.0.1 without the deprecation, so there is no push for urgency, and with better docs.

from phoenix_view.

Thanks once again for your incredible care and attention to detail 👏

from phoenix_view.