Giter VIP home page Giter VIP logo

Comments (10)

josevalim avatar josevalim commented on June 15, 2024 2

Please try again, it should be good now.

@tank-bohr I am not sure how to support your use case. :(

from phoenix_view.

balexand avatar balexand commented on June 15, 2024 1

I'm also experiencing this. These dialyzer errors can be reproduced by generating a brand new Phoenix project with mix phx.new example --no-assets --no-ecto, adding {:dialyxir, "~> 1.0", only: [:dev], runtime: false} to the deps, and running mix dialyzer.

I've tried updating the phoenix_view package to use master and I still get the error.

Thanks.

from phoenix_view.

tank-bohr avatar tank-bohr commented on June 15, 2024 1

The story behind this is described here #7

It complains about this method for every single :view file.

This is something I've completely missed. I naively thought it'd affect only ErrorView. Now it looks very tricky. I have no idea how workaround this issue :(

from phoenix_view.

josevalim avatar josevalim commented on June 15, 2024 1

Shipped/ Thanks!

from phoenix_view.

josevalim avatar josevalim commented on June 15, 2024

Can you please check if it is address on master?

from phoenix_view.

josevalim avatar josevalim commented on June 15, 2024

/cc @tank-bohr

from phoenix_view.

josevalim avatar josevalim commented on June 15, 2024

@tank-bohr @thiagogsr @bryansray @balexand can you please try master again? I am giving no_return | term a try. Thanks!

from phoenix_view.

thiagogsr avatar thiagogsr commented on June 15, 2024

just tested @josevalim but didn't help

for anyone who wants to repeat the test, you can override the dependency with the following line:

{:phoenix_view, github: "phoenixframework/phoenix_view", branch: "master", override: true},

from phoenix_view.

thiagogsr avatar thiagogsr commented on June 15, 2024

It's indeed good now :-)

done (passed successfully)

from phoenix_view.

bobwaycott avatar bobwaycott commented on June 15, 2024

Just want to chime in, fwiw, that I, too, ran into this issue last night with 1.1.1, and can verify I no longer have dialyzer failures when I set phoenix_view as a dep from master.

from phoenix_view.

Related Issues (7)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.