phosphor-icons / flutter Goto Github PK

Hello, thanks for the great set of icons!

I've noticed that different types of icons have been put into separate classes as static members of the abstract class PhosphorIcons since I've upgraded to version 2.0.0 which is really nice.

My latest builds failed for a reason that I believe is related to the way PhosphorIcons are accessed.
Error (Xcode): This application cannot tree shake icons fonts. It has non-constant instances of IconData at the following locations:

Since each class and its members are auto generated and do not change at any time I believe both classes such as PhosphorIconsBold() and all of it's members could and should be const. This way each icon could be accessed in a constant way which improves performance.

While deploying the flutter app on the web, icons do not align properly in Chrome for Android.

However, they align properly when viewed in Firefox for Android and Safar for iOS. Also, icons align as expected on Chrome for Desktop.

Below are the screenshots of the issue.

This type of icons looks very good.

This weight is not yet supported

Is currently written on the website.

Testing on web, duotone icons are not showing up, I get this error:
Could not find a set of Noto fonts to display all missing characters. Please add a font asset for the missing characters.

Seemed to work great on MacOS so issue is restricted to web as far as I can tell.

Hi there,

Thank you for phosphor-icons!

Will it be ready soon as a Flutter package?

I would do something like

PhosphorIcon((state.saved
                                ? PhosphorIcons.fill
                                : PhosphorIcons.light)
                            .floppyDisk)

but PhosphorIcons.fill and PhosphorIcons.light doesn't share the same interface.
Maybe an abstract class PhosphorFontSet that has these abstract properties

I tried to use the plus-square icon in flutter, but it was not available.

In phosphoricons.com, there is an example saying that it can be used as below, but it seems that it is not actually updated.

Icon(
PhosphorIcons. plusSquareThin,
size: 32.0;
)

Is there any update coming for Phosphor 2.0 icons?

The icon with the label sealCheckFill is missing. According to https://phosphoricons.com/ it should have been included in release 1.2.0.

I'm using only the duotone, and it is tree shaking as expected, but the other font files are kept with their original size, increasing the load time drastically without benefit.

I noticed that the transgender icon does not have a correct fill variant

Hello!
Thank you for your great icons,

After upgrade from 1.4 to master, not 2.0.0 due to the const problem; I tested the PhosphorIconsDuotone implementation.
with the code :
Icon(PhosphorIconsDuotone.bookmarkSimple)

look exactly like
Icon(PhosphorIconsRegular.bookmarkSimple)

best regards,

Alexandre

An error occurs when building flutter for Android.

I saw the warning message and added the '--no-tree-shake-icons' option and the build succeeded, but I think this should be a patch.

cmd:
flutter build apk

error:
This application cannot tree shake icons fonts. It has non-constant instances of IconData at the following locations:

• file:///C:/Users/sgbai/AppData/Local/Pub/Cache/hosted/pub.dev/phosphor_flutter-2.0.0/lib/src/phosphor_icons_bold.dart:8:23
• file:///C:/Users/sgbai/AppData/Local/Pub/Cache/hosted/pub.dev/phosphor_flutter-2.0.0/lib/src/phosphor_icons_bold.dart:11:29

...

Target aot_android_asset_bundle failed: Exception: Avoid non-constant invocations of IconData or try to build again with --no-tree-shake-icons.

I am using phosphor icons in one of my projects and the tiktok filled icon has extra padding on the right.

Code ->

CircleAvatar(
                    backgroundColor: Colors.black,
                    child: Icon(PhosphorIcons.tiktokLogoFill, color: Colors.white,),
                  )

When I use same thing with any other icon it gives exact results

CircleAvatar(
                    backgroundColor: Colors.black,
                    child: Icon(PhosphorIcons.tiktokLogo, color: Colors.white,),
                  )

Can you please check this out and let me know how to fix this ? Would be happy to open a PR

Hello !
It would be great if we could set a rotation to the icon.
For example, I would like to use the triangle icon to point downward. Instead of requesting a new icon for each angle desired, it could be easier to just pass a double for degrees or radians to the PhosphorIcon class.

Hey @rektdeckard 👋

Great icon set! Would you mind also exporting lists or maps of icons grouped by type? e.g.: normal, bold, etc.

Thanks!

There's no perf gain or anything here, we should not change things like this

Can you please update the package to 1.3.1 and add a link to the pub page in the readme?

I just upgraded to v 2.0.0 of the package and I get the following error when building the app.
Flutter build cannot tree shake icons .
Is it possible to add tree-shake support out of the box.
Here is part of the log.
file:///...../Pub/Cache/hosted/pub.dev/phosphor_flutter-2.0.0/lib/src/phosphor_icons_light.dart:3746:19 file:///.....Pub/Cache/hosted/pub.dev/phosphor_flutter-2.0.0/lib/src/phosphor_icons_light.dart:3749:23 Target aot_android_asset_bundle failed: Exception: Avoid non-constant invocations of IconData or try to build again with --no-tree-shake-icons.