photonstorm / flodjs Goto Github PK

There is a little problem easy to fix with loading STPlayer by FileLoader.js, player object not exists:
#51 if (this.player.version) return player;

i suppose should be:
#51 if (this.player.version) return this.player;

Hello @photonstorm,

this is an amazing project, much kudos, and I've looked in on it from time to time.
I feel like a cheat for asking this, but it's sad to see this code sit here when I believe it could have gained more attention in this time.

So I'll take the risk of ridicule and ask if the author would consider licensing the code under a more permissive license, like a BSD or MIT/X11 license, after this time?
CC licenses are not considered good code licenses (here and here) and rather US-law tailored.

I don't have any commercial interest in the code, and am not asking to skirt any payment here.
But it'd be great to see more contributions, maybe even some code-sharing with https://github.com/gasman/jsmodplayer (MIT license), their forks and other projects.

All for the good of mankind and bringing superior tracker music to the web :)
Thanks.

Though I see you also used a different tracker codebase in phaser, which doesn't give me much hope.

Hi I have a few xm mods generated from Sk@le tracker back in '06 and they can't be played back.
I suspect it has to do with the following line: https://github.com/photonstorm/FlodJS/blob/master/JS%20Flod%201.0/includes/F2Player.js#L376

You see , It expectets the tracker name to be "Sk@le Tracker" but my xm's read "Skale Tracker" at 0x26 zeropadded until 0x39 in the header.

I can't find a single mod that uses "Sk@le Tracker" as tracker name, did they change the description?

I'll take a look at it myself later when i have time.
Here's the mod that fails: http://www.tonyivanov.se/dump/kanelNinjaBulle.xm

The live demo does not work (http://sandbox.photonstorm.com/FlodJS/ throws error 404).

I think it could be possible (and cool) to have the demo hosted directly on Github (using Rawgit).

Also, excellent work.