php-http / boilerplate Goto Github PK

Currently YAML files are indentated with two spaces. However Symfony does it with four.

I tried and from a readability point of four spaces actually makes sense. Also, it would become consistent with the rest of the project, no need for extra editorconfig rule.

WDYT?

Maybe adding a php_cs fixer file will help for all our libraries, (we can then just run the fixer on each of the project)

I can prepare one with some rules i generally use and we can discuss each of them if you want them or not.

composer/composer#4884

What do you think about adding a template for PRs in repos?

For example, I like this one: https://github.com/Sylius/Sylius/blob/master/PULL_REQUEST_TEMPLATE.md

In the past I ordered phpdoc like this: params first, then return and throws at the end.

However phpdoc_order fixer follows param, throws, return order.

Honestly, I followed the upper way because I thought that's some kind of standard. Isn't it?

/cc @dbu

See woohoolabs/harmony#10 (comment)