php-mock / php-mock-prophecy Goto Github PK

Not really an issue, but I wondered how to integrate tests with Symfony and phpspec/phpspec with the extends of ObjectBehaviour ?

See php-mock/php-mock#20

Having the final declaration on the PHPProphet class means you cannot mock it in tests or extend the functionality. I suggest removing the final declaration and making the $prophet property protected.

Pull Request #2

After requiring this package in composer and running tests I noticed that many of them became broken as calls expectations changed. For example if I have a function
getFirstWhere($arg1, $arg2, $arg3 = []) and I set my expectation to $mock->getFirstWhere('arg', 'arg2') I get the error saying that expectation was not met because there was a call to $mock->getFirstWhere('arg', 'arg2', [])(notice the empty array at the end). Not sure what is the reason of that. Example log:

  39  - it returns list of sample messages
      method call:
        - getAllWhere("client_id", 5, [])
      on Double\ClientServicesRepository\ClientServicesRepository\P82 was not expected, expected calls were:
        - getAllWhere(exact("client_id"), exact(5))

So basically I call in my real code getAllWhere("client_id", 5) but somehow it takes the optional parameters into an account.