php-sonic / php-sonic Goto Github PK

Hello!

Any chance of getting a 2.0.2 tagged so the latest Pull Request can be included?

Thanks!

Hey! I'm the other guy who wrote a php client library for Sonic in parallel.
I guess it wouldn't make much sense maintaining two, so I would like to propose merging the libraries.

Some things coming to mind:

• I had a quick look at your library and saw, that our APIs are very similar
  • You have three flush methods (flusho, flushb, flushc), I have only one
  • Many of your methods don't return the results that Sonic reports. (e.g. pop() or the flush-methods)
• Is there a reason why you are using PHP's socket extension? The stream API is built in and supports reading until a certain delimiter is found, which is probably more performant than your readBuffer() implementation.
• While my SonicMessage helper class might have been a bit overengineerd in the end, I think your ingest implementation is too easy. When starting a session with Sonic, Sonic tells one about the size of its receive buffer. If messages longer than this are sent to the server, Sonic will close the connection. Furthermore: If the input you get for either push(), pop(), query() or suggest() contains a newline, or a " your implementation should break. That may even be a security risk.
• You are often using preg_match() to parse responses. We probably need a benchmark for this, but I would guess that that is way more expensive than strsplit().

What do you think?