Add smilies to the board announcements editor.

Should we have an ACP option that can be used to disable the ability for users to close/dismiss an announcement?

I believe there may be reason where some announcements, an admin may not want the user to be able to dismiss it.

The beta 2 tag release neglected to update the version in composer.json

https://www.phpbb.com/customise/db/extension/boardannouncements/support/topic/133456

We still run a query on board announcement data even if the user set it to disabled.

We should not do that.

Hi
Some translation omissions in version 1.3.0 of the extension.
Here are the fixes:
'BOARD_ANNOUNCEMENTS_LOCATIONS' => 'Limiter l‘endroit où cette annonce doit être affichée',
'BOARD_ANNOUNCEMENTS_LOCATIONS_EXPLAIN' => 'Sélectionnez un ou plusieurs emplacements pour afficher l‘annonce. Pour l‘afficher partout, laissez la sélection vide. Utilisez Commande (Mac) ou Contrôle (Windows), cliquez pour sélectionner plusieurs emplacements.',
'BOARD_ANNOUNCEMENTS_INDEX_PAGE' => 'Index du forum',

Best Regards

When a new user is created, their board_announcement_status is 0 by default. So BA thinks they dismissed the announcement, so they don't see it anymore after they registered.

We need to set the users board_announcements_status to 1 when a user is created if board announcements config is enabled.

@rxu I think you've done something like this before, with an event during user creation.

https://www.phpbb.com/customise/db/extension/boardannouncements/support/topic/146966

There have ben some requests for guests only view announcement option
https://www.phpbb.com/customise/db/extension/boardannouncements/support/topic/131026

They just made ext.php truly optional: phpbb/phpbb#2642 (comment)

Should we keep it or remove it?

There's an option request to show the board announcement on index page only.

The combination of line-height, font-size and overflow-x will cause a scrollbar to appear when there is only a single line in IE11.

https://github.com/phpbb-extensions/boardannouncements/blob/master/styles/all/theme/boardannouncements.css#L18

edit: also, the positioning CSS rules for the close button should probably be on the <a>, not the <span>, because this introduces white-space above the message.

edit 2: also happens in IE9 & IE10 (not IE8 for some reason)

Fix issues reported from 1.0.0

Trying to install your mode

Install

1. Download the latest validated release.

gave me an error:

General Error
SQL ERROR [ mysqli ]

Unknown database 'phpbb' [1049]

An sql error occurred while fetching this page. Please contact an administrator if this problem persists.

Is there any mirrors for downloading?

When I activated the boardannouncement extension, this was the error message I received:

==

phpBB is een foutmelding tegengekomen tijdens het bouwen van de container, veroorzaakt door een geïnstalleerde extensie. Om deze reden zijn alle extensies tijdelijk uitgeschakeld. Probeer de cache van je forum te legen. Alle extensies worden automatische ingeschakeld als de foutmelding is opgelost. Als deze foutmelding zich blijft voordoen, bezoek dan ons support forum via phpbb.nl.

Uitzondering: The file "/home/noppenforum/board.noppenforum.nl/ext/phpbb/boardannouncements/config/services.yml" does not contain valid YAML: The reserved indicator "@" cannot start a plain scalar; you need to quote the scalar at line 5 (near "- @config").
#0 /home/noppenforum/board.noppenforum.nl/vendor/symfony/dependency-injection/Loader/YamlFileLoader.php(117): Symfony\Component\DependencyInjection\Loader\YamlFileLoader->loadFile('/home/noppenfor...')
#1 /home/noppenforum/board.noppenforum.nl/phpbb/extension/di/extension_base.php(99): Symfony\Component\DependencyInjection\Loader\YamlFileLoader->load('services.yml')
#2 /home/noppenforum/board.noppenforum.nl/phpbb/extension/di/extension_base.php(63): phpbb\extension\di\extension_base->load_services(Object(Symfony\Component\DependencyInjection\Compiler\MergeExtensionConfigurationContainerBuilder))
#3 /home/noppenforum/board.noppenforum.nl/vendor/symfony/dependency-injection/Compiler/MergeExtensionConfigurationPass.php(71): phpbb\extension\di\extension_base->load(Array, Object(Symfony\Component\DependencyInjection\Compiler\MergeExtensionConfigurationContainerBuilder))
#4 /home/noppenforum/board.noppenforum.nl/vendor/symfony/http-kernel/DependencyInjection/MergeExtensionConfigurationPass.php(39): Symfony\Component\DependencyInjection\Compiler\MergeExtensionConfigurationPass->process(Object(Symfony\Component\DependencyInjection\ContainerBuilder))
#5 /home/noppenforum/board.noppenforum.nl/vendor/symfony/dependency-injection/Compiler/Compiler.php(140): Symfony\Component\HttpKernel\DependencyInjection\MergeExtensionConfigurationPass->process(Object(Symfony\Component\DependencyInjection\ContainerBuilder))
#6 /home/noppenforum/board.noppenforum.nl/vendor/symfony/dependency-injection/ContainerBuilder.php(789): Symfony\Component\DependencyInjection\Compiler\Compiler->compile(Object(Symfony\Component\DependencyInjection\ContainerBuilder))
#7 /home/noppenforum/board.noppenforum.nl/phpbb/di/container_builder.php(212): Symfony\Component\DependencyInjection\ContainerBuilder->compile()
#8 /home/noppenforum/board.noppenforum.nl/common.php(115): phpbb\di\container_builder->get_container()
#9 /home/noppenforum/board.noppenforum.nl/adm/index.php(23): require('/home/noppenfor...')
#10 {main}

Next logical step is to move this to RC which ideally we'd do in ~1 week. Hopefully we can get it to stable and release that at the same time as 3.1.

When the entire board is disabled in the ACP, the announcement still shows. Not sure if this is safe behavior (since disabling the board is usually used for updating phpBB etc.)