phundrak / eshell-info-banner.el Goto Github PK

I am getting this issue when I am launching eshell s-pad-right: Wrong type argument: stringp, nil

Not sure what info you need from me to properly debug this :)
Also, mac has 16 GB available

While #2 standardized the retrieval of the name of the running Linux distribution, eshell-info-banner.el has yet to support non-standard Linux distributions (such as GUIX) and non-Linux OSes, such as macOS and Windows.
Here will be listed Linux distributions and OSes not yet supported:

• macOS
  Link to keep up with macOS versions
  • OS name and version 0f39c31
  • Kernel version 0f39c31
  • Partitions detection 3934c4e
  • Memory display 46ada1b
• Windows
  • OS name and version #6
  • Partitions detection
    • if duf is installed on the system, d35516a
    • native solution
  • Memory display
• BSDs
  • OS name and version 0a8a340
  • Kernel version 0f39c31
  • Partitions detection
    • FreeBSD 763d459
    • NetBSD a2f24e4
    • DragonFly BSD 36b964a
    • OpenBSD untested
    • PC-BSD untested
  • Memory display
    • FreeBSD 0a8a340
    • NetBSD 382bb55
    • DragonFly BSD 36b964a
    • OpenBSD untested
    • PC-BSD untested
  • Fix uptime for NetBSD 89f78f0
• Hurd
  • OS name and version 0f39c31
  • Kernel version 0f39c31
  • Partitions detection 763d459
  • Memory display 763d459
• Linux distributions
  • GUIX 0f39c31
  • Bedrock Linux c8073fa
  • Proxmox c8073fa
  • Android 0c9e6de
  • ChromeOS
  • and others

This list is subject to changes in the future, by shrinking or expanding.

Hello,
it seems that something under the hood is going wrong.
I use emacs 28 on fedora.
installation from melpa runs without error.
but there is no command and no variables.
so i think, that something is wrong silently...
i tried it inside eshell buffer and outside.
Nothing :-(
any idea to start?

Regards
Poul

My macOS VM runs undern macOS Catalina, version 10.15. However, the
eshell-info-banner--get-macos-name macro matches version 10.1 first,
resulting in Mac OS X Puma being detected instead.

ATM ZFS partitions are filtered out because of the missing "/dev" prefix:

....
zroot/ROOT/default           1,2T    747G  458G   63% /
zroot/data/home              900G    443G  458G   50% /home
...

See image:

Source of problem:

(when (file-readable-p "/sys/") (battery))

(file-readable-p "/sys/") returns nil but (battery) returns info.
I removed the when statement and it works. \o/

Not sure what the reasoning behind that condition is though.

In some non-standard Linux distributions such as GUIX, /etc/os-release is not present, causing eshell-info-banner to fail. Distribution name should be retrieved in a more standard way, ideally through commands such as lsb_release or hostnamectl and not from local files. If both fail, a default value should be provided.

Updated package today and got this. Probably due to the eval-when-compile.
If I install package, error doens't exist.
If I re-start emacs, then I encounter the error.

I haven’t had the opportunity to test it on other devices, but my Chromebook shows erroneous filesystem sizes. Relevant part of eshell-info-banner’s output:

/.......: [=============================================]   6.6M / 11.8M  ( 55%)
/boot...: [=============================================]  55.9k / 1022k  (  5%)

Output of df:

$ df
Filesystem     1K-blocks    Used Available Use% Mounted on
dev               961288       0    961288   0% /dev
run               969272    1000    968272   1% /run
/dev/mmcblk1p3  12358636 6916504   5258008  57% /
tmpfs             969272       0    969272   0% /dev/shm
tmpfs             969272       8    969264   1% /tmp
/dev/mmcblk1p1   1046512   57220    989292   6% /boot
tmpfs             193852      28    193824   1% /run/user/1000

This needs to be investigated and fixed.

I am running:

• an up-to-date Arch Linux
• the latest commit eshell-info-banner.el
• Emacs 28.1 with nativecomp enabled (extra/emacs-nativecomp package)