Division by zero in /var/www/html/admin/data.php on line 17 about web HOT 8 CLOSED

Ah-hah! This explains a few things...

api.php used to just pull the output of chronometer.sh -j (in which the divide by zero error was fixed)

Since the introduction of all the lovely graphs, the calculations were moved into data.php, but it looks like the fix wasn't ported across.. good catch! Thanks

from web.

I was actually troubleshooting the panel itself. The charts were spinning and I didn't see any issues in any of the XHR requests. Looking through the php logs I found the error, I fixed it locally on my server...

However the root of the problem was that dnsmasq failed to start when I rebooted my server. Im using Ubuntu and not a pi.

Maybe as a future enhancement have the system make sure all necessary services are running? It would be cool to see an alert warning you that dnsmasq is not running.

I just installed this a few days ago and have yet to play with it. So far I'm pretty impressed! Great work!

from web.

Ah, yeah the Ubuntu thing is a known issue link 1 link 2

There is a workaround in the above two links, but it's something we're looking into!

from web.

Can you make a pull request with your fix, or just post it here and we'll look at it?

from web.

This should do it, right?

        if ($dns_queries_today != 0) {
                    $ads_percentage_today = $ads_blocked_today / $dns_queries_today * 100;  
                }
                else {
                    $ads_percentage_today = 0;
                };

from web.

There are about 3 ways you could do it, I ended up doing...

$ads_percentage_today = $dns_queries_today ? ($ads_blocked_today / $dns_queries_today * 100) : 0;

However your way much easier to read for the casual programmer.

from web.

Or a fancy one liner :) (did not know PHP did that, I'm a C# programmer at heart)

from web.

It's a common one line if statement. Java has it too. :)

from web.