pi-hole / web Goto Github PK

Thanks for the revised Top Clients widget! One simple touch-up request: can you put a space between the hostname and the IP address? There is one on the localhost line, but on the other lines the space is missing.

Expected Behaviour:

Sanitation of host names displayed by Pi-Hole

Actual Behaviour:

Domains queried against a server running Pi-Hole will be displayed in the web admin console without sanitation.

Steps to reproduce this issue:

Run the following command in a shell:
dig '<img/src="x"/onerror=alert(document.cookie)>' @PiHoleServer

If required, run the command repeatedly until the result appears in the Top-10 list.

Note the alert box that appears.

@TylonHH commented on Mon Sep 12 2016

Hi,
I guess it would be intersting a Chart for the showing CPU Temperature. It has just to be added to the existing "Queries over time" chart.

Like this:

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

Expected Behaviour:

Detect if $dns_queries_today is 0 to prevent an error

Actual Behaviour:

Division by zero in /var/www/html/admin/data.php on line 17 error and execution stops

Steps to reproduce this issue:

Either check if the divisor is 0 or add a very small number ( a / (b + .0000000001)) to prevent this error

Expected Behaviour:

Would expect to see the proper type/domain/client

Actual Behaviour:

I see type: q[32178] domain query[A] and client is from

The frontpage does work. Seems something shifted on the query log page.

Steps to reproduce this issue:

Running Pi-hole Version v2.5.3 Web Interface Version v1.1.3. Tried updateDashboard.sh but that did not fix it, 1.1.3 is really the latest.

The future maintenance functions of the /admin/ website can be reached from the outside !

[PANIC SWITCH] ---------- [ON]

The IT-gurus, employed by the multi-million-dollar advertising industry (that we sabotage), can - in the future - 'whitelist' their domains with something like the following :
<img src="http://adserver.com/admin/php/add.php?list=white&domain=adserver.com">

Pi-Hole is Open-Source,
and the GitHib development branch is visible by everyone,
including by these IT-gurus of the advertising industry.

---------- Request => Please 'harden' the Pi-Hole admin webserver.

2 Possible solutions => One for Short-Term, and One for Long-Term.

Solution 1° - Short-Term
{ Add username / password Authetication. }

From the github / pi-hole / wiki =
https://github.com/pi-hole/pi-hole/wiki/Nginx-configuration-instead-of-the-default-lighttpd-and-php-cgi-option

From the jacob salmela blog =
http://jacobsalmela.com/password-protect-a-lighttpd-web-server-on-a-raspberry-pi-using-mod-auth/

Solution 2° - Long-Term
{ Run each of the Pi-Hole-appliance's services on individual Static IP-addresses. }

A) Give the RaspberryPi's 'main' interface a Static IP-address for SSH and other softwares.
Bonus: this main Static IP-address remains free for other appliances (cloud, web, streaming,...)
Note : we have seen this requirement on several fora by people who want to run other stuff too.

B) Give the Pi-Hole-appliance's DNS server another Static IP-address for the DNS resolution.
Bonus: this is the only Static IP address that the user's router must know.

C) Give the Pi-Hole-appliance's 'adblock' Webserver - and future miniDLNAserver - yet another Static IP-address, and adapt the gravity script accordingly. (No more dynamic-searching for the IP).
Bonus: the user of the Pi-Hole-appliance can run other webservers on the main interface Static IP-address - see A).
Optional Bonus: a full-fledged webserver, crippled with Rewrite-Rules, is no longer required.
A simple webserver in Perl, or in Python2, or in Python3, or even in command-line PHP, can simply reply with the HTTP header '204 No Content'.
° This new Static IP-address must not be known by anybody but: the gravity script that feeds the DNS server's configuration file.

D) Give the Pi-Hole-appliance's 'admin' webserver yet another Static IP-address.
Bonus: Cutting-off the outside world. Problem solved.
Bonus: No need for /admin/ in the URL. It can be the document-root for this webserver.
Bonus: No need for yet another username / password to remember. (But may be optional.)
° This new Static IP-address must be known only by the 'administrator' of the Pi-Hole-appliance.

Optional =>
E) Disable (not un-install) the dhcp-client-daemon(s), the assumption being that we run a 'server'.
F) Use the '/etc/network/interfaces' again to declare the multiple Static IP-addresses, this time by using the 'ip' utility from the 'route2' package.
Raspbian Jessie already includes the statement 'source-directory /etc/network/interfaces.d'

Conclusion: Yes, We Can.

[PANIC SWITCH] ---------- [OFF]

Note: why I used the term 'Pi-Hole-appliance' =>
Quote from the githib / AdminLTE / New admin features (idea) #24

jacobsalmela commented 3 days ago
If we ever want to commercialize anything, ....

Greetings, F.C.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

So it's easier to understand the Queries over time graph, I would like to see the lines and boxes match the colors from the boxes on top of the page. So the lines should be blue and green (ads blocked and queries)

The web-interface is available to anyone on the (local) network.

This also means that anyone can whitelist/blacklist any domain. This is undesirable in quite a few environments.

Feature request: allow (parts of) the web-interface to require authentication (initially with local usernames/passwords) and allow for role based access (i.e. groups of users have certain rights).

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

Just wondered, when you are on the main page of the admin interface you get the Top Clients list. Imho it would be a nice enhancement if you can click on the ip address and get to the query log page filtered for that ip. That would make figuring out which client it could be (when an IP changes f.e.).

Right now easy bypass is to copy the ip, click the query log page, wait untill it loads and paste the ip into the filter field.

Not sure if it can be done since that whole block seems AJAXy and filtering is done when it has finished loading.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

Expected Behaviour: Operating systems should normally follow the FHS in their layout. Some do not.

Actual Behaviour: Non-standard OS'es may be missing critical directories or files, we may want to look at verifying locations exist before installing into them.

Steps to reproduce this issue: See https://www.reddit.com/r/pihole/comments/50kqmx/fyi_you_need_opt_before_running_the_installer/

Continuation of #465 on the main pi-hole repo.

Expected Behaviour:

Well, I see 1 of 2 things being wrong. Either the returned stats from the API are incorrect, or the title of the summary stats should be changed from "Ads Blocked Today" to "Ads Blocked To Date"

Actual Behaviour:

Currently the PHP code parses the entire pihole.log file, and returns stats on all queries in there. Now, my log file isn't set reset/rotated nightly, meaning that the queries in there are from when I started up the server. (this in itself is a bad idea as you will soon get file sizes that are just unmanageable)

Also, I noticed the "Queries over time" graph seemed a bit weird for not resetting every day, but I also kinda like seeing the trend of my internet traffic based on time of day.

Suggestion:

One idea would be to rotate the logs nightly (which would be a change to the main repo), and then we wouldn't have to worry about parsing large files and could separate out all-time stats from daily stats.

@vinceskahan commented on Fri Aug 05 2016

With 2.8.0 installed, I'm nagged mercilessly to update by an overlay on your home screen which pops annoyingly over far too much of the screen.

Please change where your update available info appears, a small 'update available' thing to the left of the pihole logo would be plenty sufficient for notifying us, the massive rectangular popup is a bit much.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

Expected Behaviour:

Domain names should fit/be truncated to fit the section

Actual Behaviour:

The client section would probably also have this issue.

Steps to reproduce this issue:

Query a domain with a long name or give a client a long name.

Moving this issue from the main Pi-Hole repo to this one.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@tomose commented on Fri Oct 14 2016

1. "Ads Blocked Today" -> "Queries Blocked Today"
   Not everything blocked is an ad. Trackers, other malicious domains, etc.
2. "Of Today's Traffic Is Ads" -> "Of Today's Queries Denied"
   Just better wording.
3. QoL request - Be able to set default number of entries in log via web interface (am aware that it can be done manually through editing a file).
4. QoL request - Filter log to show only blocked, unblocked, or all domains.
5. QoL request - Nav page links on top of query log as well (so you don't have to scroll down to move to the next page)

That's it really. Appreciate how great this works. Looking forward to being able to wildcard domains for easier blocking in the future. :)

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@ipv89 commented on Wed Sep 21 2016

When viewing the apache error log it contains the following errors.

Undefined offset: -2 in /var/www/html/admin/data.php on line 268
Undefined offset: -3 in /var/www/html/admin/data.php on line 269

Not sure if it is related but my graphs on the admin page are no longer loading but the stats are available through /api.php

Not really an issue more a question/remark :)

Due to this line in /var/www/html/admin/php/add.php ...

if($_SERVER['HTTP_ORIGIN'] == "http://pi.hole" || $_SERVER['HTTP_ORIGIN'] == "http://${_SERVER['SERVER_ADDR']}")

... adding entries to the WL/BL via the admin page won't work if neither pi.hole nor the IP address is used when accessing the admin page. (e.g. when using a custom internal hostname/FQDN like pihole.domain.local).
As mentioned before it's not really a problem but a little confusing as you get a "Success!"-message even though the entry is not added to the WL/BL.

Cheers
/Jens

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

Since the "amount of domains blocked" is read from /etc/pihole/gravity.list, the user may see twice as many domains as there really are since there are two lines for each domain (IPv4 and IPv6).

192.168.1.100 zz.zeroredirect1.com
2601:442:abcd:125:d833:f13e:6de6:4fa0 zz.zeroredirect1.com

It would probably be safer to just count the lines in /etc/pihole/pihole.3.eventHorizon.txt

@sam24and48 commented on Mon Oct 10 2016

This template was created based on the work of udemy-dl.

In raising this issue, I confirm the following (please check boxes, eg [X]):

• I have read and understood the contributors guide.
• The issue I am reporting can be replicated
• The issue I'm reporting isn't a duplicate (see FAQs, closed issues, and open issues).

How familiar are you with the codebase?:

• 1 (very unfamiliar)
• 2
• 3
• 4
• 5
• 6
• 7
• 8
• 9
• 10 (very familiar)

[FEATURE REQUEST | QUESTION | OTHER]:

{replace this section with your content or delete if not a FEATURE REQUEST/QUESTION/OTHER}

[BUG | ISSUE] Expected Behaviour: I have added multiple addresses including msftncsi.com, www.msftncsi.com, support.microsoft.com, and msn.com. We performed this last week and it fixed the issue of limited connectivity on our machines and also the ability to get to pages on support.microsoft.com and confirmed connectivity to msftncsi.com. (However today after the weekend and the 2.9.2 update it is pi-holing all of those addresses)

[BUG | ISSUE] Actual Behaviour: It appears to be completely ignoring the whitelist entirely. Today as I have done nslookups on the machines for all of those addresses they are pointing directly to the pi-hole ip. I have rebooted the pi-hole device multiple times along with dnsflushes on the machines multiple times. I can see in the web admin interface where it is flat out pi-holing the address when I go to it even though it is specifically added to the whitelist (example: support.microsoft.com).

[BUG | ISSUE] Steps to reproduce:

(Optional) Debug Log generated by pihole -d:

http://termbin.com/s1lw

@dschaper commented on Mon Oct 10 2016

Hi, how are you adding the domains to the whitelist? Via commandline or via the web interface?

@dschaper commented on Mon Oct 10 2016

And I do show that support is blacklisted on one of the lists:

::: /etc/pihole/list.7.raw.githubusercontent.com.domains (2 results)
diagnostics.support.microsoft.com #Microsoft
support.microsoft.com #Microsoft

@sam24and48 commented on Mon Oct 10 2016

I added it via the web interface

@dschaper commented on Mon Oct 10 2016

Okay, I'd like to move this issue over to the Web Interface repository for further review. Better venue to handle the questions.

@TylonHH commented on Fri Oct 07 2016

[BUG | ISSUE] Actual Behaviour:
The admin page just shows the total number of domains being blocked. The other figures are 0. Also the query log is empty.
But Ads are still blocked on my devices.

I run piholeLogFlush.sh with no success.
My /var/log/pihole.log is now 4193 big.
I have an RPi 3
With nearly the same setup it works like a charm. What have I done? I completely installed the new update 2.9.2 on top on an other project.

Here is my pihole -d

@dschaper commented on Fri Oct 07 2016

Quick check:

cd /etc/.pihole
sudo git status

Just to make sure you are on the master branch.

cd /var/www/html/admin
sudo git status

@TylonHH commented on Fri Oct 07 2016

yes I'm. Both response with nothing to change.

@dschaper commented on Fri Oct 07 2016

ls -lahc /var/log/pihole.log

@TylonHH commented on Fri Oct 07 2016

-rw-r----- 1 dnsmasq root 50K Okt 8 00:37 /var/log/pihole.log

@dschaper commented on Fri Oct 07 2016

Okay, this looks like it may be an Admin interface issue. Moving this issue over to that GitHub repository.

Issue #335 from main repo.

@xxcriticxx commented on Mon Aug 29 2016

am getting this error while looking on my query logs. some of the graphs dont appear they just keep spinning.

DataTables warning: table id=all-queries - Ajax error. For more information about this error, please see http://datatables.net/tn/7

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

Expected Behaviour:

In the output of /admin/api.php?summary, for example:

{"domains_being_blocked":"99,069","dns_queries_today":"10,436","ads_blocked_today":"227","ads_percentage_today":"2.2"}

The numerical values should be more easily machine-readable by expressing them as string values without thousands separator characters, or as JSON number values.

Actual Behaviour:

Numerical values are given with thousands separators, which complicates machine readability.

Steps to reproduce this issue:

Go to the URI /admin/api.php?summary when any numerical value exceeds 999.

@TylonHH commented on Sun Sep 18 2016

On the web interface there are nearly 2k queries (flushed 20 minutes ago).
In the quiere log I see on l at the bottom only a total number of 150.
Shouldn't the numbers be equal? Are your numbers at those places equal?

If yes, I would suggest it's because of an different timezones I set, which is not set everywhere?!?!

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

The coinbase code is not necessary. It should be removed in the next release.

@th4t9uy commented on Fri Jan 22 2016

Set up PiHole on a fresh Raspbian Jessie LITE install on a RaspberryPi Model B.

However, not long after set up the admin console has started looking like this http://i.imgur.com/1RhcVuC.png

I have tested it in Firefox and Internet Explorer, I get the same result in either browser. On the RasPi so far all I have tried is restarting the lighttpd service.

@dschaper commented on Fri Jan 22 2016

Okay, thanks for the report, we'll take a look at it...

@dschaper commented on Fri Jan 22 2016

Do you have anything for your blocking page, or did you leave it with the stock blank html? And can you grab a page source? Thanks!

@PromoFaux commented on Fri Jan 22 2016

Do you have any extensions installed? Ad block plus/Privacy Badger etc? If so.. can you try disabling them and refreshing? Thanks

@jacobsalmela commented on Sat Jan 23 2016

I haven't seen this one yet, but try another browser and/or disabling the extensions.

@th4t9uy commented on Sat Jan 23 2016

dschaper: I left it with the stock html, the only thing I changed during the initial of Pi-Hole setup was settting at a static IP address and enabled IPv6 blocking. Page source is as follows: http://pastebin.com/9n0SHn3Q

PromoFaux: I did initially have UBlock Origin and Disconnect Firefox addons enabled. Both have since been disabled but it didn't help unfortunately.

jacobsalmela: I have tried Firefox and Internet Explorer, the latter I doesn't have any extensions/addons running. I have also since tried Chrome from my phone but again that does not display correctly.

@dschaper commented on Sat Jan 23 2016

Thanks for the update. Can you do an ls -lac /var/www/html/admin and
ls -lac var/www/html/admin/css

@th4t9uy commented on Sat Jan 23 2016

Results of commands run:

pi@raspberrypi:~ $ ls -lac /var/www/html/admin
total 48
drwxr-xr-x 5 root     root      4096 Jan 22 22:06 .
drwxrwxr-x 4 www-data www-data  4096 Jan 22 22:06 ..
-rw-r--r-- 1 root     root        62 Jan 22 22:06 api.php
drwxr-xr-x 2 root     root      4096 Jan 22 22:06 css
-rw-r--r-- 1 root     root        90 Jan 22 22:06 .gitignore
drwxr-xr-x 2 root     root      4096 Jan 22 22:06 img
-rw-r--r-- 1 root     root     11707 Jan 22 22:06 index.php
drwxr-xr-x 2 root     root      4096 Jan 22 22:06 js
-rw-r--r-- 1 root     root      1085 Jan 22 22:06 LICENSE
-rw-r--r-- 1 root     root      1195 Jan 22 22:06 README.md
pi@raspberrypi:~ $ ls -lac /var/www/html/admin/css/
total 96
drwxr-xr-x 2 root root  4096 Jan 22 22:06 .
drwxr-xr-x 5 root root  4096 Jan 22 22:06 ..
-rw-r--r-- 1 root root 81982 Jan 22 22:06 AdminLTE.min.css
-rw-r--r-- 1 root root  3094 Jan 22 22:06 skin-blue.min.css
pi@raspberrypi:~ $

@dschaper commented on Sat Jan 23 2016

Those look good. How about a cat /etc/lighttpd/lighttpd.confplease?

@th4t9uy commented on Sat Jan 23 2016

As follows:

pi@raspberrypi:~ $ cat /etc/lighttpd/lighttpd.conf
server.modules = (
        "mod_access",
        "mod_accesslog",
        "mod_expire",
        "mod_compress",
        "mod_redirect",
        "mod_setenv",
        "mod_rewrite"
)

server.document-root        = "/var/www/html"
server.error-handler-404        = "pihole/index.html"
server.upload-dirs          = ( "/var/cache/lighttpd/uploads" )
server.errorlog             = "/var/log/lighttpd/error.log"
server.pid-file             = "/var/run/lighttpd.pid"
server.username             = "www-data"
server.groupname            = "www-data"
server.port                 = 80
accesslog.filename                      = "/var/log/lighttpd/access.log"
accesslog.format                        = "%{%s}t|%V|%r|%s|%b"


index-file.names            = ( "index.php", "index.html", "index.lighttpd.html" )
url.access-deny             = ( "~", ".inc" )
static-file.exclude-extensions = ( ".php", ".pl", ".fcgi" )

compress.cache-dir          = "/var/cache/lighttpd/compress/"
compress.filetype           = ( "application/javascript", "text/css", "text/html", "text/plain" )

# default listening port for IPv6 falls back to the IPv4 port
include_shell "/usr/share/lighttpd/use-ipv6.pl " + server.port
include_shell "/usr/share/lighttpd/create-mime.assign.pl"
include_shell "/usr/share/lighttpd/include-conf-enabled.pl"

# If the URL starts with /admin, it is the Web interface
$HTTP["url"] =~ "^/admin/" {
        # Create a response header for debugging using curl -I
        setenv.add-response-header = ( "X-Pi-hole" => "The Pi-hole Web interface is working!" )
}

# If the URL does not start with /admin, then it is a query for an ad domain
$HTTP["url"] =~ "^(?!/admin)/.*" {
        # Create a response header for debugging using curl -I
        setenv.add-response-header = ( "X-Pi-hole" => "A black hole for Internet advertisements." )
}
pi@raspberrypi:~ $

@dschaper commented on Sat Jan 23 2016

That all looks good. Since you haven't made any changes to the configuration, would you re-run the curl -L install.pi-hole.net | bash command again and try a new install. This should just install over your existing configuration.

@th4t9uy commented on Sat Jan 23 2016

All back to normal! http://i.imgur.com/XTM0QBL.png

Thanks for all your help guys

@dschaper commented on Sat Jan 23 2016

Great! Thanks for using the Pi-Hole!

@ecaron commented on Thu Jun 09 2016

I encountered this tonight too. I found the problem was a bunch of 0 byte files in /var/cache/lighttpd/compress/admin. I just rm -rf'd the directory and restarted lighttpd. Problem has not come back, yet.

I'll keep an eye on it happening and update this thread if I find more. But thought this might be useful for people before proceeding to perform a new install.

@dschaper commented on Thu Jun 09 2016

Thanks for the report. Let us know if it does come back. (How'd you even think to look at the cache!)

@ecaron commented on Thu Jun 09 2016

How'd you even think to look at the cache!

Just following the rabbit hole. I was disabling parts of the /etc/lighttpd/lighttpd.conf file and things started working when I commented out the compression lines. Once I nuked the directory and removed the comments, some files started reappearing in the cache directory but not as many as before. The hunt continues! (I'm also on a Pi B, so maybe it has to do with not enough processing power to run the minifiers?)

@dschaper commented on Thu Jun 09 2016

Well I have it running on a Zero, with a ton of empty overhead to grow into. It does take about 5 seconds or so to start rendering and 20 seconds until complete graph rendering and no more spinners. I wouldn't think the 300MHz boost that the Zero has over the B+ would make that much impact?

@ecaron commented on Thu Jun 09 2016

Excellent point. I apologize to the Pi for thinking it unfit:-) I'll keep
figuring out how to investigate the cause.
On Jun 8, 2016 8:40 PM, "Dan Schaper" [email protected] wrote:

Well I have it running on a Zero, with a ton of empty overhead to grow
into. It does take about 5 seconds or so to start rendering and 20 seconds
until complete graph rendering and no more spinners. I wouldn't think the
300MHz boost that the Zero has over the B+ would make that much impact?

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
pi-hole/pi-hole#226 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAEUMHs-RQaTJZPJf8jUxqyqBRLxI773ks5qJ28fgaJpZM4HKwtL
.

@dschaper commented on Thu Jun 09 2016

👍 I sent my 256MB models to greener pastures... If you do come up with a cache bug, open up a new Issue thread for it and we'll see if it's something that is upstream or a config issue.

@luebbe commented on Thu Aug 11 2016

Hi Folks,
I had the same issue today. A fresh install of pi-hole on a vanilla raspbian, Raspberry B.
Everything worked fine until after an hour or so, the admin page looked almost like in the original posters screenshot.
I checked the config files, went through the re-install, deleted the cache, but nothing helped.
Only when I commented out "mod_compress" in the server.modules section of lighttpd.conf and restarted lighttpd, everything worked as expected immediately.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

Expected Behaviour:

Temperature displayed would be consistent between pages within a small margin of change.

Actual Behaviour:

Temperature displayed fluctuates between pages selected, i.e.
http://ip_address/admin/index.php = 50.38 degrees
http://ip_address/admin/queries.php = 47.61 degrees
http://ip_address/admin/list.php?l=white = 46.0 degrees
http://ip_address/admin/list.php?l=black = 45.54 degrees

If you go from a high temperature page and select another page the temperature can be 5 degrees lower that doesn't seem like it would be possible, the opposite is also true.

Steps to reproduce this issue:

Select the different pages and observe the temperature indicator.

First i would like to thank you for this great piece of software. One issue i found with the web interface. There is no "More info" info. The link points to # which is undefined in the page.

<a href="#" class="small-box-footer">More info <i class="fa fa-arrow-circle-right"></i></a>

Expected behaviour?

I've been watching my Pi-Hole's admin page for the past few days and it looks like the "Queries over time" pagelet always drops to zero from 16:00 - 18:00 (EST).

I've checked pihole.log and there's definitely activity during that time. It seems strange the graph would drop to 0 between those same times three days in a row.

I just installed Pi Hole and love it. I used the install script on a fresh install of debian. The only issue is , i dont have the option to update the lists, is that not live yet?

Hey Guys,

Sorry I'm very new to all this but Pi Hole Admin panel is not updating Ads Blocked Today and % Of Today's Traffic Is Ads.

Expected Behaviour:

• Information on the Pi Hole Admin panel to show Ads Blocked Today and % Of Today's Traffic Is Ads counters.

Actual Behaviour:

• Pi Hole Admin panel is not updating Ads Blocked Today and % Of Today's Traffic Is Ads.

Steps to reproduce this issue:

• Raspberry Pi Jessie
• Re ran curl -L https://install.pi-hole.net | bash
• /var/log/pihole.log has entries
• ads are blocked
• http://192.168.2.20/admin/api.php returns

{"domains_being_blocked":"95,364","dns_queries_today":"2,160","ads_blocked_today":"0","ads_percentage_today":"0.0"}

• I have tried to change permissions too.
  sudo touch /var/log/pihole.log sudo chmod 644 /var/log/pihole.log sudo chown dnsmasq:root /var/log/pihole.log

When JS is disabled, the dashboard breaks. I made a project that partially solves this issue.

Thoughts? If you like it, I can commit it in. (I do a lot of web stuff, so I disable my JS a lot for testing and it's really annoying when I load this console wait one minute for nothing to happen and then realise that JS is off.)
Sorry if this comes across as advertising, it's not. I have this on my local version of Pi hole, I'm just seeing if it interests anyone else.

@gforke97 commented on Sat Oct 01 2016

Expected Behaviour:

Domains added over the Webinterface should be added to the Black/Whitelist

Actual Behaviour:

Domains dont get added to /etc/pihole/whitelist.txt or /etc/pihole/blacklistlist.txt

Steps to reproduce this issue:

Adding a domain over the Webinterface

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

pi-hole/pi-hole#191 (comment)

See issue on the main pi-hole repo for details.

Expected Behaviour:

The mouse tooltip in Query Types graph should show just the query type. A, AAAA, DNSKEY, SRV, etc. Here is a list: https://en.wikipedia.org/wiki/List_of_DNS_record_types

By this, I mean, the text should say "AAAA", not "query[AAAA]". Also, Type 43 (DS) should show as just "DS", not "query[type=43]"

So, the text "query[" and "]" should be stripped out. Any "type=nn" should lookup a table and replace the "type=nn" text with the actual Query type. I've only seen "type=43", but it could apply to other types.

Actual Behaviour:

A, AAAA, DNSKEY, and SRV all show up as query[A], query[AAAA], query[DNSKEY], and query[SRV] respectively. DS shows as "query[type=43]".

Granted, "query[type=43]" is technically a dnsmasq bug, as my log from /var/log/pihole.log shows: (as compared to an A record)

Mar  6 00:01:09 dnsmasq[2468]: query[A] {website1}.com from 192.168.1.1
Mar  6 00:01:09 dnsmasq[2468]: forwarded {website1}.com to 8.8.8.8  
Mar  6 00:01:09 dnsmasq[2468]: query[type=43] {website2}.com from 192.168.1.1
Mar  6 00:01:09 dnsmasq[2468]: forwarded {website2}.com to 8.8.8.8  

(websites and addresses have been changed)

Edit: also, in the Query Log page, under the Type column, it just shows "type=43". at least here, the "query[" and "]" text is already stripped out.

Steps to reproduce this issue:

It's always there.

@richardhughes260 commented on Fri Apr 08 2016

Feature Request:

Can you install a pause button?

Some sites I go to sense the ad blocker and do not render the content.

Expected Behaviour:

Microsoft Edge seems to be able to display it properly.

Actual Behaviour:

Firefox seems to have issues. The temperature is listed, but just out of view.

Steps to reproduce this issue:

Open firefox and navigate to pi.hole/admin

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

Expected Behaviour:

Sanity check on domain entry for whitelist/blacklist to discount casing.

Actual Behaviour:

adding to either list fails when domain contains a capital letter

Steps to reproduce this issue:

add a domain with a capital letter.

see here

This may actually be a bug in the script itself...

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

Hi,

I am very keen on all the great work people are doing to enhance the admin interface. Right now there are several items like #23 and #20 that show different information both on the index. I also saw the whitelist/blacklist addition that was available from the left navigation menu. And MySQL stats, someone creating a SQLite version of it . . .cool things!

I think it might help to set some guidance (by @jacobsalmela ?) on what would be the best way to add features. For example I think it would be impractical to combine both #23 and #21 on the same index. They do display different information so having them both would be great, just not sure if that should be on 1 page (load/processing time).

Wouldn't it help if pages like these would move to the navigation on the left and the index is simply a summary? That way (if they become separate pages) they might not get stuck when master/dev branches become different since they are in different parts.

I can also imagine that when the pihole.log is parsed into a 'standard' database type/format the stats can be run through php instead of fetching all the data live from the file itself (especially since that is purged once a day). Not sure what would be the best way to set that up would be, but I thought maybe expressing the idea would get a conversation regarding this started.

Regards Alex

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@xoniq commented on Fri May 06 2016

Is it possible to ignore requests coming from localhost (127.0.0.1)?
My server running pi-hole does lots of trafficking by itself, these are 80% of the traffic handled by the server, so the statistics are quite useless right now. (0,2% of today's traffic is ads)

Hi,

This problem has to do with something inside of the index.php file, specifically line 170. That particular number (domains being blocked) is wrapped inside a ^{tag, and unless you're planning to put something below it, it's causing a problem that makes this box inconsistent with the others. Below is a screenshot:}

Never made changes in git before, so I'm afraid to download and upload to fix this on my own for fear of messing other things up, but if you remove this one tag it'll clean up the page and make everything much cleaner.

Thanks!

Just opening an issue here for this issue, as it's to do with the web side of things.

It would be great to have the administrator interface in our own language.
By the way, I can help with french translation

Expected Behaviour:

Expect web admin UI to load.

Actual Behaviour:

admin UI does not load.
Error in logs:

(mod_fastcgi.c.2694) FastCGI-stderr: PHP Parse error:  syntax error, unexpected '[', expecting ')' in /var/www/html/admin/header.php on line 4

Steps to reproduce this issue:

Deploy using php 5.3.

Expected Behaviour: Add/Delete website to white/black list

Actual Behaviour: Failure to do so.

Steps to reproduce this issue:

I navigate to the white/black list pages and attempt to add a url by hitting the Add button OR enter button. See the album below.

http://imgur.com/a/6USzo

As raised in pi-hole/pi-hole#643, I would like the ability to configure a forwarding server for certain domains. I see this most commonly being used to forward requests to another internal DNS server, such as one running on an intranet's router, which resolves local LAN domains.

See pi-hole/pi-hole#643 for more information.

@Mcat12 indicated also in this comment that this functionality might be implemented in the command line tool primarily, as it's largely a one-time setup task. I can see it being used administratively to add forwarding servers for other, non-standard TLDs like .bit.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

As discussed on the other repo, i was getting a PHP error after install

2016-06-01 23:12:30: (mod_fastcgi.c.2695) FastCGI-stderr: PHP Warning:  max(): Array must contain at least one element in /var/www/html/admin/data.php on line 227
2016-06-01 23:12:30: (mod_fastcgi.c.2695) FastCGI-stderr: PHP Warning:  max(): Array must contain at least one element in /var/www/html/admin/data.php on line 227
2016-06-01 23:12:30: (mod_fastcgi.c.2695) FastCGI-stderr: PHP Warning:  min(): Array must contain at least one element in /var/www/html/admin/data.php on line 228
2016-06-01 23:12:30: (mod_fastcgi.c.2695) FastCGI-stderr: PHP Warning:  min(): Array must contain at least one element in /var/www/html/admin/data.php on line 228
2016-06-01 23:12:30: (mod_fastcgi.c.2695) FastCGI-stderr: PHP Fatal error:  Maximum execution time of 30 seconds exceeded in /var/www/html/admin/data.php on line 234

Resulting in an infinite spinner showing at the graph.
Looking at the code you could solve this by:

if(count($times1) > 0 && count($times2) > 2){
        $max = max(array(max(array_keys($times1)), max(array_keys($times2))));
        $min = min(array(min(array_keys($times1)), min(array_keys($times2))));
} else {
   $times1 = array();
   $times2 = array();
}

Did not tested this code.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

Expected Behaviour:

Type, domain and client are populated properly

Actual Behaviour:

Type shows the domain name (truncated to domain - 1 char), domain shows "from", client is blank

Steps to reproduce this issue:

View the query log page

I know that a recent issue was completed to correct something similar, but I am on Web Interface Version 1.1.5, Ubuntu 14.04 LTS, and dnsmasq 2.68

The pi-hole log has the following as a line:

Mar 12 12:10:07 dnsmasq[31352]: reply mqtt.c10r.facebook.com is 31.13.66.3

Perhaps it's a dnsmasq config issue, and I know this isn't on a PI, but for how useful this program is, I tried it anyway. Everything else is working perfectly!

Upgraded to latest pi-hole (2.7)

The Query Types and Forwarded Destinations pie-charts were circular in shape, but they are now stretched vertically

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.