Giter VIP home page Giter VIP logo

Comments (3)

blakeembrey avatar blakeembrey commented on July 27, 2024

The code on master is passing the test. I have it passing locally too. I’m not sure what you’re referring to when you say the “code on master” has a different result.

from path-to-regexp.

blakeembrey avatar blakeembrey commented on July 27, 2024

I'm finding it hard to discuss "in reality" here, because in reality these tests pass and /baz does match. Also, you're mentioning two things:

In reality, /baz would not match because options.start defaults to true.

In reality it does match and that's a code functionality of this library, to match this code.

With the code in master, the tokens actually look like the following

Are you saying, that in master, with zero code modifications, the test suite is failing? Can you share something to confirm this?

from path-to-regexp.

Lord-Kamina avatar Lord-Kamina commented on July 27, 2024

Jesus ignore me; I was very tired.

What I thought was happening was parse() returned a different value than what the test file actually registered (for me, both running your code as well as the ported version I was getting the same output, two tokens, one of them with a prefix) but I just realized I hadn't escaped the / in my route. Ignore this.

from path-to-regexp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.