We are looking forward to using pinax-announcements with Django 3.2 on edX.

Required PR - #68 is already merged into the master branch.
Do there any chance a new version will be bumped soon?

If any blockers with the release I would be happy to help.

Thank you in advance.

@paltman

I have successfully created an announcement, but its only visible to superusers of the application and not for all users.

Is this how it is supposed to be like or is it that the announcement is for all the users in the app?

django.conf.urls.url() got removed in Django 4.0, as seen here:

Also, the providing_args argument for django.dispatch.Signal is removed as seen here:

{% load announcments_tags %}

should be

{% load announcment_tags %}

and

{% announcements as whatever %}

should be

{% fetch_announcements as whatever %}

With the latest pull request added to support Django 1.5+, can you update PyPI so the latest package can be downloaded?

Thanks!

I reported to the wrong app before. Here's the description of the issue below.

Small syntax errors on these lines: https://github.com/pinax/django-announcements/blob/master/announcements/templates/announcements/announcement_form.html#L21 and https://github.com/pinax/django-announcements/blob/master/announcements/templates/announcements/announcement_form.html#L23

Should be View.

I have an error TemplateDoesNotExist, after checking out the root cause is the models has get_absolute_url, meanwhile that view doesn't have any templates found.

def get_absolute_url(self):
    return reverse("pinax_announcements:announcement_detail", args=[self.pk])

As docs said https://github.com/pinax/pinax-announcements#templates:

Default templates are provided by the pinax-templates app in the announcements section of that project.

Meanwhile, in my case I don't really need this template, because I'm just using default Django admin to reach out the announcements.

So, what I'm thinking is, probably we can just disable the View on site button or maybe can also disable/remove the get_absolute_url in admin page. But, how I can achieve this?

Let say, not just focus on pinax-announcements, this probably happens in another case.

Currently opening dismiss_url with GET results in 405 HTTP response. So it is usable only with Javascript+XMLHttpRequest and accessibility suffers greatly. To make it work without Javascript it is required to write a lot of dumb code like

<form action={{...dismiss_url}} method=POST>
<input type=submit>
...

There is no reason why it shouldn't be possible to dismiss with GET. When called with GET it could return HttpResponseRedirect to HTTP_REFERER instead of useless {} JSON response.

When installing this app I get these cryptic errors:

django.template.exceptions.TemplateDoesNotExist: pinax/announcements/announcement_list.html, announcements/announcement_list.html

Looks like #48 removed all the templates, and AFAICT the documentation has no advice on where to find them.

When installing django-announcements my project stops running due to

django.core.exceptions.AppRegistryNotReady: Models aren't loaded yet.

and it's originating from User = get_user_model() in announcements/models.py

From my findings get_user_model() has to be run during runtime after but not sure..

Any ideas how to fix this?

Thanks.

See django-user-accounts for good example of how we should do this.

Screenshots

Desktop

• OS: MacOSX, Windows, Linux
• Browser Chrome
• Version 92.0.4515

Solution:

I think we can just check whether request is filled.

def render(self, context):
    request = context.get('request', None)
    if request:
        qs = Announcement.objects.filter(
            publish_start__lte=timezone.now()
        ).filter(
            Q(publish_end__isnull=True) | Q(publish_end__gt=timezone.now())
        ).filter(
            site_wide=True
        )
        exclusions = request.session.get("excluded_announcements", [])
        exclusions = set(exclusions)
        if request.user.is_authenticated:
            for dismissal in request.user.announcement_dismissals.all():
                exclusions.add(dismissal.announcement.pk)
        else:
            qs = qs.exclude(members_only=True)
        context[self.as_var] = qs.exclude(pk__in=exclusions)
    return ""

Looking for maintainers!

There is a lot of pull requests and open issues that the current maintainers, myself included, are just not finding the time to properly get to.

Maybe you've submitted some PRs and are frustrated with the lack of attention. Maybe you use this project in one or more of your projects and want to see that it is properly carried forward.

Whatever you reasons may be, let me know if you have interest and I'll add you to the repo and to PyPI (will need your PyPI name).

Preference will go to those who have commits on this repo and/or have shown an active interest in the issues.

Thanks!
Patrick

Documentation (docs/index.md) should point out pinax-announcements URL names are namespaced.

Incorrect:

url(r"^announcements/", include("pinax.announcements.urls")),

Correct:

url(r"^announcements/", include("pinax.announcements.urls", namespace="pinax_announcements")),

In the Groupware Starter Project page milestone 1, this app is referenced as pinax-announcements and not django-announcements.

I think it's because it should be renamed.
I think the link should be updated until this app was renamed.

2.0.1 has several important documentation corrections.

Will you publish a new version on Git and to PyPI, please?

In urls.py:
app_name = "pinax_announcements"
url(r"^$", views.AnnouncementListView.as_view(), name="announcement_list")

and in views.py, models.py, etc.

reverse("pinax_announcements:announcement_list")

While previous Google Code site indicates this was MIT licensed, there's nothing in this repo to tell users what license it is being provided under.

Usage documentation is not up-to-date with latest eldarion-ajax.

Use something like this:

<a class="btn ajax" data-method="post" data-replace-closest=".announcement" href="/announcements/2/hide/">
    Clear
    </a>

Hi

in the following code snippet in the readme you have announcement_list and announcementS_list, which results in no announcements displayed.
``

Announcements

{% announcements as announcement_list %}

{% if announcements_list %}
    <div class="announcements">
        {% for announcement in announcement_list %}
            <div class="announcement">
                <strong>{{ announcement.title }}</strong><br />
                {{ announcement.content }}
            </div>
        {% endfor %}
    </div>
{% endif %}``

There is a flake8 error in current version:
pinax/announcements/urls.py:1:1: F401 'patterns' imported but unused

No longer needed since templates exist in pinax-theme-bootstrap.