pinnymz / python-zmanim Goto Github PK

Are there any plans to port over the ComplexZmanimCalendar class from KosherJava? Or is it already implemented elsewhere?

When I run this bit of code

from zmanim.hebrew_calendar.jewish_calendar import JewishCalendar
print(JewishCalendar(5783, 1, 17).day_of_week)

it insists that today is that date (today) is shabbos, which it is not.
Are the calculations off? Or is it a problem on my end?

Different times yield different zmanim.
MWE:

import datetime as dt
from zmanim.util.geo_location import GeoLocation
from zmanim.zmanim_calendar import ZmanimCalendar
location = GeoLocation('Lakewood, NJ', 40.0721087, -74.2400243, 'America/New_York', elevation=15)
print(ZmanimCalendar(geo_location=location, date=dt.datetime(2023,8,7)).shkia())
print(ZmanimCalendar(geo_location=location, date=dt.datetime(2023,8,7,1)).shkia())

Even worse, when no date is passed, the default is a datetime object with the current time, so

print(ZmanimCalendar(geo_location=location).shkia())

will yield different, incorrect times throughout the day.

As per @pinnymz, ZmanimCalendar should require a date object.
While a datetime object can be coerced to a date, since the caller may possibly want the next day's zmanim (e.g., if it's after nightfall), we agreed that the input should be restricted to date object, placing the onus on the caller to decide which date.

PR to follow.

Hi
There is limudim module
But if I install package via pypi, this module is missing. Could you please bump pack version with this module?
Thank you a lot!

When jd.back() is called and it needs to go a year back
like this:
jd = JewishDate(5781, 1, 1)
jd.back()
or
jd.forward(-1)

I get an error

m = days_of_year.length
AttributeError: 'list' object has no attribute 'length'