pixinsight / pcl Goto Github PK

Hi all,

This is to let you know that all of our open-source Git repositories are now on GitLab:

https://gitlab.com/pixinsight

These GitHub repositories will still be available for a limited time, but no pull requests will be accepted from GitHub anymore. The migration to GitLab was planned since October 2018, but postponed until completing the PixInsight 1.8.6 release.

If you are one of our collaborators, or if you want to collaborate with us from now on, please create a GitLab account (it's free) if you don't already have one, then join us by letting me know your GitLab user name.

If you have contributed code to PixInsight, better use the same user name as on GitHub, so your commits can be associated with your new GitLab account. If you were following some of our repositories on GitHub, please follow them also on GitLab.

See also the official announcement on PixInsight Forum, in case you want to follow a possible discussion there:

https://pixinsight.com/forum/index.php?topic=13369.0

Thank you.

Hello Juan,

I tried to compile from master the libPCL-pxi.a and run into error:

make -f ./makefile-x64 --no-print-directory
make[1]: *** No rule to make target 'x64/Release/HTMLEntity.o', needed by '"/home/tstibor/dev/astronomy/pixinsight/PCL/src/pcl/linux/g++/x64/Release"/libPCL-pxi.a'.  Stop.
Makefile:18: recipe for target 'all' failed
make: *** [all] Error 2

It looks like that in commit f82a90e the auto-generated makefile included +../../HTMLEntity.cpp \ though the file HTMLEntity.cpp was not included in the commit. Tested one commit before (7b977b6)
and everything compiled and libPCL-pxi.a is created:

...
...
ar: creating /home/tstibor/dev/astronomy/pixinsight/PCL/src/pcl/linux/g++/x64/Release/libPCL-pxi.a
make -f ./makefile-x64 --no-print-directory post-build
cp "/home/tstibor/dev/astronomy/pixinsight/PCL/src/pcl/linux/g++/x64/Release"/libPCL-pxi.a /home/tstibor/dev/astronomy/pixinsight/PCL/lib

Cheers
Thomas

Hi Team, and especially Klaus,

I have just pushed a complete revision of Klaus' INDIClient module: 48e3476, where we have a new, fully operational INDIMount process. In first place, congratulations to Klaus for his excellent work. The main changes with respect to Klaus' latest pull request #28 are:

• Redesigned INDINewPropertyItem class with more flexible template constructors.
• New template member functions INDIClient::SendNewPropertyItem() and INDIClient::MaybeSendNewPropertyItem() for simplified sending of device properties, including bulk properties.
• Extensive use of new PCL resources for sexagesimal numeric conversion and representation. See String::SexagesimalToDouble(), String::TrySexagesimalToDouble(), String::ParseSexagesimal(), String::TryParseSexagesimal() and String::ToSexagesimal() member functions (and their IsoString counterparts) in pcl/String.h and pcl/String.cpp. See also the new DecimalToSexagesimal() and SexagesimalToDecimal() global functions in pcl/Math.h.
• Redesigned CoordinateSearchDialog class with more powerful online search and interactive information visualization capabilities.
• Redesigned INDIMountInterface class.
• Improved AbstractINDIMountExecution (and derived classes) for better GUI interaction.
• Changed class member and enumeration identifiers for coherence with PCL coding style guidelines.
• Changed exported parameter identifiers to be more coherent with existing JavaScript interfaces. Of course, I have updated the relevant test scripts accordingly.
• New IMCCommand::ParkDefault command to park the mount at the current park coordinates (TELESCOPE_PARK_POSITION property). The IMCCommand::Park command now parks at the p_targetRA and p_targetDec parameter values of INDIMountInstance.
• Bug fixes and performance improvements.

I have tested this version and it seems to work extremely well. It passes all tests without any problems. There are a couple of very minor issues I'm going to fix, but it is ready for release IMO. Let me know if you agree with the changes.

I've just committed a new version of the INDIClient module with many of the features we were discussing in other posts (apparent positions, better management of image properties/keywords, etc).

Lots of things to comment. I'll return here later with a description of changes.

IMO this version is now 100% ready for release. Let's see how it performs under the real sky...

Hello,

I have INDI running on a Raspberry Pi 3, with a ZWO filter wheel connected to it. This wheel works fine in KStars/Ekos, however PixInsight's CCD Frame module is not able to use any of the filters in it. The filter box is just greyed out, although the wheel is connected fine in INDIDeviceController.

I think these options refer to whether the selected rejection algorithm is applied for high and low pixels. These tooltips makes it sound like all values above the median will be rejected, no matter what algorithm is used. Some of the more sophisticated rejection algorithms will remove outliers, but not all pixels above the median.