The ptpd from plabble

ptpd's People

Contributors

Forkers

job79

ptpd's Issues

feat: add a generic store interface

feat: implement CONNECT

feat: implement UNSUBSCRIBE

feat: implement message encoding

feat: implement SUBSCRIBE

feat: implement the web socket transport layer

feat: add pebble store implementation

feat: implement REQUEST

feat: add a generic transport interface

Bug: permission model outdated

Hi! According to the recent docs the permissions are now stored as following:

Byte 15 of BucketId

bit 0: random
bit 1: random
bit 2: public read
bit 3: public write
bit 4: public append
( private read is always true, so not stored anymore )
bit 5: private write
bit 6: private append
bit 7: allow bucket to be deleted

I would suggest:

type BucketPermissions struct {
	Read   bool
	Write  bool
	Append bool
        DeleteBucket bool
}

// ...

if authorized {
		return BucketPermissions{
			Read:   true,
			Write:  id[15]&8 != 0 || id[15]&32 != 0,
			Append: id[15]&16 != 0 || id[15]&64 != 0,
                        DeleteBucket: id[15]&128
		}
	} else {
		return BucketPermissions{
			Read:   id[15]&4 != 0,
			Write:  id[15]&8 != 0,
			Append: id[15]&16 != 0,
                        DeleteBucket: false
		}
}