Hi,

I tried with Laravel 8. After creating the $filesystem, when using listFiles etc. It gives me error as
Call to undefined method League\Flysystem\Filesystem::listFiles

Thanks

Hey @sifex, BunnyCDN added storage zone locations (default to de) into it's library. Can you pull the changes from the parent?

Note: I opened the issue here since PlatformCommunity/BunnyCDN.PHP.Storage does not allow new issues; my apologies for the cross-post.

https://flysystem.thephpleague.com/docs/adapter/path-prefixing/

Came with 3.3 :-)

Hi,
I've noticed that folders aren't being deleted from my storage zone and I've tracked it down to a path issue. When performing a DELETE request for a folder, BunnyCDN API returns 404 if path doesn't end with /.
See my two requests below done via the Insomnia app:

The / at the end should be added in deleteDir method of BunnyCDNAdapter class, but since the fullPath method doesn't get info about an object being a directory, it doesn't pass it along to Util::normalizePath, which has a condition to add / at the end of directory paths.

Delete without any input should throw an error, shouldn't it?

adapter->delete('') will delete the entire storage. Heard of it happening 🙈 Devils are everywhere - regarding my need, there are other 3rd parties in the shopware environment doing strange things.

I checked deletion with same empty parameter in different filesystems (s3, local, ...), these are throwing errors.

Should we implement a check, like here? #68

Hi,

The CMS I am using is trying to call listContents on the root folder with the second argument deep set to true. Sadly, this does not seem to be implemented in this adapter. Any way we can make this work?

When handling files in folders that include the storage zone name, the adapter will not work as expected.

This problem occurs because str_replace is used to remove the storage zone from the path.

This will also remove folders from the path that have the same name.

Hi,

Thanks for this package.

Will this package be upgraded for laravel 9 ?

Thanks!

Temporary URLs could be supported by BunnyCDN-Token-Authentications

I have no need for it currently, nor do I see a real case that makes it necessary at the moment. But I think, when flysystem has this feature, there could be really cool needs. :-) Having a look, I thought it could be a feature to implement.

Hey there,

thank you for the project!!! :-)

I have a few things which seems not to have finished yet.
I'll try to support by PR next days.

• readStream should throw UnableToReadFile, not BunnyCDNException or NotFoundException
• listContents with deep should be supported
• possibility to specify root-directory/prefix-path

Hi,

We are running Laravel 8 and Statamic 3.4.
Wen i implement Bunny CDN i get the error like issue: #23
I see it is fixed in the driver version 3 but we cant install v3 or v2 because our Laravel installation requires flysystem v1.1.10
Could you make te fix to be backported to v1 and mayby also v2?

Thanks

Hey, I noticed something peculiar. By default, both BunnyCDNClient and BunnyCDNAdapter share the same exception handler, which is BunnyCDNExceptions. However, when attempting to perform actions with invalid credentials or invalid operations like deleting an invalid file, I couldn't catch the errors using the try block. After spending a considerable amount of time investigating the issue, I discovered that creating a new exception and using different exception handlers for BunnyClient and BunnyAdapter allows the errors to be thrown correctly.

Got this error:

Driver [bunnycdn] is not supported.

at .....\vendor\laravel\framework\src\Illuminate\Filesystem\FilesystemManager.php:149
145▕
146▕ $driverMethod = 'create'.ucfirst($name).'Driver';
147▕
148▕ if (! method_exists($this, $driverMethod)) {
➜ 149▕ throw new InvalidArgumentException("Driver [{$name}] is not supported.");
150▕ }
151▕
152▕ return $this->{$driverMethod}($config);
153▕ }

I did everything according to the documentation
Laravel Framework 9.52.4

Currently, the file is being removed.

Hi,

what would be a really helpful feature is if the adapter would respect the root config attribute that you can specify to put your files right into a specific directory, like the S3 adapter does.

Right now the code for getObject in the BunnyCDNAdapter is as follows

/**
     * @param $path
     * @return mixed
     */
    protected function getObject($path): StorageAttributes
    {
        $list = (new DirectoryListing($this->listContents()))
            ->filter(function (StorageAttributes $item) use ($path) {
                return $item->path() === $path;
            })->toArray();

        if (count($list) === 1) {
            return $list[0];
        } elseif (count($list) > 1) {
            throw UnableToReadFile::fromLocation($path, 'More than one file was returned for path:"' . $path . '", contact package author.');
        } else {
            throw UnableToReadFile::fromLocation($path, 'Error 404:"' . $path . '"');
        }
    }

However this will only list contents for the root directory on BunnyCDN - i.e. if Bunny is laid out like

a [Folder]
---1.jpg

b [Folder]
---2.jpg

c [Folder]
---3.jpg

Calling getObject('a/1.jpg') will always return an error since 1.jpg isn't in the root directory. To fix this, the code needs to be updated to search in the directory where the object is located

/**
     * @param $path
     * @return mixed
     */
    protected function getObject(string $path = ''): StorageAttributes
    {
       $directory = $path ? pathinfo($path, PATHINFO_DIRNAME) : '';
        $list = (new DirectoryListing($this->listContents($directory)))
            ->filter(function (StorageAttributes $item) use ($path) {
                return $item->path() === $path;
            })->toArray();

        if (count($list) === 1) {
            return $list[0];
        } elseif (count($list) > 1) {
            throw UnableToReadFile::fromLocation($path, 'More than one file was returned for path:"' . $path . '", contact package author.');
        } else {
            throw UnableToReadFile::fromLocation($path, 'Error 404:"' . $path . '"');
        }
    }

Now a/1.jpg will return as expected

Hello!

How do you set-up the path prefixing?

I've attempted to set it up with Laravel, and it uploads the files as expected in the prefixed path, but upon URL retrieval it throws:
"This driver does not support retrieving URLs.",

Do you have an example with a prefixed path?

Hi,

I have tried to setup this for my Bunny CDN, I followed the steps carefully for Laravel 9, but can't get it working. There must be something that I am missing to configure correctly. Can you please help me set this up.

Thanks

Hi guys,
I'm using v1.3.0 of your library at the moment. Looks like a crash appears sometimes in normalizeObject method of BunnyCDNAdapter class which produces this exception: Call to a member function getTimestamp() on bool. We only noticed it in production due to the sheer amount of files we are processing there.

After adding some logs to the class I found out that Bunny API sometimes returns file change and creation timestamps in the format you expect (e.g. 2022-04-10T17:43:49.297) but sometimes the fractional seconds are missing: 2022-04-10T16:40:48. When fractional seconds are missing, the code crashes because the DateTime object can't be created from format and date_create_from_format returns false.

Could you find a fix for this issue? We already contacted the bunny team too to standarize the timestamps a bit more but the issue is quite urgent for us hence the ticket here too. :)

When uploading a file, I get:

League\Flysystem\NotSupportedException: BunnyCDN does not support steam writing, use ->write() instead in file /Users/xxx/Code/xxx/vendor/platformcommunity/flysystem-bunnycdn/src/BunnyCDNAdapter.php on line 75

If you request a file which contains json, it gets decoded as array.

After successfully using the package in a Laravel 8 project, I wanted to check it out with Laravel 9 and Statamic 3.3. I created the filesystem and also followed the Laravel 9 instructions.

When connecting the filesystem to Statamic, I get the following exception:

I can upload files (they appear in the bunny.net File Manager) but are not shown in Statamic, instead, the mentioned exception is thrown.

Yea, limitation of BunnyCDN

On the way

Hey!

Followed the steps for Laravel 9.

However, when using BunnyCDN via Storage I get the error:

Cannot instantiate interface League\Flysystem\FilesystemAdapter.

Hi guys, it's me again :) Last time I was trying to delete a directory, now I'm trying to list directories inside a directory. The case is I have a folder which contains a bunch of other folders:

sites/
├─ inner folder 1/
├─ inner folder 2/
├─ ... etc

I'm trying to get a list of folders inside sites folder but I get an empty array when running the following code even though there should be tons of folders there:

$directories = $disk->directories('sites');

I've managed to trace and fix this bug locally. And I'm happy to create a PR with the fix but want to get your opinions about it first.

What is the issue?
When listing directories, the results of listContents() from the adapter are passed to \League\Flysystem\Util\ContentListingFormatter@formatListing. This formatter filters the list using, among others, this piece of code:

$entry['dirname'] === $this->directory

Source: https://github.com/thephpleague/flysystem/blob/1.x/src/Util/ContentListingFormatter.php#L64

And the "dirname" of each entry returned from adapter looks like this: /sites/. Obviously "/sites/" !== "sites" which is why each folder is deemed out of range.

A fix would be to change the PlatformCommunity\Flysystem\BunnyCDN\BunnyCDNAdapter@normalizeObject a bit from this:

'dirname' => $this->removePathPrefix($fileObject->Path),

to this:

'dirname' => trim($this->removePathPrefix($fileObject->Path), "/"),

But not sure if this would be a breaking change maybe? What do you guys think?

Hi,

I discovered an issue with the lastModified function if you pass a directory as the path. On other adapters like the ftp adatper, the function should throw an error like so: https://github.com/thephpleague/flysystem-ftp/blob/e59ae1b1370503a7925a75cc44f6f99cced1b2f0/FtpAdapter.php#L334. It will check if the file returned a lastModified date and since directories do not return that, it will fail. On the bunnycdn adapter it will not fail. It will only check for 404s or more than one file returned. This results also in a type error because lastModified expects FileAttributes to be returned but if you pass a directory, DirectoryAttributes will be returned.

Reproducible by just trying to call lastModified on a folder path.

What do you think about just checking for:

if (is_a($object, DirectoryAttributes::class)) {
    throw UnableToReadFile::fromLocation($path, 'Path is a directory');
}

in the function lastModified?

Could we upgrade this package to require the latest version of guzzle, v 7.0.ie "guzzlehttp/guzzle": "^7.0"

I am trying to resolve this issue: composer/composer#9306
and am seeing conflicts because of different minimum required versions of guzzle.