ploeh / asynchronous-injection Goto Github PK

Isn't TaskMaybe against composability? I would like to be able to compose a Task and Maybe together, so Task does not need to know about Maybe, and Maybe does not need to know about Task.

Perhaps dotnet-xunit can be removed from BookingApi.UnitTests.csproj(?)

$ git diff
diff --git a/BookingApi.UnitTests/BookingApi.UnitTests.csproj b/BookingApi.UnitTests/BookingApi.UnitTests.csproj
index c6581aa..acd844c 100644
--- a/BookingApi.UnitTests/BookingApi.UnitTests.csproj
+++ b/BookingApi.UnitTests/BookingApi.UnitTests.csproj
@@ -17,7 +17,6 @@
     <PackageReference Include="Moq" Version="4.9.0" />
     <PackageReference Include="xunit" Version="2.3.1" />
     <PackageReference Include="xunit.runner.visualstudio" Version="2.3.1" />
-    <DotNetCliToolReference Include="dotnet-xunit" Version="2.3.1" />
   </ItemGroup>

   <ItemGroup>

$ git clean -xdf
Removing BookingApi.UnitTests/bin/
Removing BookingApi.UnitTests/obj/
Removing BookingApi/bin/
Removing BookingApi/obj/

$ ./build.sh
Build started, please wait...
Build completed.

Test run for <...>\Ploeh.Samples.BookingApi.UnitTests.dll(.NETCoreApp,Version=v2.0)
Microsoft (R) Test Execution Command Line Tool Version 16.0.0-preview-20181205-02
Copyright (c) Microsoft Corporation.  All rights reserved.

Starting test execution, please wait...

Total tests: 4. Passed: 4. Failed: 0. Skipped: 0.
Test Run Successful.
Test execution time: 2.5872 Seconds

This is on a fresh Windows 10 (build 1809) with Visual Studio 2019 Preview (16.0.0 Preview 2.2).

Just saw your NDC video. The presentation was fabulous but one thing struck me from the beginning - returning 500 if table is unavailable. For a client it looks like something exceptional happened on the server but isn't it a common thing that a table is full?

It's a minor thing but I'm wondering what if I'd like to return Reservation on both cases instead of an integer? Because now a client has to deal with this 'hot potato'.