CI is not (visibly) in place about dash-bio HOT 6 CLOSED

Hi @VeraZab and @shammamah,

Please let me re-purpose this issue, keeping it simple. Leaving the DDS issues aside, we want CI for this repo.

There is a .circleci/ folder, but there is no badge showing passed/failed builds in the README, nor green check marks near each pushed commit on master... So, either CI is not set up yet, or it is (to a certain extent) but we don't 'see' it. Either way, it is an issue.

(We want to see the green check mark near merge commits as well, which ties in with my original intention when opening this issue.)

Let's be humble and realistic wrt code coverage. Apparently, we already have an integration test. Once we get all current open PRs merged in (which is the priority, so that @shammamah can start the New Year as a happy maintainer), we could implement a unit test for each component. What do you think?

from dash-bio.

: ) it's the deployment to dds that would need to be automated, this is not linked in any way to the deployments of review apps to heroku

from dash-bio.

Yes, it's not the real thing (which is deploying to DDS, which I won't be touching), but we should do it if it's a low-hanging fruit and if it doesn't cost extra money.

from dash-bio.

@plotly/dash-bio : now that #101 is merged, we should create components unit tests :)

from dash-bio.

@mkcor : now CI is in place, I close this issue and open #109 as the CircleCI checks are not passing :)

from dash-bio.

@Bachibouzouk I disagree. CI is still not visibly in place (e.g., there is no build badge in the README). The issue would be closed by a PR anyway, which would be worth referring to.
Please reopen.

from dash-bio.