Comments (6)
We should consider to release the crate with the traits which would define API and then use it in own implementations and enable foreign.
I'm not sure yet about downsides of this approach aside from some added complexity which would buy uniformity of all implementations. So counter arguments are welcome.
from zk-nullifier-sig.
I don't expect most people to use the crate anyways since it'll require custom logic to get the secret key in there and don't know any rust wallets.
Agree on adding docs and making name more uniform.
from zk-nullifier-sig.
from zk-nullifier-sig.
Got it -- that makes sense, I don't know anything about those. Traits seem fine to me -- the complexity shouldn't be that high on our side right, just implementing the trait twice? As long as almost everything is pub, I'm OK with that.
from zk-nullifier-sig.
Can you make a gitbook or mdbook and make this? Also, can you publish a cargo crate -- there should automatically be cargo docs from the docstrings right?
from zk-nullifier-sig.
Can you make a gitbook or mdbook and make this? Also, can you publish a cargo crate -- there should automatically be cargo docs from the docstrings right?
Yep. Here it's needed to groom the interfaces and write those docstring.
from zk-nullifier-sig.
Related Issues (20)
- Refactor `CryptoError`
- Refactor `verify_signals`
- Error handling in _rust_k256_
- `tests` in <./rust-k256> are confusing HOT 4
- Upgrade `k256` in _rust-k256_ to "~0.13.0"
- Introduce DST specific for the protocol! HOT 3
- Are bad/malicious inputs tested?
- Add `sign` method to <./rust-k256> HOT 5
- <rust-arkworks> depends on a deprecated crate HOT 2
- `ProjectivePoint` should be avoided in interfaces HOT 4
- <./rust-arkworks> is over generalized HOT 3
- `SecretKeyMaterial` is handled recklessly in <./rust-arkworks>
- <./rust-arkworks> accepts signature with incompatible variant
- Support `serde` for all `struct` in `plume_rustcrypto`
- `nullifier` is treated just like an EC point HOT 2
- Unit tests would help reference implementation readability HOT 10
- Add tests for wrapping `c` over $p$ HOT 1
- prevention of PK recovery with two signatures on the same message HOT 1
- Run circom tests in parallel
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from zk-nullifier-sig.