Giter VIP home page Giter VIP logo

Comments (5)

skaunov avatar skaunov commented on May 17, 2024

Depending on the answer I would raise an issue for changing the struct parts to AsRef or creating some facility methods for instantiation of the signature.

from zk-nullifier-sig.

Divide-By-0 avatar Divide-By-0 commented on May 17, 2024

It's good to have a plume signing function exposed!

from zk-nullifier-sig.

Divide-By-0 avatar Divide-By-0 commented on May 17, 2024

skaunov
should add that it's also needed to

  • convert tests to integration,
  • clean hex strings assertions for further comprehensibilty.
    (This well might demote AsRef issue to a nice to have thing.)

from zk-nullifier-sig.

skaunov avatar skaunov commented on May 17, 2024

@Divide-By-0 , what do you think should we provide a sign with given $r$ method? I'm hesitant since it'd encourage nonce reuse and consequence break of the protocol. So I'm inclined to hide such a method in a debug target.

from zk-nullifier-sig.

Divide-By-0 avatar Divide-By-0 commented on May 17, 2024

@Divide-By-0 , what do you think should we provide a sign with given r method? I'm hesitant since it'd encourage nonce reuse and consequence break of the protocol. So I'm inclined to hide such a method in a debug target.

Sounds good to me. You're right, reusing r would leak the secret key.

from zk-nullifier-sig.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.