plyst / cakephp-minifyhtml-plugin Goto Github PK

Just for anyone that would actually use this:
On an average website - let's say 10k lines of html - the rendering rises dramatically from 5-10ms to over 150ms!
Do not use this plugin without being aware that the minifaction cost a magnitude of ressources more than just sending the non minified version.
It doesn't even minify everything, for example it has problems with embedded things like js code.

And instead of just whining, here a one liner that only has an impact of 60-80% and is actually doing better work:
return preg_replace(array('/ {2,}/', '/<!--.*?-->|\t|(?:\r?\n[ \t]*)+/s'), array(' ', ''), $html);

This may help people who see the minifier trying to get its hands on JSON responses. Throw this in your app controller's beforeRender()

// if the response is HTML then minify it
if ($this->response->type() === 'text/html') {
    $this->helpers[] = 'MinifyHtml.MinifyHtml';
}