Better plot coloring / market price visual about crypto-whale-watching-app HOT 35 CLOSED

For horizontal line
'shapes': [ {'type': 'line', 'x0': 1, 'y0': 0, 'x1': 1, 'y1': 2, 'line': { 'color': 'rgb(255, 255, 255)', 'width': 3 },

For background color I´ll try some JS.

from crypto-whale-watching-app.

Good deal. I just pushed the horizontal line to master. If you can do the background color with JS that'd be great @theimo1221 :)

from crypto-whale-watching-app.

I don´t like the hardcided suze, I mean look at this:

We just waste space we have...

from crypto-whale-watching-app.

What is wrong with this:
Vertical screen:

Horicontal Screen:

Personally I can´t see the need for a hardcoded hight/ wide, will always lead to probs due to wide range of screen sizes/ resolutions

from crypto-whale-watching-app.

I can add you some JS to set it to fix size, but having it responsive on window resizes and stuffs needs to stay active....

from crypto-whale-watching-app.

@theimo1221 good call. I hadn't thought about the JS. Just changed master back to use autosizing.

from crypto-whale-watching-app.

But keeping the margin in seems good for me. Version #48 looks quite good.

from crypto-whale-watching-app.

Good deal. Margin spacing is quite nice. All that remains for this issue is any iteration we want on the background color.

Would also like the horizontal line that shows market price to extend all the way to the end of y axis as opposed to stopping at the center point of the last bubble.

from crypto-whale-watching-app.

#59 opens possibilities to improve this one

from crypto-whale-watching-app.

Integrated #59 @theimo1221
-JS option now good to go. I want to keep that to just the aesthetic alterations. Top priority is some visual cleaning up and hopefully a dark-mode version. What I'm linking below looks viable, but let me know your thoughts.

https://stackoverflow.com/questions/28357405/dark-mode-switch

from crypto-whale-watching-app.

I don´t want to toggle it static over css.
I´d like to do it this way.
I´ll add a spoiler hide/ showing a div in wich you can set Color for multiple obejcts.
Afterwards chosen color get´s stored in localstorage, to be able to maintain individual user settings

from crypto-whale-watching-app.

Hi, I like the concept behind this app but I have some UI/UX questions:

• What is the reasoning behind the current axes?
• I am curious as to whether it is more usable if this would be overlayed on the actual depth chart, I have a feeling it would be easier to process visually
• Are you able to identify 'unique' whales? I figure it would make sense to color code them, so we can see if they have both sell/buy walls (this would also be very cool on a depth chart)
• I could see the benefit in 'ghosts', showing walls that have been pulled at half opacity for a few updates

I am not a Python programmer (I am fine in javascript), if you are interested in the above features I would like to help.

from crypto-whale-watching-app.

Axis:
Price obvious volume for highlighting the influence

Depth chart
Adressed in #20 accidentally closed

Unique whale:
Not by user but sometimes we can guess it by sizes. But we don't want to present assumption just clear facts

Ghosts:
Currently not implemented, but obviously you can just press freeze open a 2nd tab and have 2nd instance

As your points mainly address plotly js help would be needed in other components

from crypto-whale-watching-app.

@Cygnusfear feel free to review #70

from crypto-whale-watching-app.

Taken care of. Only thing that remains before this can be closed is the background color / darkmode question. I care less about the selective coloring as mentioned in my initial bullet points.

from crypto-whale-watching-app.

Yeah, I will do it. But I'm quite busy currently at both my jobs...
Weekend might be a good time to implement some more

from crypto-whale-watching-app.

@theimo1221 haha no rush man! I feel you on both fronts. Like I laid out on our call recently, I think we're in a really good place. Just steady improvements from here, but our baseline is solid.

from crypto-whale-watching-app.

The last bullet point might be done with two rectangle shapes in Plotly: plotly/plotly.js#922 (comment)

from crypto-whale-watching-app.

@mifunetoshiro not what we are looking for, due to the fact we want it changeable by the user.
So changing it in Plotly would change it for all people visiting the site.

So we have to do it with JS on clientside

from crypto-whale-watching-app.

The way I discovered #89 is I was trying to plot a horizontal line of the market price and the change from 24h ago like this:

I noticed that the line wouldn't draw on the BTC-GBP plot for some reason (fixed with @theimo1221's pull #90)

Here is my hacky code: mifunetoshiro@a8fcbc4 (throws '288' key errors in console for some reason)

It also says on the GDAX API reference that "Historical rates should not be polled frequently." Ah well.

There's also a bug in GDAX's get_product_historic_rates API for BCH-BTC and BCH-EUR pairs when using "granularity" 300. It is supposed to return UNIX timestamps in 300 timeslices, e.g. 1520003700, 1520004000, 1520004300, etc., but it doesn't, so the BCH-BTC and BCH-EUR plots aren't even drawn with the code above (index out of range error). I've already sent an email to Coinbase about that.

Anyway @pmaji maybe this is something that could be implemented by someone with better programming skills than me :D (if you consider it useful, that is) I even tried adding a 1hr change line, but usually it's overlayed on the current market price line and blocks the price text (even the 24h lines sometimes).

from crypto-whale-watching-app.

@mifunetoshiro I like the idea but in my opinion it´s not for the "Main" Purpose of this application.

We shouldn´t forget, we are a "Whale Watching App". Our purpose is to spot and highlight whale behaviour.

As @pmaji already declared: "Whale watching should be used aside to Trading charts like cryptowatch."

So in fact we give that information those platforms are lagging regarding whales.
And showing a line for 24/1 h History is in my opinion a nice feature but useless for hunting whales.

Besides, I´d like to keep further computation low, cause even those 12 Pairs in a scalable code produce quite some CPU load.

from crypto-whale-watching-app.

And showing a line for 24/1 h History is in my opinion a nice feature but useless for hunting whales.

Agree 100%, it's just that cryptowatch doesn't give me this info and I wanted it for myself, and was wondering how the bubbles moved from the price x hours ago.

from crypto-whale-watching-app.

@mifunetoshiro cryptowatch is giving the information, you can draw a line from yesterdays price.

Or look at https://coinmarketcap.com it gives you all you need:

from crypto-whale-watching-app.

@mifunetoshiro I understand the desire for the additional information, but @theimo1221 summarized my view well--we aren't trying to replicate info that people can get from other sources--we want to remain whale-focused. That said, it would also be computationally and visually difficult to add a sustainable 24 hour MP line. I'll give just one reason of many here.

When we calculate our price margins (i.e. how high and low the y-axis goes above/below market price, we do this based on a percentage calculation. So say our threshold is that the y axis spans $40 above and below market price, but yesterday the price was $100 lower than it is today. This would lead to a hidden line, or a forceably distorted axis.

tl;dr : it's a good idea, but a bit too computationally complicated, and not aligned with the main purpose of the app. Hope that makes sense.

from crypto-whale-watching-app.

This would lead to a hidden line

In fact plotly would try to draw all elements resulting in a different axis

from crypto-whale-watching-app.

you can draw a line from yesterdays price.

I haven't figured out how to draw a line that would show me the price and percentage difference on cryptowatch...

from crypto-whale-watching-app.

They have a button for drawing objects with all stuff like fibonnaci percentage lines curves and all other stuff

from crypto-whale-watching-app.

I know that, but I didn't figure out how to get what I wanted with any of those.

from crypto-whale-watching-app.

from crypto-whale-watching-app.

Yes, but it doesn't tell me the price and percentage change xD

Edit: I added Plotly menu buttons to show/reset 24h or 1h ago market price line, it doesn't skew the graph at all, and in case of a too big 24h change, the line is just hidden: mifunetoshiro@da862f0

from crypto-whale-watching-app.

Cryptonaut gives you price and percentage change for 24 hours week month and year

from crypto-whale-watching-app.

Even for your complete portfolio

from crypto-whale-watching-app.

@mifunetoshiro not what we are looking for, due to the fact we want it changeable by the user.
So changing it in Plotly would change it for all people visiting the site.

Ok, regarding the second and last bullet points: I think the current plot color (red/green) is the most appropriate. Every exchange lists buy/sell orders as green and red, and except for the colorblind option, I don't really see the need to have this user-configurable - I doubt a lot of people would change it. As for the current dark grey background, I think it'd be better if it was lighter @pmaji. Maybe the background could be user-configurable though, some like dark, some light.

from crypto-whale-watching-app.

Good ideas @mifunetoshiro ; I've gone with a lighter color for the plot background color. Still some contrast, but I think easier on the eyes.

from crypto-whale-watching-app.

These have both now been taken care of

from crypto-whale-watching-app.