Comments (9)
@theimo1221 FYI I added the comment "explanatory comment here to come" in a handful of places in the newest version of the app code that I just merged to Master. I went through and commented most of the sections that weren't explained, deleted some inactive code, etc. If you just command/find for "explanatory comment here to come" you'll see the few places where I could still use one sentence or so from you about the process.
from crypto-whale-watching-app.
Will take a look into it
from crypto-whale-watching-app.
I know recent change is not good commented, but it was a quite some code and a lot of changes due to limitations by plotly (e.g. no tooltip on lines)
from crypto-whale-watching-app.
No worries @theimo1221 . My goals right now are as follows:
- Make sure that this new update finally kills @CrackLord 's hosting refresh problem.
- Update all documentation (primarily the README) to reflect the new horizontal + vertical whale detection methodology -- this is something I'll work on tonight.
- Update all comments so that the entire codebase is well understood. (this is something we can do on and off over the next few days. We'll get to it whenever, but it is one of the next priorities.
from crypto-whale-watching-app.
Okay :)
You should consider putting link to top of readme.
from crypto-whale-watching-app.
Readme now updated with major edits. @theimo1221 feel free to give it a read whenever. I think it's now super clear.
from crypto-whale-watching-app.
#59 opens possibilities to improve this one by giving possibilitie to maybe add the content of readme via a spoiler.
from crypto-whale-watching-app.
Good deal. Presently I view priorities of this issue as being:
- thorough commenting of present code as it exists
- updated readme to reflect recent small changes we made to drop tooltip, etc. (I'll knock this one out soon)
- spoiler readme option
from crypto-whale-watching-app.
Alrighty. Took care of the licensing question which was the only outstanding hard-cutoff to-do in this thread. The other issue is one of continuous documentation (i.e. constantly commenting thoroughly so that everyone can understand what's going on). We still have a bit more work to do on that, but that is also a constant issue that will persist as long as the project is active, so it makes sense to closet this for now.
from crypto-whale-watching-app.
Related Issues (20)
- Adding OKEX info in separate version / integrated version HOT 1
- Is there a way to grab the results and store in Variable or print in console HOT 3
- Code on Plotly 3.0 stops working HOT 1
- Adding ETC HOT 2
- How to run HOT 1
- Help wanted with web hosting of app HOT 9
- Websocket empty? HOT 2
- Installation fails due to conflicting urllib3 version HOT 2
- app.py cannot work and got the error 'message': 'Failed to subscribe', 'reason': 'No channels provided' HOT 2
- error help HOT 1
- App doesn't work any more HOT 2
- Install erros - version conflicts HOT 3
- Crypto vs fiat HOT 1
- Does this still work?
- the code is nt update the data HOT 1
- Flask dependency error
- *-BTC pairs should be 5 decimals not 4 HOT 5
- noob issue, invalid syntax HOT 15
- Error: MacOS: Found existing installation six 1.4.1 HOT 2
- Time Stamping - Alt Coin Buzz HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from crypto-whale-watching-app.