pmndrs / meshline Goto Github PK

Hi. I'm trying to use line within threejs/react/drei canvas. After adding a texture I see that it scales based on distance between points (if the distance is short -- texture shriks and vise versa).

How can I preserve it's scale? Probably you can add an option to preserve the size? Theoretically it can be achieved by recreating UVs and

Using MeshLineGeometry with 2 points is broken as of 3.1.7, nothing is rendered.

e.g.

const geometry = new MeshLineGeometry()
const points = [
  0, 0, 0,
  1, 1, 1
]
geometry.setPoints(points)

So far I've narrowed the issue down a change in this commit: 3244cda

I can add a repro shortly, just figuring out what I can use other than codesandbox (they've added more limits for free users)

compare 3.2.0 https://codesandbox.io/p/sandbox/snowy-cdn-74l2v3
to 3.3.1 https://codesandbox.io/p/sandbox/zealous-chebyshev-8hj3fv

it appears that 3.3.0 is fine too

Using meshline with @types/[email protected] and with skipLibCheck set to false produces the following type error:

node_modules/meshline/dist/MeshLineMaterial.d.ts(39,5): error TS2610: 'alphaTest' is defined as an accessor in class 'ShaderMaterial', but is overridden here in 'MeshLineMaterial' as an instance property.

This is caused by @types/[email protected] correctly updating alphaTest to be a getter/setter in three-types/three-ts-types#856.

Not sure where v3.3.0 came from since it's not included in the repo, but v3.3.0 was the latest release version before the v3.2.1 from a few days ago according to npm:

Should the latest version be bumped to v3.3.1 to account for this?