pobega / gnome-shell-extension-mullvad-indicator Goto Github PK

The extension seems to work without issue on GNOME 42, just the new version number must be added.

Issue Description:

When the "Background Apps" section is shown, the Mullvad indicator is shown under it.

System information:

Fedora Workstation 38
GNOME 44.4

Extension version:

14

It should be possible to add a 'Connect/Disconnect' option in the dropdown.

for systemd:
systemctl {start,stop} wg-quick@*

for cli:
https://mullvad.net/en/help/how-use-mullvad-cli/
mullvad connect and mullvad disconnect

for app:
Should be good enough to launch the MullvadVPN GUI application and let the user handle it from there.

An option should be added to the settings for enabling this feature (on by default) and setting which method they use to connect (app by default)

There are breaking changes which will require a separate release for 45 and <=44:

See https://gjs.guide/extensions/upgrading/gnome-shell-45.html

Could you add support for GNOME 40? The preferences no longer open:

Gtk.BuilderError: /usr/share/gnome-shell/extensions/[email protected]/prefs.ui:25:1 Unhandled tag: <packing>

Stack trace:
  buildWidget@/usr/share/gnome-shell/extensions/[email protected]/prefs.js:18:23
  buildPrefsWidget@/usr/share/gnome-shell/extensions/[email protected]/prefs.js:56:24
  _init@resource:///org/gnome/Shell/Extensions/js/extensionsService.js:209:40
  OpenExtensionPrefsAsync/<@resource:///org/gnome/Shell/Extensions/js/extensionsService.js:122:28
  asyncCallback@resource:///org/gnome/gjs/modules/core/overrides/Gio.js:132:22
  run@resource:///org/gnome/Shell/Extensions/js/dbusService.js:177:20
  main@resource:///org/gnome/Shell/Extensions/js/main.js:19:13
  run@resource:///org/gnome/gjs/modules/script/package.js:222:19
  start@resource:///org/gnome/gjs/modules/script/package.js:206:8
  @/usr/share/gnome-shell/org.gnome.Shell.Extensions:1:17

Feature Description:

Your extension basically duplicates the existing Ubuntu drop down menu and if the mullvad icon is added to the top bar, that becomes clear. The Mullvad info is yet another click away. A dedicated drop down showing the Mullvad connection information from the top bar, without all the shutdown/network/etc duplication would be more usable. Wouldn't that be easier for you to do? You can do better than I can, but in my mind, one click is better than two. Otherwise good job, it works.

Following the example of the other indicators in this menu (e.g. WiFi and bluetooth indicators which displays the device name), I would like to see the name of the server I'm connected to instead of "Connected".

What do you think? Thanks

Feature Description:

Please update the extension for Gnome 43.

Thank you!

I submitted the Gnome 45 update (thanks again @no-comma) but got some feedback from the reviewer.

I'm planning to address this when I have time (seems simple enough) but I'm throwing it here in case anyone else has a chance to get to it before me.

Please make the settings local to `fillPreferencesWindow` (line 11 prefs.js).
You can store the settings in `window._settings` to avoid garbage collection before window close.

This was the only response from the reviewer so it seems like once this is resolved the e.g.o. extension can be updated.

Issue Description:

Open panel containing the mullvad icon, attempt to click settings. Settings cannot be opened. See error below

The settings of extension [email protected] had an error:

GLib.FileError: Failed to open file “prefs.ui”: No such file or directory

Stack trace:

buildWidget@/home/coleg/.local/share/gnome-shell/extensions/[email protected]/prefs.js:16:23
buildPrefsWidget@/home/coleg/.local/share/gnome-shell/extensions/[email protected]/prefs.js:54:24
_init@resource:///org/gnome/Shell/Extensions/js/extensionsService.js:207:40
OpenExtensionPrefsAsync/<@resource:///org/gnome/Shell/Extensions/js/extensionsService.js:122:28
asyncCallback@resource:///org/gnome/gjs/modules/core/overrides/Gio.js:132:13
run@resource:///org/gnome/Shell/Extensions/js/dbusService.js:175:20
main@resource:///org/gnome/Shell/Extensions/js/main.js:19:13
run@resource:///org/gnome/gjs/modules/script/package.js:222:19
start@resource:///org/gnome/gjs/modules/script/package.js:206:5
@/usr/share/gnome-shell/org.gnome.Shell.Extensions:1:17

System information:

Gnome 3.36

Extension version:

Latest from extensions.gnome.org

Fixes an issue where the dropdown menu would close itself if it's refreshed while the user has it open

Issue Description:

Both on a machine running F35 and a machine running F36, the indicator cannot detect a connection at all. Whether the GUI is open or closed, whether connected or disconnected, the indicator is dark despite any attempts to refresh. All Mullvad Indicator options are the defaults (on).
I also tried disabling every other extension, in case there could be a conflict, and the issue continues to persist.

System information:

F35 machine is an install that I've had for some months, and the F36 machine is an install that I set up just a couple of days ago. On at least the F36 machine, I do not have any other DEs installed.

Distro: Fedora Linux 36 (and 35) Workstation Edition
GNOME Version: 42.4 (and 41.6)
Mullvad app version: 2022.4

Extension version:

Version 5, on both machines. Installed from extensions.gnome.org.

Mullvad Indicator v2 installed from GNOME Extensions
GNOME 3.36.6
Manjaro Linux

I receive this error when attempting to open the extension settings:

The settings of extension [email protected] had an error:

GLib.FileError: Failed to open file “prefs.ui”: No such file or directory

Stack trace:

buildWidget@/home/yochanan/.local/share/gnome-shell/extensions/[email protected]/prefs.js:16:23
buildPrefsWidget@/home/yochanan/.local/share/gnome-shell/extensions/[email protected]/prefs.js:54:24
_init@resource:///org/gnome/Shell/Extensions/js/extensionsService.js:207:40
OpenExtensionPrefsAsync/<@resource:///org/gnome/Shell/Extensions/js/extensionsService.js:122:28
asyncCallback@resource:///org/gnome/gjs/modules/core/overrides/Gio.js:132:13
run@resource:///org/gnome/Shell/Extensions/js/dbusService.js:175:20
main@resource:///org/gnome/Shell/Extensions/js/main.js:19:13
run@resource:///org/gnome/gjs/modules/script/package.js:222:19
start@resource:///org/gnome/gjs/modules/script/package.js:206:5
@/usr/share/gnome-shell/org.gnome.Shell.Extensions:1:17

Issue Description:

When losing access to a WiFi AP by the AP going down Mullvad Indicator seems to not pick up the state changed event. It's possible that the event is not generated and we have to switch back to using dbus directly rather than GNetworkMonitor

Extension version:

• v1, v2