Giter VIP home page Giter VIP logo

podigee-podcast-player's People

Contributors

benzimmer avatar dependabot[bot] avatar dritsher avatar fischaela avatar gholzmann avatar jacaa avatar joeybuddenberg avatar kacpermigala avatar marcelgo avatar smehrbrodt avatar spiderpug avatar sprestel avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

podigee-podcast-player's Issues

Theming documentation

The readme says I can customize the look of the player. Where can I find any documentation on how to do that?

Timecodes don't match, seems to play past end of file

I'm using the Podigee player on my site, and it looks good, but when playing the first episode, the timestamps from the chaptermarks don't match the content they did when I played the file in VLC and in Audacity.

On top of that, when it reaches the end of the file it reaches the final timecode (03:26:34) before the file is actually at the end and stops counting seconds (because it's at 03:26:34/-00:00:00) but still plays the end of the file!

The file is Joint Stereo mp3, VBR level 6 (ended up at 89kbit/s) at 44.1khz.

Embedded player shows spinner forever

A player embedded via

<script class="podigee-podcast-player" data-configuration="playerConfiguration" src="https://cdn.podigee.com/podcast-player/javascripts/podigee-podcast-player.js">
</script>

Resolves itself to
https://cdn.podigee.com/podcast-player/podigee-podcast-player.html?id=3e73806b&iframeMode=script
which shows right now a spinner like icon forever.

Are there any issues with the cdn?

Any chance of using versioning and make some releases

I am trying to debug why my Podigee player stopped working on my website http://historie.vih.dk/podcasts/2017-09-19-thomassen-erindringer/ (it used to work, but stopped for some reason), and I noticed that you have not made any releases / version, so basically I am just using the latest code. I would be very helpful if it was possible to reference a certain release in the code, so it is easier to debug where the problem is - whether it is my own code, how I use Podigee or Podigee itself.

Build output shows only the Animation, Nothing else.

Hi,
I just installed npm, yarn, gulp in my machine. build has been done on the open source package using 'gulp build'. When i launch the output package nothing happens in the page, but only the loading animation appears. Please find the attached screenshot. Also I don't find any errors in the console. Not sure what basic procedure I miss here. Please guide me on this. Also, It would be great if you could provide a sample output package so that i can refer the output.
gulpoutput
gulp_output (1).zip

Fallback to default theme not working

Without

options: %{
  theme: "default"
}

in the config, there is following error:

Uncaught TypeError: Cannot read property 'theme' of undefined
    at t.t (podigee-podcast-player.html?id=2386ee0b&iframeMode=script:244)
    at t.t (podigee-podcast-player.html?id=2386ee0b&iframeMode=script:244)
    at t.themeConfig (podigee-podcast-player.html?id=2386ee0b&iframeMode=script:244)
    at t.themeConfig (podigee-podcast-player.html?id=2386ee0b&iframeMode=script:244)
    at t.context (podigee-podcast-player.html?id=2386ee0b&iframeMode=script:244)
    at t.context (podigee-podcast-player.html?id=2386ee0b&iframeMode=script:244)
    at t.render (podigee-podcast-player.html?id=2386ee0b&iframeMode=script:244)
    at t.render (podigee-podcast-player.html?id=2386ee0b&iframeMode=script:244)
    at Object.<anonymous> (podigee-podcast-player.html?id=2386ee0b&iframeMode=script:242)
    at c (podigee-podcast-player.html?id=2386ee0b&iframeMode=script:235)
```

Find alternative to peaks.js to re-enable waveform rendering

Integrating peaks.js has several smaller and one big disadvantage:

Small

  • it's huge
  • it does/can do much more than is needed in this context

Big

  • when rendering many players on the same page it exhausts the number of possible AudioContext which leads to JS errors and the player not being loaded at all

I opened an issue at the waveform-data.js project to get some ideas: bbc/waveform-data.js#34

Readme gulp build process is incorrect

The Readme says to run gulp build in order to get the Production Assets. Instead it should say run gulp or a gulp build task should be added to the gulpfile.js.

Control player from outside the iframe

Hi there,

I want to trigger events inside the player after it has been loaded. For example trigger it to play. Is there an API to interact with the player through the embed code?

Thanks,
Johannes

locale error

Hello - I have been using this player on my own web site for a while. At some point in the last four weeks or so, the player quit working. When I look in Chrome devtools I see this error

Uncaught TypeError: Cannot read property 'locale' of undefined
    at t.setConfigurations (podigee-podcast-player.html?id=d3862fc&iframeMode=script:242)

The animation starts but the player/file doesn't load. The mp3 and config json are hosted on a google storage bucket, CORS is enable and working, so no errors there. The player was working great for all of 2017. If there is a config issue I'd be interested in a bit of help.

Extract additional information from playlist feed

When browsing through the back catalog of a podcast through the feed playlist it would be useful to also extract the following information from the feed:

  • Chaptermarks (Podlove Simple Chapters)
  • Additional audio formats (from alternate feeds)
  • Transcript information (there is no official way currently to embed this into a feed)

Inline configuration only works for root variables

I'm trying to implement this player as a Drupal module for audio file. I am also planning to contribute to the community :)

To pass the configuration to the player I am trying to use the following code

<script class="podigee-podcast-player" src="https://cdn.podigee.com/podcast-player/javascripts/podigee-podcast-player.js" data-configuration="drupalSettings.podigee.playerConfiguration"></script>

But it fails because it tries to get

window['drupalSettings.podigee.playerConfiguration']

I researched a bit and I found this thread
https://stackoverflow.com/questions/6491463/accessing-nested-javascript-objects-with-string-key

Apparently it can be done with Lodash so I opened the following pull request
#58

Set initial progress & listen to playback events

Is it possible to set an initial offset/progress for an episode. This would be very useful for resuming playback when it is known that the user has already listened to the first 15 minutes, or you manually want to start an episode at a specific point.

Secondly. Is it possible to hook up a callback function to various events like play/pause/finished etc.

CORS problem when using an external audio file with embedded player

The embedable player shows a red "!" if a file should be played, which is hosted on a different domain and CORS is disabled.
In Chrome DevTools, also no Javascript Error can be seen - this makes the problem quite difficult to debug (if one doesn't know that's a CORS issue).

It would be great if a meaningful error message could be displayed to the user (in the player), with an explanation that CORS should be enabled (see for example http://docs.videojs.com/docs/guides/tracks.html#subtitles-from-another-domain).

For example, try to play any file hosted by libsyn:
https://auphonic.com/media/share/tr/podigee-cors.html
Using the folloging player configuration:
playerConfiguration = { "options": { "theme": "default", }, "episode": { "media": { "mp3": "https://traffic.libsyn.com/dancarlin/cswdcd09.mp3", }, "title": "Podigee CORS Test", } }

Rendering Bugs on iOS Safari

Rendering Bugs on iOS Safari. This only happens in Safari on small screens. Do you know why?

img_2698
img_2695

PS: If you want you can checkout podperlen.de to test. However please do not spread the word yet. It is still not public and in development.

Logo im Desktopbrowser riesig

Ich setze den Podigee Player auf podperlen.de ein.

Allerdings stört es mich ein wenig, dass das Logo im Desktopbrowser so groß angezeigt wird:

screen shot 2016-02-15 at 21 33 23

Ist das so gedacht? Oder macht da mein CSS irgendwas kaputt?

Trouble with multiple players on a page

Hi all, I'm trying to integrate your (excellent) player onto my Wordpress site. I have successfully embedded it with the following code:
<script> window.playerConfiguration = { "options": { "theme": "default" }, "extensions": { "SubscribeBar": {disabled: true}, "Playlist": {disabled: true} }, "podcast": { "title": "Podtrificus Totalus", "feed": "https://podtrificustotalus.com/feed/podcast/", }, "episode": { "media": { "mp3": "' . $atts['mp3'] . '" }, "coverUrl": "https://podtrificustotalus.com/wp-content/uploads/2017/06/101-The-Boy-Who-Lived-mp3-image.png", "title": "' . $atts['title'] . '", "url": "' . $atts['[page]'] . '" } } </script> <script class="podigee-podcast-player" src="http://podtrificustotalus.com/wp-content/themes/tm-beans-child-2018/podigee/javascripts/podigee-podcast-player.js" data-configuration="playerConfiguration"></script>
The MP3 link, title, and URL are all using Wordpress shortcode attributes so that I can configure the player easily on a per-post basis. I believe this is called an inline configuration, rather than passing it off to an external .json configuration file (sorry, I don't know JS well!).

The player appears and plays just fine on an individual post: https://podtrificustotalus.com/1-08-potions-master/

However, on the main index of my site, the last three posts appear in full, and thus three instances of the player appear. The files play correctly, but the Download button has trouble. You can see it live here: https://podtrificustotalus.com/

I've also created a gif that should display the problem.

podigeedownload

Aside from my theming (minor CSS edits) and Wordpress shortcode, everything else is pretty much standard. I'm fully willing to believe this is a problem in my integration of the player, but some guidance would be appreciated. Thanks!

Cover Image does not load

I am trying to use a cover image with my current episode, as well as with the playlist:

  "episode": {
    "url" : "http://omegataupodcast.net/275-technikfolgenabschatzung/", 
    "title" : "275 – Technikfolgenabschätzung", 
    "media" : { "mp3" :"http://traffic.libsyn.com/omegataupodcast/omegatau-275-technologiefolgenabschaetzung.mp3",  
    "coverUrl": "http://omegataupodcast.net/wp-content/themes/img/omegatau_600x600"  }
  }

However, it does not work, no image shows up.

  • Do I have to enable an option for it to show?
  • are the size requirements for the image?
  • anything else I can do to help diagnose the problem?

Cannot render fonts when using build

I've been building the project then pushing the created artifacts (everything inside build/) to S3.
When accessing /podigee-podcast-file.html and using the configuration query parameter (or for that matter using the script tag embed), the player renders and functions correctly.
However the icon fonts are not loading correctly. See screenshot:

screen shot 2018-09-11 at 14 09 52

Multiple Episodes Not Supported?

Does this player no longer support multiple episodes?

I remember you used to be able to specify a list of episodes in the config like:

window.playerConfig = {
    "podcast": {
        "episodes": [
            ...
        ]
    }
}

But that doesn't seem to work anymore.

Share episode URL with timecode

I would like to reopen #5 ;-)

It drove me nuts to see, that this works with your demo, but it 'didn't work for me'. So I dug into this and found out, that it works with the player hosted on github:
https://podigee.github.io/podigee-podcast-player/build/javascripts/podigee-podcast-player.js
but it doesn't work with the one mentioned in the docs:
https://cdn.podigee.com/podcast-player/javascripts/podigee-podcast-player.js

Maybe it's still an older version there?
Merry Christmas from Vienna and congrats for your great player 🥇

Playlist - times show up as NaN

I can see that my player durations are all correct in my podcast feed xml (they are in seconds in the field.

Other podcast players parse the duration fine, but it shows up as NaN - I ended up just commenting out the duration, but it would be nice to have a real fix.

Configuration example from README does not work

I just tried to embed the player with the example provided in the readme using a local configuration. I added this playerConfiguration to the end of my page:

    <script>
        window.playerConfiguration = {
          "options": {
            "theme": "default",
            "sslProxy": "https://example.com/ssl-proxy/",
            "startPanel": "Playlist"
          },
          "extensions": {
            "EpisodeInfo": {},
            "Playlist": {
              "disabled": true
            }
          },
          "podcast": {
            "feed": "https://cdn.podigee.com/ppp/samples/feed.xml",
          },
          "episode": {
            "media": {
              "mp3": "https://cdn.podigee.com/ppp/samples/media.mp3"
            },
            "coverUrl": "https://cdn.podigee.com/ppp/samples/cover.jpg",
            "title": "FG009 Wirtschaftspolitischer Journalismus",
            "subtitle": "Wie Henrik Müller in Dortmund wirtschaftspolitischen Journalismus lehrt und erforscht. Und was guten Wirtschaftsjournalismus ausmacht.",
            "url": "http://forschergeist.de/podcast/fg009-wirtschaftspolitischer-journalismus/",
            "embedCode": "<script class=\"podigee-podcast-player\" src=\"https://cdn.podigee.com/podcast-player/javascripts/podigee-podcast-player.js\" data-configuration=\"https://podigee.github.io/podigee-podcast-player/example/config.json\"><\/script>",
            "description": "Raus aus der prallen journalistischen Praxis, rein in die Gremien-Universität. Henrik Müller hat diesen ungewöhnlichen Schritt gewagt: 2013 übernahm der damalige stellvertretende Chefredakteur des "manager magazin" den Lehrstuhl für wirtschaftspolitischen Journalismus am Institut für Journalistik der Technischen Universität Dortmund. Dort baut er seitdem die neuen Bachelor- und Master-Studiengänge für wirtschaftspolitischen Journalismus auf. Wie er diesen Wechsel zwischen den  Welten erlebt hat, was er seinen Studierenden vermitteln will und woran er forscht, erzählt der immer noch sehr umtriebige Autor ("Wirtschaftsirrtümer: 50 Denkfehler, die uns Kopf und Kragen kosten") und Spiegel-Online-Kolumnist in dieser anregenden Episode. Dabei geht es darum, was Wirtschaftsjournalismus leisten soll und muss, was Studierende erst mühsam über Lobbyismus lernen müssen und was eigentlich "gute Geschichten" sind."
          }
        }
    </script>

This is how I embed the player:

<script class="podigee-podcast-player" src="https://cdn.podigee.com/podcast-player/javascripts/podigee-podcast-player.js" data-configuration="playerConfiguration"></script>

I see this error in my log:

GET https://cdn.podigee.com/podcast-player/playerConfiguration 403 ()

Looks like the player does not even consider the local option any more?

Request: Make text scrolling (marquee effect)

The Podigee Podcast Player offers limited amout of space for text. This leads to subtitles being cut off. This problem gets worse on small mobile devices.
I'd really like subtitles (and maybe even titles) to scroll from right to left (marquee effect).

Transcript Parts and Search Results not visible on smaller screens

I use the player with a WebVTT transcript.
If the screen gets smaller (e.g. width = 500px), one cannot see the whole transcript anymore, because the scrolling goes below the end of the player.
If one searches within the transcript, it is not possible to see lots of search results, because the scrolling position seems wrong.

(Tested on recent Chrome+Firefox on linux)

Example to reproduce the problem:

Just feedback

Hi guys,

I am the guy who talked to Ben in Munich about using your player in Panoptikum: https://alpha.panoptikum.io/

I now embedded it, short feedback: Just works and awesome documentation.

Keep up the good work!

Disable Playlist extension

I want to use the player to play just one single audio file. How can I disable the playlist extension?

Player does not show play button on mobile browsers

On mobile browsers (tested in iOS Safari and Android), the big play button always shows the loading animation instead of the play icon (see screenshot below).
However, if one clicks on the play button (which still shows the animation), the playback starts as it should. Afterwards it's possible to see the play/pause button.

On desktop browsers everything works as it should.

Tested with the following example:
https://auphonic.com/media/share/tr/podigee-cors.html
Player Configuration:
window.playerConfiguration = { "options": { "theme": "default" }, "episode": { "media": { "mp3": "https://traffic.libsyn.com/dancarlin/cswdcd09.mp3" }, "title": "Podigee CORS Test" } }

Screenshot:
datei 25 11 16 09 37 01

Accessibility Labels

Cool player.
Can you add the following attributes to the buttons of your player, please.

aria-label="<button-name>"

<button class="play-button" aria-label="Play"></button>

<button class="download-button" title="Download episode" aria-label="Download episode"></button>

<button class="episode-info-button" title="Show more info" aria-label="Show more info"></button>

<button class="share-button" title="Share episode URL" aria-label="Share episode URL"></button>

Thanx

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.