polarisation / vue-computed-promise Goto Github PK

🚨 You need to enable Continuous Integration on all branches of this repository. 🚨

To enable Greenkeeper, you need to make sure that a commit status is reported on all branches. This is required by Greenkeeper because it uses your CI build statuses to figure out when to notify you about breaking changes.

Since we didn’t receive a CI status on the greenkeeper/initial branch, it’s possible that you don’t have CI set up yet. We recommend using Travis CI, but Greenkeeper will work with every other CI service as well.

If you have already set up a CI for this repository, you might need to check how it’s configured. Make sure it is set to run on all new branches. If you don’t want it to run on absolutely every branch, you can whitelist branches starting with greenkeeper/.

Once you have installed and configured CI on this repository correctly, you’ll need to re-trigger Greenkeeper’s initial pull request. To do this, please delete the greenkeeper/initial branch in this repository, and then remove and re-add this repository to the Greenkeeper App’s white list on Github. You'll find this list on your repo or organization’s settings page, under Installed GitHub Apps.

vue-computed-promise has solved one of my problems (needing a computed prop which depends on a firebase promise resolving), but it has broken something in the process. This code used to work:

computed: {
  pageName () {
    return this.loading ? null : this.__page(this.$route.params.page).name
  }
  ...mapGetters({
    loading: 'loading',
    __page: 'page'
  })
}

but now throws an error:

Error in render function: "Error: VueComputedPromise: __page function returned must return a Promise"

loading and __page are both synchronous getters defined in my Vuex store, but it looks like something about them is fooling vue-computed-promise to convert them to async?

Hi - I'm using Quasar, and found that vue-computed-promise broke the QDatetime component from that library. It's not trivial to post code here since Quasar is pretty big. But I suspect the 'test' for which props to transform (which was picking up my getter function in the other issue) is also picking up some of the Quasar component functions and changing them. For that reason, I went back to vue-async-computed, but now have the 'lazy' problem I just posted to there.

If you can install Quasar, I can give you a simple test case which should show the problem?