How to disable currentTerrariaVersion in config？It cause some problem when some plugins check player version. about dimensions HOT 8 CLOSED

The "加入了多人运动" means "have joined" . "正在连接" means “Connecting”

from dimensions.

The currentTerrariaVersion is used when switching for all players. Are you saying you want to use the client version instead?

from dimensions.

Yes

from dimensions.

Option 1 (Extension):
You could create an extension to read and force the client's own version in the connect request packets (similar to MCL in a way), e.g. https://github.com/popstarfreas/dimensions-mcl/blob/6fdfeaa01a665c7c04d93f14bdf34e53317dc481/app/priorclienthandler.ts#L44-L62 is where MCL for 1412 and above rewrites to 1.4.1.1, which could be changed to store the version of the client and then force it for every new connect request sent by the same client.

Option 2 (Dimensions):
Where currentTerrariaVersion is used:
https://github.com/popstarfreas/Dimensions/blob/dev/app/node_modules/dimensions/client.ts#L445-L449

You can replace it with the client version, but you also need to obtain that information which dimensions does not currently, but you could add it: https://github.com/popstarfreas/Dimensions/blob/dev/app/node_modules/dimensions/clientpackethandler.ts#L49-L66 in there is where client packets are parsed, you can just add one for connect request and store the version in the client object.

If you go for option 2, it might be worth making a PR for it so that the config option is not necessary anymore. Of course if you are not a programmer than possibly I can do option 2 myself at some point.

from dimensions.

OK,I will have a try.Thank you for you answer.

from dimensions.

I seem to have failed.I don't know how to add one for connect request.

from dimensions.

I think that I must fix it as soon as possible because players on my server is a little angry.Could you help me do option 2?

from dimensions.

I'll see what I can do.

from dimensions.