shouldnt haev been part of the mocks, ignore actions, keep transactions, keep cancel for my orders

y & x axis starts from 0 go to 1

low p

NEW: https://www.figma.com/file/ddShWxG1yufVKYFTvJHgci/Product?node-id=8586%3A650
Old: https://www.figma.com/file/55kihuNidQlR8YReCTJlPY/Product-(Jordan)?node-id=8586%3A650

This page gets its info from the gnosis auction api

• Add page as designed
• Handle private auctions https://ido-ux.dev.gnosisdev.com/#/auction?auctionId=501&chainId=4#topAnchor. Gnosis has the ability to create auctions either public or private. They already have the functionality for this built into their UI. We will need to disable the bidding panel if the connected address is not on the allow-list. There does not currently seem to be a component for this in the vectordao designs. Should we build our own, or ask them to make one? @jordanalexandermeyer

• handle max supply similar to https://matcha.xyz/markets/1/0xc02aaa39b223fe8d0a0e5c4f27ead9083c756cc2/0xeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee show current balance of the BOND token next to max, clicking max should populate the input with total number of bond tokens the user has
  
• Show a preview of how many collateral tokens the selected number of bond tokens will convert into
• Show a preview of how many payment tokens and collateral tokens the selected number of bond tokens will convert into

In the future - the input boxes will probably be disabled as well if the buttons are disabled

Originally posted by @RusseII in #17 (comment)

What data interval should be used to display the data on this graph?

• Approves the auctioningToken to be withdrawn from the users wallet
• Allows the user to create an auction using the initateAuction method on gnosis auction
• Hook subgraph into forms to grab tokens & bonds #439
• Hook usdc value & current token balance into form #439

https://github.com/porter-finance/product/tree/main/spec/pages/offering_creation_page

https://github.com/porter-finance/v1-core/blob/074da4fc9a6f3e85092489544df2993fee4fd4f3/contracts/Bond.sol#L583 you could call the isMature method, but I think leaving it like this is fine (i don't recommend changing it now)

Originally posted by @RusseII in #26 (comment)

https://github.com/porter-finance/product/tree/main/spec/pages/product_page/convert

Here's one of the bond contracts that you can interact with. The 0xfab4AF4EA2EB609868cDb4f744155d67f0A5BF41 address should have bonds. You can import 0x6bca2d242318e74f337d8831424363c880d24e2d token into metamask if you so wish.

• #10
• #12
• #13
• #14
• #11

https://github.com/porter-finance/frontend-ido/blob/3e952cc8774e3527982d5821695b0792b31fb7db/src/hooks/useBondDetails.ts#L8-L23

Apollo client has a native way for passing in variables that helps with caching - https://www.apollographql.com/docs/react/data/queries#caching-query-results

So for example, instead it should be

 const bondsQuery = gql` 
   query Bond { 
     bond(id: $bondID) { 
       id 
       name 
       symbol 
       owner 
       maturityDate 
       paymentToken 
       collateralToken 
       collateralRatio 
       convertibleRatio 
       isAuction 
     } 
   } 
   
  const { loading, error, data } = useQuery(bondsQuery, {
    variables: { bondID },
  });

https://www.figma.com/file/55kihuNidQlR8YReCTJlPY/Product-(Jordan)?node-id=8586%3A650

(Above images are likely out of date - please refer to the figma)

• Add designs for Simple Bonds
• Add designs for Convert Bonds
• #37
• #38

A bond is simple if the graphql convertibileRatio is 0. If it is any other value then the bond is a Convert Bond.

I don't see where this is being used in the PR but seems like this could be moved outside of the render with useMemo removed

Originally posted by @RusseII in #50 (comment)

@jordanalexandermeyer what are your thoughts on having a select for the payment token and restricting it to the following tokens for now: USDC DAI or FEI

Interest rate and price are going to be tricky to get. Gnosis doesn't emit any events to easily get this data. We could grab it from their API or calculate it and index it with the graph

yeah its weird. its really just behaving like its loading, becaues the orderbookerror component shows spinner if theres no error.message.

it was leftover ido ux logic, ill remove it in future issue

Originally posted by @luckyrobot in #50 (comment)

amount column in portfolio? how to get this. from gql, do i have to aggregate the bids and collect their full size for each bond?

Hmm, that's a good question. The portfolio page should show the porter bonds that the currently connected user has, and the amount should be the quantity for each bond. I don't believe this data is currently easily fetch-able via graphql but it should be. Use a dummy value for now, I'll create an issue to make this data available via graphql

Originally posted by @RusseII in #69 (comment)

https://github.com/porter-finance/product/tree/main/spec/pages/portfolio_page

• fetch all bonds in a users wallet along with metadata about them and display them in a list. This should be very similar to the product page, but just filtered on things the user has in their wallet.

This page shows all of the current bonds that exist and the info about them. Very similar to #31

• Add page as designed

https://github.com/porter-finance/product/tree/main/spec/pages/product_discovery_page

• Fetch all porter bonds and display them in a list. Clicking on a porter bond should open the product page for that bond

its disabled inr eact router if its current page

be able to click on links inside tooltips

its a type i saw ido ux using a lot. i think all maybes can be cahnged to maturityDate?: number instead though

declare type Maybe<T> = T | null

Originally posted by @luckyrobot in #50 (comment)

• bids should have filler
• keep new order line
• dont start sell supply line from 0
• #63
• remove am chart logo
• minimum funding threshold missing
• bug when adding amount & same price, graph dont update
• chart seems innacurate , not hovering on right corners with right data? (need more info, can you check to reproduce @jordanalexandermeyer on the new pr preview) #53
• interest rate in hover
• #62

const apolloClient = new ApolloClient({
  uri: SUBGRAPH_URL_RINKEBY, # <---
  connectToDevTools: true,
  cache: new InMemoryCache(),
})

https://github.com/porter-finance/subgraph/issues/14

Most of our users are DAOs that use gnosis safe.

Priority

This could be in the next flight. We probably do not need this at launch, but it is a good functional story to work on if blocked by designs

AC

• look into if it makes sense for us to integrate with gnosis safe directly
• integrate with it

More context

https://canary.discord.com/channels/903094151002857492/919775951523557456/951273692770471936

Example of how gnosis initiates an auction

https://github.com/gnosis/ido-starter

Use permit method for supported paymentTokens and collateralTokens

Investigate checking if the token being used as collateral or payment could use .permit instead of .pay to reduce on gas costs.

@Namaskar-1F64F this would be a follow up of the subgraph update that you did the other day.

There has been even more changes to our subgraph so the ABIs and handlers will need updated again. We should also move to the new version on our frontend.

We may want to wait until after Peteris does a code review before doing this...

• Update subgraph
• (follow up) Work with lucky to figure out what data he needs that's missing from the subgraph and make it available. Example of one such issue #72

Look into using token lists when choosing which token to use as the repayment token and as the collateral token.

https://tokenlists.org/token-list?url=https://tokens.uniswap.org

https://uniswap.org/blog/token-lists

Uniswap allows selecting from multiple token lists https://app.uniswap.org/#/swap?chain=mainnet

I think we should use uniswaps subgraph for price data.

https://thegraph.com/hosted-service/subgraph/ianlapham/uniswap-v3-subgraph?selected=playground

Example Query:

// tokenID is the collateral token 
{
  token(id: "0x7fc66500c84a76ad7e9c93437bfc5ac33e2ddae9") {
 derivedETH
  }
  bundles(first: 5) {
    id
    ethPriceUSD
  }
}

Then the price per collateral token will be derivedEth * ethPriceUSD

I'm not sure the best way that we can test this since our testnet tokens won't have any value.

Thoughts and removing this from the bond file and encapsulating the state in the hook itself? Then doing the format wherever the value is being displayed?

So instead of:

const previewConvert = useCallback(
    async (amountToPreview?: TokenAmount | null): Promise<string> => {
      if (!tokenContract) {
        logger.error('tokenContract is null')
        return ''
      }

      if (!amountToPreview) {
        logger.error('missing amount to preview')
        return ''
      }

      const response = await tokenContract
        .previewConvertBeforeMaturity(amountToPreview.raw.toString())
        .catch((error: Error) => {
          logger.debug('Failed to preview token', error)
          throw error
        })

      return response
    },
    [tokenContract],
  )

Something like

  const usePreviewConvert = async (amountToPreview?: TokenAmount | null, bondAddress: string): Promise<string> => {
    const tokenContract = useBondContract(bondAddress)

    const [amount, setAmount] = useState(null)
    if (!tokenContract) {
      logger.error('tokenContract is null')
    }
    useEffect(() => {
      const previewConvert = async () => {
        const number = await tokenContract
          .previewConvertBeforeMaturity(amountToPreview.raw.toString())
          .catch((error: Error) => {
            logger.debug('Failed to preview token', error)
            throw error
          })
        setAmount(number)

      }

      previewConvert()
    }, [amountToPreview, tokenContract])

    return amount 

  )
}

We could also leave cleanup tasks like this to later if you think that makes sense

Originally posted by @RusseII in #24 (comment)

not auction start & end

Some optimizations/additions we could focus on from the frontend side after finishing our V1 frontend.

• Upgrade tooling (nextjs?)
• Frontend testing
• Add verified and unverified bonds
• Add geolocation
• Add way to sell bonds OTC
• Integrate with 3rd party protocol like prime.xzy to fetch more risk information about the bonds
• Multiple collateral
• Better support for fractionalized NFTs
• Add additional ways to sell bonds
• Preloading

This page shows a list of all of the current offers. An offering can be a Gnosis Auction or an Over the Counter (OTC) offering using something like airswap. Ignore OTC for now and only fetch/show the list of Auctions.

• #34
• @luckyrobot add page as designed

Get the images displayed from the collateralToken being used. Gnosis has code that handles getting an image from an address - https://github.com/porter-finance/frontend-ido/blob/5a532365c6d09689538c889e7fbfb5bbb3866f37/src/components/token/TokenLogo/index.tsx

Auctions/Products/Portfolio lists should probably all use the same table component

https://www.figma.com/file/55kihuNidQlR8YReCTJlPY/Product-(Jordan)?node-id=8586%3A650

All of the data on this page should be grabbed from graphql.

• #35
• @luckyrobot add designs as outlined in figma

converted this to an issue so we can get rid of that giant giant PR before stacking more features to it

http://localhost:3000/auctions/505/4