praveenelango / ped Goto Github PK

sell stock with negative quantity registers error in total profit/loss in view

When sell command is used with negative quantity as seen in bug issue #2, the program incorrectly records it the same way as the buy command. This can be seen in above screenshot where sell /aapl -1' incremented the number of aaplstocks from4to5when theviewcommand was called. Due to this incorrect method of updating the stock count, theTotal Profit/Losssection in theviewcommand registers anerror!` instead of a value as expected in the User Guide.

sell Command is accepting negative integers as input

As per the user guide, the quantity specified by the user to sell the stocks is an integer (as seen in sell /STOCK_TICKER quantity). However, when a negative integer is being provided as input to quantity as seen in the above screenshot (sell /tsla -1), the user is still able to sell the stock as though the quantity provided by the user as input is 1 and not -1, where an error should be returned for the latter case.

As seen in the above screenshot, information such as the following is being displayed when . a command is called:

Oct 30, 2020 5:27:00 PM seedu.duke.parser.Parser parseCommand
INFO: going to start processing command

Such information is not relevant to the user and the developers can consider removing them.

Failed to fetch price from API in buy command

The buy command when used correctly as specified in the user guide returned a failure to fetch price of stock from API as seen in the above screenshot for buy /aapl 2. It was only when the user input the same command with same input arguments again that the program worked as specified.

Details returned by mark command not shown as per UG

In .jar file

In UG

The details being returned by the mark command in the program as per the .jar file is not accurately reflected in the User Guide as seen in the aforementioned screenshots. This is done for other commands such as buy, sell, etc. and in order to maintain consistency in documentation, it should also be done for this mark command.

In .jar file

In UG

The details being returned by the bookmarks command in the program as per the .jar file is not accurately reflected in the User Guide as seen in the aforementioned screenshots. This is done for other commands such as buy, sell, etc. and in order to maintain consistency in documentation, it should also be done for this bookmarks command.

Details returned by search command not specified in User Guide

In .jar file

In User Guide

The details being returned by the search command in the program as per the .jar file is not accurately reflected in the User Guide as seen in the aforementioned screenshots. This is done for other commands such as buy, sell, etc. and in order to maintain consistency in documentation, it should also be done for this search command.

In .jar file

In UG

The details being returned by the unmark command in the program as per the .jar file is not accurately reflected in the User Guide as seen in the aforementioned screenshots. This is done for other commands such as buy, sell, etc. and in order to maintain consistency in documentation, it should also be done for this unmark command.

The UG specifies that a .txt file is generated with the data from the program but there is no .txt file in the directory where the .jar file is stored. Only a data folder with two .ser files are created, which also cannot be opened by any pre-installed applications.

Failed to fetch price from API in bookmarks command

When the mark command was used to add 3 different stocks to the bookmarks, after which the bookmarks command was called to view the info of all the bookmarks, the progam failed to fetch the information for the last tsla stock that was added.

buy Command is accepting negative integers as input

As per the user guide, the quantity specified by the user to purchase the stocks is an integer (as seen in buy /STOCK_TICKER quantity). However, when a negative integer is being provided as input to quantity as seen in the above screenshot (buy /fb -2), the user is technically "selling" the stock instead of the program returning an error. This is a functional bug that can be fixed since the sell command is reserved for this function.