Constructing a definition of a Proc (anonymous struct) containing a Proc doesn't raise about attributor HOT 4 CLOSED

1. We should raise an error when an Attributor::Struct inside another Attributor::Struct is unnamed. We do not have any handle to an anonymous struct underneath, hence the original example above is not useful.
2. Also, when encountering an attribute definition with a name and a block, we do not infer the type to be an Attributor::Struct. We should do that.

Until we fix the above two problems, the workaround will be to explicitly give the name AND type:

attribute_definition = Proc.new do
  attribute 'metrics', Attributor::Struct do   # <====== LIKE HERE
    attribute 'months', Attributor::Integer
  end
end

klass = Attributor::Struct.construct(attribute_definition)

from attributor.

What would you expect the resulting object to do in the first case? It's just a proc that wraps a proc, there's no outer attribute.

from attributor.

@careo Yep, I think that's exactly my point. Since there's no outer attribute, there is no way to get to the underlying attribute. Or at least, I don't believe there used to be. There has been a bunch of changes in the last year, so not sure if this is still a valid concern.

from attributor.

Ok. So not really something to fret.

from attributor.