Comments (5)
- 721b6a1
- yes, that's probably a good idea
- Is the language that a hook is implemented in actually important? pre-commit is supposed to make that irrelevant
- It's not always
.git/hooks/pre-commit
(submodules, customGIT_DIR
, etc.). PRs welcome if you think you can improve the current verbiage though :) - heh, neither is global
exclude
nor the new configuration format -- I've been meaning to add a section about that. - I think merging them actually creates more confusion -- it also makes it difficult to differentiate between the current repository and a hook repository (is
./
os.getcwd()/...
orhook-repo/...
?).
from pre-commit.com.
Is the language that a hook is implemented in actually important? pre-commit is supposed to make that irrelevant
Yes I think it is, because:
- Docker based hooks require a Docker engine
- Go hooks require Go installed.
Same for Ruby & Swift I guess, even if I never used them
For the rest, I don't want to pressure you, there's no hurry :)
I may send a PR to suggest some wording changes
from pre-commit.com.
Sweet, if you want to try and take a stab at the language bits, the code for that sits here and here.
from pre-commit.com.
Sure. You can assign this to me
from pre-commit.com.
I think this has been addressed -- thanks again!
from pre-commit.com.
Related Issues (20)
- document pre-commit in a merge-request pipeline HOT 1
- Link to `default_install_hook_types` is not correct HOT 4
- Documentation assumes incorrectly that a tag is an immutable ref - leading to a supply-chain security risk HOT 1
- Add sql-formatter hook HOT 2
- Add `Rome` formatter as a mirror. HOT 2
- Itโs not clear which languages canโt be used for local hooks HOT 3
- Version in docs is out of date HOT 1
- pre-commit ci incorrectly reports an error with the walrus operator (python 3.11) HOT 2
- License still necessary
- Ambiguous documentation HOT 1
- `pretty-format-json` timeout error HOT 3
- Filter hooks by language HOT 1
- Bot keeps bumping ruff-pre-commit to incompatible release HOT 6
- Will a hook be accepted if one of the hooks in `.pre-commit-hooks.yaml` is `system`? HOT 3
- [pre-commit]: Spellcheck hook for source code and gitlab/github for commit messages and MR/PR descriptions HOT 1
- If possible, please remove stackoverflow from https://pre-commit.com/#getting-help HOT 2
- Hook fail_fast stops pre-commit if any prior hook fails HOT 2
- pipx installation option HOT 5
- Add Dark Theme HOT 1
- Can we have a CONTRIBUTING.md document? HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pre-commit.com.