Giter VIP home page Giter VIP logo

Comments (5)

asottile avatar asottile commented on July 23, 2024
  • 721b6a1
  • yes, that's probably a good idea
  • Is the language that a hook is implemented in actually important? pre-commit is supposed to make that irrelevant
  • It's not always .git/hooks/pre-commit (submodules, custom GIT_DIR, etc.). PRs welcome if you think you can improve the current verbiage though :)
  • heh, neither is global exclude nor the new configuration format -- I've been meaning to add a section about that.
  • I think merging them actually creates more confusion -- it also makes it difficult to differentiate between the current repository and a hook repository (is ./ os.getcwd()/... or hook-repo/...?).

from pre-commit.com.

Lucas-C avatar Lucas-C commented on July 23, 2024

Is the language that a hook is implemented in actually important? pre-commit is supposed to make that irrelevant

Yes I think it is, because:

  • Docker based hooks require a Docker engine
  • Go hooks require Go installed.
    Same for Ruby & Swift I guess, even if I never used them

For the rest, I don't want to pressure you, there's no hurry :)
I may send a PR to suggest some wording changes

from pre-commit.com.

asottile avatar asottile commented on July 23, 2024

Sweet, if you want to try and take a stab at the language bits, the code for that sits here and here.

from pre-commit.com.

Lucas-C avatar Lucas-C commented on July 23, 2024

Sure. You can assign this to me

from pre-commit.com.

asottile avatar asottile commented on July 23, 2024

I think this has been addressed -- thanks again!

from pre-commit.com.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.