Giter VIP home page Giter VIP logo

Comments (12)

Predelnik avatar Predelnik commented on August 16, 2024

Yeah most likely it's some plugin, can you send me list of plugins you have?

from dspellcheck.

ArkadiuszMichalski avatar ArkadiuszMichalski commented on August 16, 2024

Its no necessary, problem make NppQCP.dll - Quick Color Picker Version 1.1.1 ( Unicode ). Please answer if you can give a workaround or if I need to write to the author of the QCP.

Edit:
And more info, this happend only if I have open .js file, min/max window and style broke in all file. Now I see min/max is no necessary, example in .css file (with some color declaration).

from dspellcheck.

Predelnik avatar Predelnik commented on August 16, 2024

Well it will be not easy to sort out that's for sure.
I try to explain it in detail. The first thing - scintilla (which is basically main component of Notepad++) - allows to use indicators numbered from 8 to 31 (Indicators are basically underlines with specific color and style). There is no mechanism in Notepad++ to determine which are already in use by other plugins. From the beginning I used the one numbered 9 basically just because I copied it from other spell-checking plugin without much knowledge about all this stuff. Number of indicators in use by NppQCP from looks of it's source code equals number of different colors it found on the current screen (probably not very much actually), it starts from 8 and uses one for each color. Since number I used is relatively small my plugin starts to fail very fast. So basic thoughts:

  1. Temporary solution - to move indicator number I'm using higher (maybe even to 31)
  2. Good solution would be to create patch for Notepad++ which allows plugins to ask for free indicators for their purposes and tell that they are free to use if they don't need them. And then rewrite all the plugins using indicators to use this system. But I haven't sent any patches for Npp before, so can't be sure that it will be accepted of course)
    Temporary solution could be implemented very fast I plan to release bugfix version soon anyway.

from dspellcheck.

ArkadiuszMichalski avatar ArkadiuszMichalski commented on August 16, 2024

Thx for nice and detailed explanation, the easiest solution is moved NppQCP.dl and use other tools for color :), spell checker is more important for me. But I will follow the progress on this issue. Maybe write variant 2) on NPP forum?

from dspellcheck.

Predelnik avatar Predelnik commented on August 16, 2024

Well from my experience the best way to ask for some feature in N++ is to implement it yourself and propose a patch, this stuff looks too much uncritical to be added by some of the major developers I guess) I will think about it though)

from dspellcheck.

Predelnik avatar Predelnik commented on August 16, 2024

In last version I fixed issue partially, actually there was still a lot of used indicators near 31 also, so not very much of the free ones, but I moved number of the one of I use a bit higher.
https://dl.dropbox.com/s/0o9pa5zys4w5gs2/DSpellCheck.dll

from dspellcheck.

ArkadiuszMichalski avatar ArkadiuszMichalski commented on August 16, 2024

I check this version and something is wrong, now when I min/max window (in .js file) DSpellCheck not work, my errors lost style, I must run Npp again or click Aply in option. Now is worse than before:)

from dspellcheck.

Predelnik avatar Predelnik commented on August 16, 2024

Can you plz share with me .js file you're using or something similar which breaks it. And btw why it is worse, isn't it actually the same in this case?

from dspellcheck.

ArkadiuszMichalski avatar ArkadiuszMichalski commented on August 16, 2024

It can be any .js file where make some error for DSpellCheck. Behavour now is not the same, before style was change (red -> blue), but error still exist. Now all errors disappears, just like the plugin is disabled.

Edit:
I test in CSS file:

  1. at the beginning I put few colors and error and works fine.
  2. in the middle I put more colors and error and style changed (when scroll to this place)
  3. in the end I put a lot of colors and error and when scroll to this place error DSpellCheck disappear. NppQCP.dll still works, I can click to color and get palette.

Now I see min/max tt is not necessary, such behavior causes scroll document too. So the problem is in the case 2. (lower) and 3. (high). And 3. not exist in previous version DSpellCheck.

For more detail: 3. exist in previous version DSpellCheck, when we have more colors and errors then errors disappear, but when I scroll to place where colors and errors are less, then DSpellCheck works again (with case 2.).

from dspellcheck.

Predelnik avatar Predelnik commented on August 16, 2024

Well actually only indicators from 8 to 21 are free to use, so it's only 14 indicators, obviously colors will run out fast, if you have lots of them and as I said I have very little control about it.

Btw just noticed a funny bug if you create new file, set language to CSS write #000000 and press enter Npp will crash, it happens only with QCP ))

About changing style to invisble, my theory is that QCP acts not very friendly about indicators, it uses them for different colors, until there's no more left and after that it clears all of them (sets them to invisible style) and starts filling from the beginning. (I might be wrong but actually I remember something like that in it's source code, I'll confirm a bit later) So basically my indicator is being destroyed, but in previous version it was filled out again very quickly 'cause it was near the beginning of indicators which are free to use, now it's near the end so it isn't being filled (well, probably).

Well I will try to implement my second solution, at least create post about it on N++ on ideaTorrent and hopefully if someone will support it, I will be able to add required patch to the source, but it would require cooperation from QCP author also, so probably won't be too quick.

from dspellcheck.

ArkadiuszMichalski avatar ArkadiuszMichalski commented on August 16, 2024

Quick Color Picker 2.0 was fixed (https://github.com/nulled666/nppqcp/blob/wiki/Changelog.md), this problem not exist in actual version of NPP, DSpellCheck and Quick Color Picker 2.0, so bug can be close.

from dspellcheck.

Predelnik avatar Predelnik commented on August 16, 2024

Bug can be closed as mentioned above so I'm closing it 😉

from dspellcheck.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.