As the title says.

Currently, in all of the fireXXXX(...) methods, it is not checked whether or not an event has been consumed in the chain of ControlAdapters.

I wrote a ControlAdapter to change how left-clicking works, depending on a keyboard modifier. I wanted to consume the appropriate MouseEvent so it didn't propagate to all other listeners (like the PanControl).

Now I understand I can either add my own pan functionality to my custom adapter, or add/remove adapters on demand, but those options seem a bit hacky and overly-cumbersome.

It might be nice for historical reference to include the commit history of the original project from the old SourceForge CVS repo, from before the community handoff and development started on Git. Would you be interested in pulling that into the GitHub repo?

Here's an example of what it could look like: https://github.com/apjanke/prefuse-history. This repo was created by using cvs2svn to export the old project's CVS history, and then prepending that to the history of the current https://github.com/prefuse/Prefuse repo.

As title states. The TreeView (demo) misses some edges when depthLevel = 0.

I've described steps to reproduce, images showing the problem and sample code here:

https://github.com/markhm/prefuse_demos/

https://prefuse.org/ changed owners after 2018 and no longer describes this software. Should the address in README should be updated to the current homepage (if any) or removed?

Hello,
Are the sections of the User Manual "Under Construction" ever going to be updated? There are still many people trying to learn how to use this.

Thank you!

Taking a working treeML file and changing an attribute value to contain "<" causes the following error:

Dec 15, 2012 7:50:23 PM prefuse.action.ActionList run
WARNING: Invalid row index: -1
java.lang.IllegalArgumentException: Invalid row index: -1
at prefuse.data.tuple.TupleManager.getTuple(TupleManager.java:90)
at prefuse.data.Tree.getRoot(Tree.java:286)
at prefuse.action.layout.graph.TreeLayout.getLayoutRoot(TreeLayout.java:67)
at prefuse.action.layout.graph.NodeLinkTreeLayout.run(NodeLinkTreeLayout.java:249)
at prefuse.action.ActionList.run(ActionList.java:79)
at prefuse.action.Action.run(Action.java:122)
at prefuse.activity.Activity.runActivity(Activity.java:152)
at prefuse.activity.ActivityManager.run(ActivityManager.java:365)

I did some searching around and this appears to be illegal in XML, but using the XML replacement "&#60;" doesn't seem to work, here.

Beleive that
public float getFloat(final Tuple t) {
return getFloat(t);
}

is
public float getFloat(final Tuple t) {
return getInt(t);
}

Return value of String.trim() ignored in prefuse.data.search.KeywordSearchTupleSet.search(String)
The return value of this method should be checked. The cause of this bug is to invoke a method on an immutable object, thinking that it updates the object.
But since Strings are immutable, the trim() function returns a new String value, which is being ignored here. The code should be corrected to: query = query.trim();

When trying to clean up my memory when using the a class that overrides Display (we use prefuse in an MDI environment), I was seeing that my classes were still held in memory, due to m_predicate in Display.java holding on to my class' reference.

To fix it, I added a method in AbstractExpression.java: removeAllExpressionListeners() that just clears m_listeners, and then call that method when I am cleaning up my Display.

There is no GML reader in current prefuse

Hi,

I am using the class ForceDirectedLayout in order to layout the positions of graph elements,
but I would like to be able to define the length of each edge. I have redefined getSpringLength in order to reach my goal, I have also use explicitly addSpring from ForceSimulator, but nothing changes. Could you please tell me what is missing me?

Best regards,
Marta Nascimento

May be
if (c1 == float.class || c1 == float.class)
return float.class;
must be
if (c1 == float.class || c2 == float.class)
return float.class;

There are 37 pieces of dead code, 4 unused local vars, and 59 Serializable classes with no serialVersionUID.

All but one of the dead code warnings is in the generated prefuse.data.expression.parser.ExpressionParser. They take the form of 'break' statements after 'return' statements or 'throw' statements after 'return' statements preceded by useless 'if(true)' conditions. I know very little about JavaCC, so I have no idea why it generated all this dead and useless code. I fixed it by hand in this commit: https://github.com/kjkrum/Prefuse/commit/59bb669d695f12c65930c08517bec9564a657a1e

I also added a default serialVersionUID to all Serializable classes: https://github.com/kjkrum/Prefuse/commit/64f2c97fac060af6d81fb41fcf2119791b1d1363

I was more cautious about fixing the unused local vars and the one remaining piece of dead code. I didn't want to just go in and remove them without understanding the author's intent, because the dead code may point to a bug. Only one of the unused local vars seemed to have an obvious intent: https://github.com/kjkrum/Prefuse/commit/b740787e59b0d88d01eab52586e4d8aa8b365b4a

I'd appreciate some help understanding the intention behind the remaining four.

prefuse.data.util.BreadthFirstIterator line 168: The increment part of the 'for' is dead code because the method always returns on the first iteration of loop.

prefuse.data.tree.Tree line 587: 'ncount' is incremented but never used.

prefuse.action.layout.StackedAreaChart line 261: 'sum' is incremented but never used.

prefuse.action.layout.graph.SquarifiedTreeMapLayout line 135: 'leafCount' is incremented but never used.

This is a request to rearrange the project so that it can be built with Maven, maybe separating it in modules.

As described here:
https://sourceforge.net/p/prefuse/discussion/343012/thread/11121b8a/

Problem still exists, confirmed today.

There are many threads about memory leaks on the old SourceForge Prefuse forums. I've tracked down a few of them that were affecting my own project:

TreeLayout and its subclasses retain references to NodeItems as m_root
RadialTreeLayout retains a reference to a NodeItem as m_prevRoot
GraphDistanceFilter retains references to NodeItems in m_bfs

I've added reset() methods to clear these references. I'm sure the same thing needs to be done to many other classes. Git is an annoyance for me (I rarely use it and have to re-learn it every time I do) so until I get around to pushing my changes and creating a pull request, be aware of these potential memory leaks. I'd be perfectly happy if someone else pushed the changes and took credit for the fix.

Concerning the last little block of code in the setBounds(VisualItem item) method in the EdgeRenderer.java class, I added one print statement in the middle that checks to see if m_curArrow is null. Here's my version:

if ( m_curArrow != null ) {
Rectangle2D bbox = (Rectangle2D)item.get(VisualItem.BOUNDS);
if ( m_curArrow == null )
{ System.out.println(“ But now m_curArrow is null.”); }
Rectangle2D.union(bbox, m_curArrow.getBounds2D(), bbox);
}

It seems impossible, but I have some data sets that cause the print statement to get executed. My best guess is that the VisualItem.BOUNDS constant is no longer maintained, and passing Visual.BOUNDS to get() is causing some strange side efects.

I would have proposed a fix to this problem, but to be honest, I don't quite understand what this block is supposed to do. It declares bbox, updates it, and then seems to do nothing with it.

For my own purposes, I've simply added a check to see if m_curArrow is null in my own copy of the code. But I thought that I should open a GitHub issue so that the defect does not get forgotten.

Now:

Back then:

(via https://web.archive.org/web/20180308141540/http://prefuse.org/)

Suggestion: Remove the link from the repository information

The newest version in Maven central is a beta from 2007. Can we get the current version submitted? I might be able to do it myself, but I'd like the blessing of the maintainers and a consensus about what revision to submit and what version number to call it.

http://maven.apache.org/guides/mini/guide-central-repository-upload.html

When you try to present an empty tree view, prefuse complains:

Jul 17, 2013 2:16:03 PM prefuse.action.ActionList run
WARNING: Invalid row index: 0
java.lang.IllegalArgumentException: Invalid row index: 0
at prefuse.data.tuple.TupleManager.getTuple(Unknown Source)
at prefuse.data.tuple.TupleManager$TupleManagerIterator.next(Unknown Source)
at prefuse.data.Graph.getSpanningTree(Unknown Source)
at prefuse.action.filter.FisheyeTreeFilter.run(Unknown Source)
at prefuse.action.ActionList.run(Unknown Source)
at prefuse.action.Action.run(Unknown Source)
at prefuse.activity.Activity.runActivity(Unknown Source)
at prefuse.activity.ActivityManager.run(Unknown Source)

To reproduce modify Prefuse/demos/prefuse/demos/TreeView#setUpData(), comment all lines after the creation of the graph, and start it.