Giter VIP home page Giter VIP logo

blender_rhubarb_lipsync_ng's People

Contributors

989onan avatar morevnaproject avatar premik avatar scaredyfish avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar

Forkers

itsmesunnymunda

blender_rhubarb_lipsync_ng's Issues

Won't install Blender 4.0.2

Hi,

I am getting an error when trying to install into the latest Blender.
Attached a screenshot of the error

image

More automation and batch processing

Extracted from the original issue

Wishlist for the future: I used to use a modded-version of the old Rhubarb addon which combed the VideoSequencer for sound files (named in such a way you could tell which rig/character it applied to), then automatically process these one by one, selecting the appropriate rig for each as it went. It let you do an entire scene, with multiple characters saying multiple lines to each other, with a single-button push. Perhaps the same thing would be possible with RLSP if there was a similar loop scanning the Video Sequencer, automatically selecting the sound setup and cues capture, mapping and baking, through the list.

Blender 3.6 error - Plugin failed to register on Mac

Thank you so much for taking over this project.
When attempting to install on a Mac.
1.0.1 or 1.0.2

Traceback (most recent call last): File "/Applications/Blender.app/Contents/Resources/3.6/scripts/modules/addon_utils.py", line 333, in enable mod = __import__(module_name) File "/Users/{user}/Library/Application Support/Blender/3.6/scripts/addons/rhubarb_lipsync/__init__.py", line 34, in <module> rhubarb_lipsync.blender.auto_load.init(__file__) AttributeError: partially initialized module 'rhubarb_lipsync' has no attribute 'blender' (most likely due to a circular import)
1.0.3 also gives an error regarding numpy installation

Fork partially working on Linux - no option for text document, "Sync time on select" goes to frame 0 and "place strip" problems

Hi there,

Amazing work on what you've done with the fork so far, thanks a lot. Rhubarb is essential. :)

I've gotten the plug-in working on Linux Mint - up to a point. I can get the capture working on the speech audio file, but some of the keyframing is missing. I hand-'baked' the keyframes to an action strip by clicking on the outputs below the capture button generated by your fork and then applying the appropriate animation, as created by me, from Blender's new(ish) pose library. The keyframes that your fork suggested were perfect in terms of timing and choice of mouth shape. However, there were several that were missing. Do you plan to include the option to load in a text file, to support the audio file a user wishes to keyframe? As you know, this was available in the original version of Rhubarb.

Also, the fork's "Place as strip" function is placing the audio on frame 0, channel 128(!) of the VSE, regardless of the instructions I give it.

Having the outputs that are returned once one captures from audio work as buttons, which move the play-head to the appropriate place in the timeline is an excellent work-around whilst automatic mapping/baking is still in development. However, the time jumps between the keyframes are currently relative from frame 0, not where the relevant sound block is located in the VSE.

I'm sure these are all teething problems, though. You have on your hands a fork which could surpass the original in every respect.

Not working with Rigs in Linked Libraries with proposed Fix

Thanks for porting BlenderRhubarb to work under the new poselib-less system. I was about to do this myself, and lo and behold, you've already done it, and with improved usablity.

However I've found a problem. When the rig is Appended from the Asset Library, it works, but when it is linked-and-overriden (Linked from the Asset Library, then Make Override) it only gets as far as 'Initialize mapping list'. When I hit that button, I get this error message:

Traceback (most recent call last):
  File "C:\Users\guest\AppData\Roaming\Blender Foundation\Blender\3.6\scripts\addons\rhubarb_lipsync\blender\mapping_operators.py", line 36, in execute
    mprops.build_items(context.active_object)
  File "C:\Users\guest\AppData\Roaming\Blender Foundation\Blender\3.6\scripts\addons\rhubarb_lipsync\blender\mapping_properties.py", line 112, in build_items
    item: MappingItem = self.items.add()
TypeError: bpy_prop_collection.add(): not supported for this collection
Error: Python: Traceback (most recent call last):
  File "C:\Users\guest\AppData\Roaming\Blender Foundation\Blender\3.6\scripts\addons\rhubarb_lipsync\blender\mapping_operators.py", line 36, in execute
    mprops.build_items(context.active_object)
  File "C:\Users\guest\AppData\Roaming\Blender Foundation\Blender\3.6\scripts\addons\rhubarb_lipsync\blender\mapping_properties.py", line 112, in build_items
    item: MappingItem = self.items.add()
TypeError: bpy_prop_collection.add(): not supported for this collection

Here's the mapping_properties.py code in question, error line marked:

    def build_items(self, obj: bpy.types.Object) -> None:
        # log.trace("Already buil")  # type: ignore
        if len(self.items) > 0:
            return  # Already built (assume)
        log.trace("Building mapping list")  # type: ignore
        t1: NlaTrackRef = self.nla_track1
        t2: NlaTrackRef = self.nla_track2
        t1.object = obj
        t2.object = obj
        for msi in MouthShapeInfos.all():
            item: MappingItem = self.items.add() # <----- ERROR HERE
            item.key = msi.key

I used old-Blender-Rhubarb with linked-overriden rigs since 2.8 without any problems.

If you haven't used linked-overriden rigs before:

  1. Create a rig 'myrig' in a file mylib.blend
  2. Create a new .blend file, then File -> Link -> mylib.blend -> Objects -> myrig -> Link Button.
  3. Select myrig in outliner. Then right-click -> Library Override -> Make -> Selected
  4. myrig should now work like a normal rig.

Searched around, and the problem seems to be this:
"Library Override: can't add to Collection properties #82118" https://projects.blender.org/blender/blender/issues/82118
This seemed to fix it:

class MappingProperties(PropertyGroup):
    """Mapping of all the mouth shape types to action(s)"""

    items: CollectionProperty(type=MappingItem, name="Mapping items",
        options={'LIBRARY_EDITABLE'},
        override={'LIBRARY_OVERRIDABLE', 'USE_INSERTION'})
    ...

However found all the other properties in the 'RLPS: Cue Making and Baking' were greyed out.
Found adding this to all the other properties - there are many - fixed it:

,
        options={'LIBRARY_EDITABLE'},
        override={'LIBRARY_OVERRIDABLE'}

After this, it seems to be working. Couldn't find any documentation on USE_INSERTION (Not alone! https://blender.stackexchange.com/questions/254730/what-is-the-safe-way-to-add-library-overridable-custom-properties ) but I assume it's something collection specific so not needed for the other properties?

Granted, making Addon authors add those lines after every Property seems a silly requirement which will break many addons,
but could you please do that for Rhubarb NG so they at least work with it? I've attached the two files I modded (file extension renamed so Github is happy). Seems to work though you might prefer to make the changes yourself in case I accidentally broke something.

mapping_properties.py.txt
strip_placement_properties.py.txt

Thanks for your effort.

Incorrect licence for blender addon

Hi, thanks for taking over the development of this addon. I just wanted to let you know that you arnt allowed to use the MIT licence for blender addons. Blender addons must be released under a GPL v3 compatible licence and cannot be released under a permissive licence. This is due to addons using the blender API which is GPL software.

from blenders website:

Sharing or selling Blender add-ons (Python scripts)

Blender’s Python API is an integral part of the software, used to define the user interface or develop tools for example. The GNU GPL license therefore requires that such scripts (if published) are being shared under a GPL compatible license. You are free to sell such scripts, but the sales then is restricted to the download service itself. Your customers will receive the script under the same license (GPL), with the same free conditions as everyone has for Blender.

https://www.blender.org/about/license/

Rhubarb executable can generate cues from audio file but Capture does not generate cues inside Blender

Hello, I am having a bit of a strange issue. I am using Blender 3.5

The problem is that when I load an audio file into rhubarb in blender and run Capture, it goes through progress and then at the end nothing happens and no error message is returned. Cues are not generated.

I tried troubleshooting by verifying that rhubarb.exe can generate cues from the same audio file, and it does. I can see the desired cues print out to the console by running rhubarb -r pocketSphinx PATH_TO_WAV_FILE

Is there anything I can do to better troubleshoot or does anyone have any ideas for what I might try instead? Thank you!

Actions not appearing in cue mapping

Thanks so much for your work on this!

Blender version - 4.0.2
OS - macOS Sonoma 14.3

I'm using the Mecaface add-on (https://mecabricks.com/en/shop/product/6), which creates a face rig with a set of preset poses in the asset browser / Actions.

The audio capture works fine. However, when I'm trying to map the saved poses to the capture cues, they do not appear as Actions with any of the mapping options (screenshot attached). Have tried multiple different ways to get this working but can't seem to figure it out, any help appreciated!

Screenshot 2024-01-03 at 11 41 50 AM

UI Missing in Windows 10

Hello, and THANK YOU for picking up the development on this addon.

Version 0.9.1
Windows 10
Blender 3.6.0

After installing and creating an armature with the requisite phoneme poses, I can't find the Rhubarb for Blender UI. See screenshot below.
I hope I'm just being dense! I've looked through all the various Properties tabs, but TRASHME is where I assume it should show up.

BugRep_Missing_UI

As can be seen, I'm in pose mode, the addon is toggled active, and the poses exist. I assume the UI should be there even if the rig/assets aren't in place or set up correctly?

The only 'unusual' think I can think of in my .blend is, the image plane is not parented to the Armature, as I'm just controling the UV Mapping of UDIM tiles (via drivers in the Shader, I find the UV Warp modifier irritating). I didn't set up a whole character with a proper parent rig, etc.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.