Giter VIP home page Giter VIP logo

jekyll-octicons's Introduction

โš ๏ธ This repo is deprecated!

We've moved all of the Octicons modules to a single repository. You can still install and update jekyll-octicons with rubygems, but its code and issues now live elsewhere.

jekyll-octicons's People

Contributors

bkeepers avatar jonrohan avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar

jekyll-octicons's Issues

How to set `viewBox`?

{% octicon pulse width:32 height:32 viewBox:xxx aria-label:pulse %}
it's not work.

no viewBox option?
Tks!

Liquid interpolation is unpredictable

It's hard to tell what works and what doesn't. For instance, simple expressions in the positional name argument {% octicon {{ foo.bar }} %} seem to work, but anything more complicated doesn't. Attributes are even tricker. I've never gotten this to work, for instance:

{% octicon file-directory class:"fill-{{ color }}" %}

Instead, I've resorted to some awful hacks to work around a failure to interpolate values from the "outer" Liquid context:

{% capture octo %}{% octicon file-directory class:"fill-${COLOR}" %}{% endcapture %}
{{ octo | replace: "${COLOR}", color }}

I'm not totally sure what's happening here, but I think that what we could do is interpolate the whole @markup string instead of the icon name and attributes separately, then parse the resulting value. So there'd be an intermediary step in rendering the tag when we'd convert something like:

{% octicon {{ name }} class="fill-{{ color }}" height:{{ height }} %}

to:

{% octicon file-directory class:"fill-green" height:20 %}

This would be a good chance to write some more robust tests.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.