Giter VIP home page Giter VIP logo

primer-forms's Introduction

โš ๏ธ This repo is deprecated!

We've moved all of the Primer CSS modules to a single repository. You can still install and update primer-forms with npm or Yarn, but its code and issues now live elsewhere.

primer-forms's People

Contributors

broccolini avatar cmwinters avatar jonrohan avatar muan avatar pmarsceill avatar shawnbot avatar

Stargazers

 avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar

primer-forms's Issues

Input group inside form group

@PetrKaleta originally wrote primer/css#147

Is there any possible way, how to do that or are you planning to support it? I've checked forms source and currently it seems to be impossible because form group is rewriting input's attributes directly

no style when the input element set with disabled attribute

@Jeff2Ma originally wrote primer/css#186

First of all, thanks for making this project, while using I find that when the input element set with disabled attribute, no style for this state. I think it would be better when style with css like:

.form-control[disabled] {cursor: not-allowed;}

or something else to make distinctions from the normal state.

sorry for my poor English, Thank you :)

Select element shouldn't have the same shadow rendering as input element

Something that's been bugging this designer. select elements are generally rendered as buttons, since they don't take direct text input.

This is consistent throughout browsers / operating systems that haven't been completely flattened. I'd suggest simply flipping the inset shadow on selects to be consistent with browser behavior while maintaining the GitHub aesthetic.

Current
This has the same styling as a text input.
primer-inset

Proposed
Simply flipping this will render this closer to a button, mimicking other browser / os behavior.
primer-suggested

Safari
mac-safari

Chrome
mac-chrome

Firefox
mac-firefox

@primer/design-systems

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.