Giter VIP home page Giter VIP logo

discode's Issues

[enhancement] change URL implementation

It allows us to create multiple rooms with the same room name. Is this supposed to behave this way with duplicate entries?

Though, I would understand since your URL is based on a number that keeps incrementing, and not based on the room name.

image

However, I feel a system with random alpha-numeric addition (slug) to the URL, like Google Meet or any URL shortener, (instead of the incrementing number approach, because right now, I could simply put any number below the current room number, and we can get access to the code and voice conversations), will help maintain privacy and no disruption or deletion of code.

Simply because the generated URL will be difficult to guess. And this way you might not need a way to authenticate a user, since the link will be only shared with the trusted users.

Room Name needs more validation

While creating room, the validation is only working for "Empty/NULL" value as shown below. The room is even creating for "Space" as a name.

image

Problem in synchronization of rooms

When a new user joins a room, he loads data from database, however if somone has already made a change there but not saved, this user won't get this updated to them unless the other user makes 1 more change.
This also results in problem when now newly joined user types something changing the contents of previous user.

"Choose Theme" and "Font Size" are not replicating.

The default values for "Font Size" is 18 and for "Choose Theme" is monokai for Screen 1. If I change these values before sharing my ID for Screen2, the Screen 2 is having Default values only. Also the changes I change in Screen 1 are not replicating in Screen2 for these tabs.

Screen1:
image

Screen 2:
image

As you can see from the both images, only the "Choose Language" tab is reflecting.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.